Ensure provider hook calls don't crash because of invalid command line arguments #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good fix, but we'll need to add a test for this before we merge it. This is core dispatching functionality we shouldn't change without repeatable validation. |
|
ping @tolbrino |
I got blocked by trying to get a test working, but to no avail. I will take a look again some time later this week. |
…e arguments Normally the CLI arguments are intended for the provider which is called directly. When these are forwarded to other providers through hooks things might break.
tolbrino
force-pushed
the
tb-fix-prodiver-hook-args2
branch
from
99477cf
to
1d8db94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally the CLI arguments are intended for the provider which is called
directly. When these are forwarded to other providers through hooks
things might break.