-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FoxyTabs Not Recognizing Sideberry Tabs #589
Comments
FoxyTab menu is handled by Firefox based on menus.ContextType being It appears wherever |
It does not. Is there a workaround to this? What is the ContextType of the Sideberry tabs? Can I switch what ContextType FoxyTabs works with? |
Those are not tabs. They are actually a list with the details copied from the tabs. However, I have seen some other extensions do it. See also: #575 |
Yes, I used to use TST, and I read the issue prior to opening this new one, but I'm not interested in going back since Sideberry is so much more potent. Let me ask another way. First let me make a glossary for the terms I'm about to make up for the sake of the question:
Questions
I know very VERY little about coding, but I imagine the code says something along these lines: I'm sure this is FAR from accurate, but my logic tells me that this is essentially what's happening in the code. So my question is: Can we make it say something like this instead: Also, I would like to mention that SingleFile does interpret the Sideberry "Links" as tabs, as you can see in the video I attached. If SingleFile can do it, why not FoxyTabs? |
In browsers, menus.ContextType affects not only where a context-menu appears but also the data that is passed when clicked i.e. menus.OnClickData. Data provided when a link is clicked, or an image is clicked or text clicked etc differs from when a tab-strip is clicked.
Unfortunately, it is not possible. |
Sorry, I don't see how that answers my question. I understand that different context menus appear for different content types. I want to know what a Sideberry "tab" is if it's not a tab or a link. What is the damn thing? XD XD Is there anything to say about different context menus popping up when you right-click while holding down the SHIFT key?
If it's not possible, then what exactly is to blame? Is it the fact that the FoxyTabs code is not accessible, or is it the Firefox browser code that's not accessible? Is it something else entirely? Wouldn't the solution be something as simple as adding the following instructions to the FoxyTabs Code
|
FoxyTab adds a menu to the standard tab-context-menu and then Firefox shows it. To finalise, the issue is "Firefox Not Recognizing Sideberry Tabs" and that is something for Sideberry Tabs to sort out. |
Goooot it! Thank you very much for your help! |
If you follow the link https://github.com/mbnuqw posted in his reply, you'll see that Sidebery does, in fact, use the mbnuqw/sidebery#1195 (comment) Above is a link to the entire conversation, which is a short one in which I realized that all my add-ons work with Sidebery, except FoxyTabs. |
So, what is the issue? |
I've configured everything on my Sidebery to be a certain way, including the context menu. I switched it, but I prefer Sidebery's context menu so I switched it back. The problem is that I want to be able to access the FoxyTabs options using |
SideberrySideberry show 2 types of context-menu:
FoxyTab
Standard Tab context-menu |
@erosman Understood. Thank you for your patience, it is very much appreciated! What I still don't understand is how the "Multi-Account Containers" is able to show up in that
Maybe Firefox's "Multi-Account Containers" doesn't base it's function on tabs, but if that's the case then it's confusing how it could open tabs in containers and have all sorts of rules for Again, I appreciate your patience and knowledge on the matter! |
Actually, I tested it now. It is not a problem to make FoxyTab context-menu show on
Data received from FoxyTab context-menu when clicked in SideberryUse native context menu = on (
|
This means that the necessary data needs to be added by Sideberry, then? |
No, Firefox doesn't add the data when a click is generated from an extension's internal page (the sidebar). Incidentally, as part of another issue (w3c/webextensions#431 (comment)), we have been discussing the provision of |
Is there a way to allow FoxyTabs to recognize my Sideberry tabs as actual tabs yet?
I customized the Firefox browser CSS file to get rid of the horizontal tabs toolbar, so that I can only use the vertical Sideberry sidebar, which is the coolest most efficient and productive solution I have found for tab management.
For this reason I do not wish to bring back the original tabs format, so I am willing to do anything to keep using Sideberry, and not willing to do anything that will stop me from using Sideberry.
Any help is greatly appreciated!
The text was updated successfully, but these errors were encountered: