-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing appropriate limit parameter for querying the users in the room #38
Comments
The limit parameter was not used which defaults to 30 and fails to return all the members in the room. Closes errbotio#38
@nvzard This seems to be important since we already depend upon the member list. This seems to be more like a |
I'll make sure to open a PR by tomorrow 👍 |
Also I guess one more important thing would be, we should be able to store the list and update it as required since I think we shouldn't make calls for every command (where we need this). |
@abhishalya Even I took there help a long time ago https://gitter.im/gitterHQ/gitter?at=5bd7328082893a2f3b5c0cc5 Yeah! I'll look into this :)
|
The limit parameter was not used which defaults to 30 and returns maximum 100 users at a time. Hence, it fails to return all the members in the room. In order to tackle this, we need to iterate by skipping 100 members with every API request. Also users count needs to be updated everytime list of occupants is requested as new users may join a room in realtime. Closes errbotio#38
The limit parameter was not used which defaults to 30 and returns maximum 100 users at a time. Hence, it fails to return all the members in the room. In order to tackle this, we need to iterate by skipping 100 members with every API request. Also users count needs to be updated everytime list of occupants is requested as new users may join a room in realtime. Closes errbotio#38
In the following code:
The limit parameter is not passed which defaults to 30. Hence every time it will only return a list of 30 users but since we need a list of all users a suitable value of limit must be passed to the request.
The text was updated successfully, but these errors were encountered: