-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate semantic-release/github to tinyglobby #98
Comments
Depends on thecodrr/fdir#106, otherwise migrated locally. |
Are we sure we should add such a feature to fdir? I feel like it should be one or the other (with or without a slash) and leave it up to the consumer to add or remove Meanwhile, we could strip the end slash ourselves and still get this over the line right? |
@ziebam i'm not sure if that is a blocker to the migration, we should probably ask the |
I've opened a PR: semantic-release/github#938. I manually map the results to match the previous behavior, but I noted in a comment that I'm open to updating the test instead in case the trailing slash isn't breaking. |
Can EDIT: Link to semantic-release repo. |
Opened a PR for it in #98 (comment) |
https://github.com/semantic-release/github/blob/990bd7335df10153c9b87bf2be57db602b08def0/package.json#L33
The text was updated successfully, but these errors were encountered: