Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate semantic-release/github to tinyglobby #98

Open
benmccann opened this issue Sep 8, 2024 · 6 comments
Open

Migrate semantic-release/github to tinyglobby #98

benmccann opened this issue Sep 8, 2024 · 6 comments
Labels
has pr This issue has a corresponding PR in the target repo pr needs update The PR in the target repo has gone stale and needs to be rebased

Comments

@benmccann
Copy link

https://github.com/semantic-release/github/blob/990bd7335df10153c9b87bf2be57db602b08def0/package.json#L33

@benmccann benmccann changed the title Migrate semantic-release/github to tinnyglobby Migrate semantic-release/github to tinyglobby Sep 8, 2024
@pralkarz
Copy link

Depends on thecodrr/fdir#106, otherwise migrated locally.

image

@43081j
Copy link
Collaborator

43081j commented Sep 11, 2024

Are we sure we should add such a feature to fdir?

I feel like it should be one or the other (with or without a slash) and leave it up to the consumer to add or remove

Meanwhile, we could strip the end slash ourselves and still get this over the line right?

@SuperchupuDev
Copy link

SuperchupuDev commented Sep 30, 2024

@ziebam i'm not sure if that is a blocker to the migration, we should probably ask the semantic-release maintainers to see if trailing slashes in results would break users or not

@pralkarz
Copy link

pralkarz commented Oct 5, 2024

I've opened a PR: semantic-release/github#938. I manually map the results to match the previous behavior, but I noted in a comment that I'm open to updating the test instead in case the trailing slash isn't breaking.

@GuskiS
Copy link

GuskiS commented Oct 5, 2024

Can aggregate-error also be removed since engine.node states node20 is needed and aggregate-error mentions that node15 has it already builtin?

EDIT: Link to semantic-release repo.

@mcmxcdev
Copy link

Can aggregate-error also be removed since engine.node states node20 is needed and aggregate-error mentions that node15 has it already builtin?

Opened a PR for it in #98 (comment)

@Fuzzyma Fuzzyma added has pr This issue has a corresponding PR in the target repo pr needs update The PR in the target repo has gone stale and needs to be rebased labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has pr This issue has a corresponding PR in the target repo pr needs update The PR in the target repo has gone stale and needs to be rebased
Projects
None yet
Development

No branches or pull requests

7 participants