Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ What is diff between this plugin and https://github.com/felixfbecker/semantic-release-docker #33

Open
tomavic opened this issue Apr 15, 2023 · 7 comments
Labels
question Further information is requested

Comments

@tomavic
Copy link

tomavic commented Apr 15, 2023

What is diff between this plugin and https://github.com/felixfbecker/semantic-release-docker

I can see that your plugin is much more updated and maintained. This should have more stars than the other plugin so that people coming from Google search like me don't be confused.

Also, please try to add your plugin here as well https://github.com/semantic-release/semantic-release/blob/master/docs/extending/plugins-list.md

@esatterwhite
Copy link
Owner

@tomavic I haven't used this one specifically, But I would have to say, mine is much more configurable and has more template hooks for you to get the most out of it. Additionally, I found the other plugins quite a challenge to work with when operating a mono repo and needing to publish multiple docker images. It plays nice with [multi-semantic-release] https://github.com/dhoulb/multi-semantic-release

This was my primary focus when building this plugin. easy to use by default, configurable at (almost) every level, and works pretty well in a mono repo

@esatterwhite esatterwhite added the question Further information is requested label Jul 7, 2023
@tomavic
Copy link
Author

tomavic commented Jul 12, 2023

Can I use this plugin to create a custom docker container that will be used to run my commands (npm i, npm run build, npx semantic-release)

@esatterwhite
Copy link
Owner

esatterwhite commented Jul 12, 2023

you want this plugin to run npm commands, or you want npm commands to use this plugin to build a container?

@tomavic
Copy link
Author

tomavic commented Jul 15, 2023

Use it to build my container, then run some npm commands from inside this container.

Simply I am building a Docker container that will enable me from running my CI/CD script.
Here is my list of npm commands I need to publish

  • Checkout branch.
  • Auth with npm regitry
  • npm install
  • npm run build
  • npx semantic-release <- here I want to (publish, generate-notes, change-log) ONLY

you want this plugin to run npm commands, or you want npm commands to use this plugin to build a container?

@esatterwhite
Copy link
Owner

you probably could if you set dockerPublish: false and dockerClean:false and tagged them so you know how to reference them.
It's a bit out of scope for what semantic release, and this plugin intend to do. It's probably possible, just not directly supported.

@tomavic
Copy link
Author

tomavic commented Aug 21, 2023

Yeah, my last question is out of scope. But my primary question is the difference between this plugin and the other plugin.

If you could add the diff. in the README so that anyone can know which one should be used.

I appreciate it

esatterwhite added a commit that referenced this issue Mar 13, 2024
when the dockerPlatform array option is supplied and has a non zero
number of items, buildx will be used to build and push images rather
than the standard docker builder.

BREAKING CHANGE: images build with buildx will not be stored locally

Fixes: #44
Fixes: #33
esatterwhite added a commit that referenced this issue Mar 13, 2024
when the dockerPlatform array option is supplied and has a non zero
number of items, buildx will be used to build and push images rather
than the standard docker builder.

BREAKING CHANGE: images build with buildx will not be stored locally

Fixes: #44
Fixes: #33
esatterwhite added a commit that referenced this issue Mar 13, 2024
when the dockerPlatform array option is supplied and has a non zero
number of items, buildx will be used to build and push images rather
than the standard docker builder.

BREAKING CHANGE: images build with buildx will not be stored locally

Fixes: #44
Fixes: #33
@esatterwhite
Copy link
Owner

@tomavic to me it looks like the package you listed doesn't do image builds or anything to that effect. It just tags and pushes them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants