-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect building - @amcharts/amcharts5
#934
Comments
In the broken chart example, I accidentally used multiple versions of AMCharts. In the past, this might have prevented you from finding the real problem. I have fixed this problem and updated the example link in the first post of the thread. Just in case, I’ll write down here a link to the previous example with importing several versions of AMCharts, so that you can compare the examples if necessary: https://codepen.io/qsppl/pen/KwPPLaa |
I've raised a new issue on this topic in the AMCharts repository and there's progress there! A little later I will post the issues found there to this repository |
One of the AMCharts repository contributors (@Pauan) seems to have found the problem:
If we go back to the example, everything looks exactly as he said: Here in the file five But it seems that ESM.SH returned not five modules of one project, but five differently builded projects. Accordingly, all variables exported from modules are their own for each |
Hi, I looked at the issues in the repository of the js builder you use and found several mentions of this problem:
In all cases, to solve the problem, it is recommended to enable code-splitting Is this the right solution and can it be used in ESM.SH? This problem is reproduced in all npm packages with multiple entry points, so our company was forced to abandon ESM.SH in favor of building a JS project locally. Please pay attention to the problem. |
Failing module
Expected
See Donut Chart - Working example
Observed
See Donut Chart - Non-working example(deprecated)See Donut Chart - Non-working example
Additional info
This question has already been raised in the AmCharts repository itself. The AmCharts developers suspect that esm.sh uses its own npm package builder into esm modules and that the AmCharts package was not built correctly.
The text was updated successfully, but these errors were encountered: