Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We lower Case every Header coming from a CSV/Google Sheet #117

Open
DiegoPino opened this issue Aug 8, 2022 · 0 comments
Open

We lower Case every Header coming from a CSV/Google Sheet #117

DiegoPino opened this issue Aug 8, 2022 · 0 comments
Assignees
Labels
AMI Import Plugins Gets data from somewhere, puts data into a strawberry basked documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@DiegoPino
Copy link
Member

And we probably should not

This makes ingesting things like ap:annotationCollection via a CSV impossible

@giancarlobi had the same issue a time ago (my birthday/ Allison helped there).

I found a few instances where we do this. Right now this is not a blocker and makes sense for data coming e.g from Solr but
for CSVs we should preserve case (and tell people to be careful/aware of the case).

The original idea was to avoid data ambiguity since in the past we had people not being careful between data.label and data.Label...

But as we move more into other vocabs/mixed vocals we need to allow mixed cases.

Most of the code responsible for this looks like this snippet

      $rowHeaders_utf8 = array_map('stripslashes', $rowHeaders);
      $rowHeaders_utf8 = array_map('utf8_encode', $rowHeaders_utf8);
      $rowHeaders_utf8 = array_map('strtolower', $rowHeaders_utf8);
      $rowHeaders_utf8 = array_map('trim', $rowHeaders_utf8);

@karomabiles @alliomeria can we discuss this? Thanks

@DiegoPino DiegoPino self-assigned this Aug 8, 2022
@DiegoPino DiegoPino added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed AMI Import Plugins Gets data from somewhere, puts data into a strawberry basked labels Aug 8, 2022
@DiegoPino DiegoPino added this to the 0.5.0 milestone Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMI Import Plugins Gets data from somewhere, puts data into a strawberry basked documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant