Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Log for Twig Template and JSON Failures #128

Open
karomabiles opened this issue Oct 19, 2022 · 5 comments
Open

Create a Log for Twig Template and JSON Failures #128

karomabiles opened this issue Oct 19, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request Reporting Errors, Logs, etc.
Milestone

Comments

@karomabiles
Copy link

WHAT?


A system log/report type that provides information on Twig template ---JSON Failures/Errors and vice versa.

It's all in the details - report expectations (wants)

  • Identify failed Twig Template via title/or #
  • Indicate failed Template line or even cell within CSV
  • AMI Set #

This issue relates to issues #37 and #92.

@alliomeria Can you think of anything else that would be helpful to add in report details?

@karomabiles karomabiles added enhancement New feature or request Reporting Errors, Logs, etc. labels Oct 19, 2022
@alliomeria
Copy link
Contributor

alliomeria commented Oct 19, 2022

@karomabiles think all the other components @DiegoPino put in place via #123 cover what's needed. 😄

For the entry for specific Twig template + JSON errors, an entry along the lines of the current message being generated would be very helpful (icing on the Report 🍰):
$message = $this->t('Sorry, we can not cast ADO with @uuid into proper Metadata. Check the Metadata Display Template used, your permissions and/or your data ROW in your CSV for set @setid.',[ '@uuid' => $data->info['row']['uuid'], '@setid' => $data->info['set_id'] ]);

@DiegoPino
Copy link
Member

Thanks @karomabiles and @alliomeria. I can add the ROW and a bit more detail. I can sadly not add which Column made the JSON fail because the whole JSON will be "rejected" as JSON and thus I will be blind to what part is wrong. But I can give you the general JSON error (e.g Invalid Document, etc) too

@DiegoPino
Copy link
Member

And also the Link to the Twig template. That I can do!

@alliomeria
Copy link
Contributor

Sounds great @DiegoPino! Thank you!

@DiegoPino
Copy link
Member

I think a piece is missing still? Will keep open. Re-tagging for 0.9.0

@DiegoPino DiegoPino added this to the 0.9.0 milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Reporting Errors, Logs, etc.
Projects
None yet
Development

No branches or pull requests

3 participants