Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drupal/facets:2.0.5 has JS errors #93

Open
DiegoPino opened this issue Nov 11, 2022 · 1 comment
Open

drupal/facets:2.0.5 has JS errors #93

DiegoPino opened this issue Nov 11, 2022 · 1 comment
Assignees
Labels
bug Something isn't working Composer Dancing to the tune of dependencies Drupal 9
Milestone

Comments

@DiegoPino
Copy link
Member

What?

https://git.drupalcode.org/project/facets/-/blob/2.0.x/modules/facets_range_widget/js/slider.js#L6 was fixed to pass $ Jquery shortcut to the function but the last "stable release does not have it" throwing JS errors and not showing any Sliders.

The solution for now would be to use the Dev version of the 2.x branch, composer require 'drupal/facets:2.0.x-dev@dev'

I have not tested this version so most important would be to be sure if our VBO Facets (AMI) work.

@DiegoPino DiegoPino added bug Something isn't working Composer Dancing to the tune of dependencies Drupal 9 labels Nov 11, 2022
@DiegoPino DiegoPino added this to the 1.1.0 milestone Nov 11, 2022
@aksm
Copy link
Contributor

aksm commented Mar 29, 2023

This has been fixed for 2.0.5 stable since this issue was opened:

https://git.drupalcode.org/project/facets/-/blob/2.0.5/modules/facets_range_widget/js/slider.js#L6

@aksm aksm removed their assignment Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Composer Dancing to the tune of dependencies Drupal 9
Projects
None yet
Development

No branches or pull requests

2 participants