Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a weight to custom.css #23

Open
senyzspalding opened this issue Feb 4, 2021 · 5 comments
Open

Adding a weight to custom.css #23

senyzspalding opened this issue Feb 4, 2021 · 5 comments
Labels
CSS Move 1rem to the left, 0.5em up
Milestone

Comments

@senyzspalding
Copy link

Was thinking it might be a good idea to add a weight to the custom.css to help override items that might be defined in the boostrap.css

I just made this small edit to archipelago_subtheme.libraries.yml in my instance

css/custom.css: { weight:2000 }

@DiegoPino
Copy link
Member

@senyzspalding that is a good idea. I guess we can always add !important if we really need to override bootstrap. Any secondary effects after the change?

@DiegoPino DiegoPino added the CSS Move 1rem to the left, 0.5em up label Feb 4, 2021
@DiegoPino DiegoPino modified the milestones: 1.0.0-beta2, 1.0.0 Feb 4, 2021
@senyzspalding
Copy link
Author

So far everything looked fine after I made the change. My main reason to implant the weight was was bootstrap uses the !important flag a lot and with the load order their !important flag was taking priority over my !important flag

@DiegoPino
Copy link
Member

@senyzspalding that sounds good. Would you be willing to make pull request against 1.0.0-RC2? That would be great if possible.

@senyzspalding
Copy link
Author

@DiegoPino I think we will hold off for a week or two while we finish our test run on RC1

@DiegoPino
Copy link
Member

@senyzspalding sounds good. I can also do the commit and test if that helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Move 1rem to the left, 0.5em up
Projects
None yet
Development

No branches or pull requests

2 participants