Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajax Facets fail if the Exposed Form is not the one of the current displayed view #411

Open
DiegoPino opened this issue Feb 1, 2024 · 2 comments
Assignees
Labels
bug Something isn't working Drupal 10 Upgrade economy external bug It is not us, it is them Facets Safely navigating the too many choices
Milestone

Comments

@DiegoPino
Copy link
Member

What?

Super strange. If a page is exposing a different form (e.g a search) than the displayed View/facet combo, after clicking once on a Facet, the second time Ajax fails to refresh/call the facet.

Once the correct Exposed Form is present all works.... this is one that is going to be hard to debug (JS)

@DiegoPino DiegoPino added bug Something isn't working external bug It is not us, it is them Facets Safely navigating the too many choices Drupal 10 Upgrade economy labels Feb 1, 2024
@DiegoPino DiegoPino added this to the 1.4.0 milestone Feb 1, 2024
@DiegoPino DiegoPino self-assigned this Feb 1, 2024
@DiegoPino
Copy link
Member Author

I think this can be addressed here @alliomeria , in this override

Drupal.AjaxFacetsView.UpdateView = function (href, current_dom_id, view_path) {

I'm also seen (when this happens) that the URL passed to JS is not a clean URL means it contains `index.php?path=/search and arguments triggering on the backend a ROUTE does not match notice. I know I could apply a fix for that on NGINX but Drupal should know better. Probably need to filter out any index.php manually too?

@DiegoPino
Copy link
Member Author

This needs work still and I need help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Drupal 10 Upgrade economy external bug It is not us, it is them Facets Safely navigating the too many choices
Projects
None yet
Development

No branches or pull requests

1 participant