Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alternative checksum type #233

Open
alliomeria opened this issue Oct 5, 2022 · 3 comments
Open

Add alternative checksum type #233

alliomeria opened this issue Oct 5, 2022 · 3 comments
Assignees
@DiegoPino
Labels
Configuration enhancement New feature or request

Comments

@alliomeria
Copy link
Contributor

alliomeria commented Oct 5, 2022 •
edited
Loading

What is needed?

Currently checksums are generated via MD5, which will remain the primary type. As a configuration option, add an alternative, supplementary checksum type for SHA256.
@alliomeria alliomeria added enhancement New feature or request Configuration labels Oct 5, 2022
@DiegoPino
Copy link
Member

@alliomeria Makes sense. We should provide both. Wonder if we would need a "Post process existing ones?" in case some chooses to do so?

@DiegoPino
Copy link
Member

(HOPE NOT!). MD5 needs to be the main one, AWS S3 and many other internal parts of our stack use the good enough and fast MD5

@alliomeria
Copy link
Contributor Author

Ah ok @DiegoPino --I updated the issue note above for clarification. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiegoPino DiegoPino

Labels
Configuration enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DiegoPino @alliomeria