Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI Master additional features #2503

Open
1 of 4 tasks
Dominaezzz opened this issue Nov 8, 2024 · 3 comments
Open
1 of 4 tasks

SPI Master additional features #2503

Dominaezzz opened this issue Nov 8, 2024 · 3 comments
Labels
peripheral:spi SPI peripheral

Comments

@Dominaezzz
Copy link
Collaborator

Dominaezzz commented Nov 8, 2024

The SPI Master is currently not exposing some hardware features.
I'm listing them here to begin with rather than create a barrage of issues.

  • Configurable Segmented Transfers (All chips except the base ESP32 support this. It allows to setup multiple transfers at once, rather then send them one by one with the CPU).
  • Expose SPI App interrupts (ESP32-S3/C2/C3/C6/H2 SPI supports these things called "app interrupts" which behave just like SoftwareInterrupts, they are very handy for implementing an interrupt based queue)
  • Expose the extra LCD features that the S2 has for the SPI hardware.
  • Allow using SPI with Dma[Tx|Rx]Buffers that don't have a length. The driver should accept a length in addition to the DMA buffer. (This allows for streaming transfers)

#2494 was created while I was drafting this issue. I think this issue should be separate since that one will be closed once the analysis is done, and this should remain open as a request for the features.

edit: moved a few of these into #2494 to be tackled before 1.0

@Dominaezzz Dominaezzz added the status:needs-attention This should be prioritized label Nov 8, 2024
@github-project-automation github-project-automation bot moved this to Todo in esp-rs Nov 8, 2024
@Dominaezzz Dominaezzz added peripheral:spi SPI peripheral and removed status:needs-attention This should be prioritized labels Nov 8, 2024
@bugadani bugadani added the status:needs-attention This should be prioritized label Nov 8, 2024
@bugadani
Copy link
Contributor

bugadani commented Nov 8, 2024

Please don't remove needs-attention, the team will do that during/after triage.

@Dominaezzz
Copy link
Collaborator Author

Dominaezzz commented Nov 8, 2024

Noted. Sorry about that

@MabezDev MabezDev added 1.0-blocker and removed status:needs-attention This should be prioritized 1.0-blocker labels Nov 22, 2024
@bugadani
Copy link
Contributor

bugadani commented Dec 4, 2024

C2/C3/C6/H2 also have APP interrupts.

S2's LCD features can live in a separate driver, most likely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peripheral:spi SPI peripheral
Projects
Status: Todo
Development

No branches or pull requests

3 participants