-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate C-INTERMEDIATE for all stabilized drivers #2820
Comments
To avoid breaking changes in future: To resolve this I guess for the non-error case we need to carefully look at every function returning For the error case we could consider that every error variant contains a payload, e.g. However, I'm not sure that is worth it |
So I believe this only applies to I2C & SPI, as they are the two drivers with the concept of a transaction. I think to take @bjoernQ's ideas a bit further we should: We should change the return type of spi/i2c transactions to be pub struct TransactionError {
inner: Error,
} Initially we'd only expose the error inside The thing is, embedded-hal only allows us to have on error type for the whole driver, so this will never be available with the eh api. So here we have the option of marking the inherent |
cc #2784
The text was updated successfully, but these errors were encountered: