jarcuri/reorganize #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome @josiearcuri! Let me know if/where I can help on parts of the EKT and/or review. |
|
@shelbyahrendt Before we merge, It can use another pass at editing markdown. Also, it would be helpful to have someone else run the notebook in full. Next I wanted to tackle assignments. I haven't spent much time making our EKT look like other EKTs, but that could be a useful way to figure out assignments to include. I'll check back in a couple weeks when I can put some more time in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have slightly reorganized the notebook - separating it into upland and floodplain as much as possible. I added markdown to most cells and commented/ reorganized the main for loop so it is more readable and appropriate for an EKT. I also fixed some bugs in how discharge and stage height were passed between grids, and added a model output to display how elevation at the outlet node is changing. A few ideas for assignment questions are included at the end of the notebook, but they are just first passes. Not quite finished yet but its getting pretty close!
Resolves #27
Resolves #13
Resolves #11
Resolves #8
Resolves #15
Resolves #18