Allow setting HTTP User Agent in HTTP stream (AUD-4697) #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
stintel
force-pushed
the
feature/http_stream_user_agent
branch
from
d25a287 to
f14b7c5
Compare
stintel
force-pushed
the
feature/http_stream_user_agent
branch
from
f14b7c5 to
76e4a5d
Compare
Add a user_agent field to the http_stream and http_stream_cfg_t structs so people can override the default user agent set by esp_http_client. Also add it to the HTTP_STREAM_CFG_DEFAULT macro with value NULL, to maintain current default behaviour. Signed-off-by: Stijn Tintel <[email protected]>
stintel
force-pushed
the
feature/http_stream_user_agent
branch
from
76e4a5d to
ed05b8b
Compare
|
Is there anything blocking this trivial PR? We're using this in Willow and prefer to not have to deviate from upstream ESP-ADF too much. Thanks. |
|
@stintel No, sorry for replying late. It will be merged. |
|
It's merged on 6d1f295 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a user_agent field to the http_stream and http_stream_cfg_t structs
so people can override the default user agent set by esp_http_client.