Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider setting up dependabot to update submodule dependencies (IEC-2) #29

Open
igrr opened this issue Mar 19, 2022 · 4 comments · May be fixed by #174
Open

Consider setting up dependabot to update submodule dependencies (IEC-2) #29

igrr opened this issue Mar 19, 2022 · 4 comments · May be fixed by #174

Comments

@igrr
Copy link
Member

igrr commented Mar 19, 2022

Dependabot has basic support for tracking and upgrading dependencies expressed using git submodules (https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#package-ecosystem). Consider setting it up for this repository to get notified whenever a dependency can be upgraded.

Note that we might need to wait for or contribute to dependabot/dependabot-core#1639 first, as currently dependabot will try to upgrade to the latest commit, not to the latest tag.

@tore-espressif tore-espressif self-assigned this Mar 25, 2022
@tore-espressif
Copy link
Collaborator

Done.

I don't have any experience with dependabot, so I'll keep this issue open for future evaluation/discussion

@igrr
Copy link
Member Author

igrr commented Mar 25, 2022

Thanks @tore-espressif!

The PRs opened by dependabot have two problems now:

  1. The PR updates the submodule to the latest commit, not to the latest tag (issue Git submodules update to latest tag? dependabot/dependabot-core#1639 noted above).
  2. Looks like the "publish test results" job is failing.

Still even in this form they are useful as a hint/reminder to us that some dependency might be outdated.

Edit: plus we need to remember to bump the version in idf_component.yml when the dependency is upgraded. So looks like we'll be taking over dependabot PRs anyway.

@igrr
Copy link
Member Author

igrr commented Mar 28, 2022

Given the above limitations, I'm thinking of adding a custom CI workflow instead of dependabot... This workflow could also update our idf_component.yml files and make the PRs mergeable.

tore-espressif added a commit that referenced this issue May 9, 2022
This reverts commit 7343788.

Related to #29
@igrr
Copy link
Member Author

igrr commented Feb 20, 2023

This might be worth revisiting, especially since #146 adds two libraries which are known to sometimes have CVEs reported for them. It would be good to be able to get the new releases of these libraries published quickly.

@tom-borcin tom-borcin changed the title Consider setting up dependabot to update submodule dependencies Consider setting up dependabot to update submodule dependencies Apr 21, 2023
@github-actions github-actions bot changed the title Consider setting up dependabot to update submodule dependencies Consider setting up dependabot to update submodule dependencies (IEC-2) Apr 21, 2023
@igrr igrr linked a pull request Apr 30, 2023 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants