Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Make command "Open ESP-IDF Terminal" run user profile and customizations (Powershell specific) (VSC-1551) #1387

Closed
GillesZunino opened this issue Dec 27, 2024 · 3 comments · Fixed by #1388
Assignees
Labels
Feature / Enhancement Request Request for Feature/ Enhancement

Comments

@GillesZunino
Copy link
Contributor

GillesZunino commented Dec 27, 2024

Is your feature request related to a problem?

In v1.9.0, the command "ESP-IDF: Open ESP-IDF Terminal" starts Powershell with argument -NoProfile ignoring user profile customizations. I have a fair amount of useful ESP-IDF Powershell customizations and I miss them in terminals opened via "Open ESP-IDF Terminal" !

COMPARE: Prior v1.9.0, "ESP-IDF: Open ESP-IDF Terminal" did not add -NoProfile to the Powershell command line, allowing Powershell to apply user's customizations.

I realize that the extension itself needs to spawn Powershell behind the scene to implement some of its capabilities. In this case, it is much better to start Powershell with -NoProfile to run commands faster and in a more predictable way.

Describe the solution you'd like

  • Enhance VS Code command "ESP-IDF: Open ESP-IDF Terminal" to start Powershell without -NoProfile. When a user requests a terminal to be created, it is expected the terminal will be interactive and have profile customizations applied.

  • Let all ESP-IDF extension internal invocations of Powershell (aka non interactive command execution) to continue to run with -NoProfile to keep the speed improvement and execution predictability.

@GillesZunino GillesZunino added the Feature / Enhancement Request Request for Feature/ Enhancement label Dec 27, 2024
@github-actions github-actions bot changed the title [Feature Request] Make command "Open ESP-IDF Terminal" run user profile and customizations (Powershell specific) [Feature Request] Make command "Open ESP-IDF Terminal" run user profile and customizations (Powershell specific) (VSC-1551) Dec 27, 2024
@brianignacio5
Copy link
Collaborator

Please try vsix installer to see if the issue is fixed.

You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

@GillesZunino
Copy link
Contributor Author

It tried the VSIX installed above and it worked very well ! Thank you !

Copy link

Thanks for using our extension! 🚀

Your feedback matters! Could you take a moment to rate it on the marketplace? A positive rating helps other developers discover our tools and motivates us to keep improving.

⭐ Rate ESP-IDF Extension: https://marketplace.visualstudio.com/items?itemName=espressif.esp-idf-extension&ssr=false#review-details

Your support means a lot to our development team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature / Enhancement Request Request for Feature/ Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants