Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Sites with monetized iframes don't count as monetized on Chrome #140

Closed
vezwork opened this issue Apr 9, 2021 · 3 comments · Fixed by #142
Closed

[BUG] Sites with monetized iframes don't count as monetized on Chrome #140

vezwork opened this issue Apr 9, 2021 · 3 comments · Fixed by #142
Assignees
@vezwork
Labels
bug Something isn't working priority 1 Highest priority
Milestone
Submit to Firefox...

Comments

@vezwork
Copy link
Member

vezwork commented Apr 9, 2021

Describe the bug
Sites with a monetized iframe (such as https://defold.itch.io/climberz) don't count as monetized on Chrome. This means that the akita icon does not show the monetized state and any time spent on the site does not count as monetized time.

To Reproduce
Steps to reproduce the behavior:

  1. Install Akita in Chrome (either with a provider or without, it's broken on both)
  2. Go to https://defold.itch.io/climberz
  3. Open the game iframe (press "run game")
  4. Observe that the akita extension icon does not show the monetized state.
  5. Open the akita pop-up and observe that time spent on the site does not count as monetized (the site does not show up in top sites)

Expected behavior
The akita extension extension icon monetized state. should show on https://defold.itch.io/climberz after pressing "run game". Time spent on the site should count as monetized.

Desktop (please complete the following information):

  • OS and Version: MacOS
  • Browser and Version: Chrome
@vezwork vezwork added the bug Something isn't working label Apr 9, 2021
@sharon-wang sharon-wang added priority 1 Highest priority regression Something that used to work isn't working anymore labels Apr 9, 2021
@vezwork vezwork mentioned this issue Apr 9, 2021
Closed
@sharon-wang
Copy link
Member

I'm seeing this on Edge without a WM Provider installed.

@vezwork
Copy link
Member Author

vezwork commented Apr 9, 2021

This issue is caused by having multiple Akita extensions installed (one debug extension and one from extension web store). Akita assigns uuids to iframes and does not have handling for when it encounters a message from an iframe including an unknown uuid (i.e. a uuid assigned to the iframe from the other instance of the akita extension).

@vezwork vezwork mentioned this issue Apr 9, 2021
Merged
@sharon-wang
Copy link
Member

@sharon-wang I'm not seeing this on Edge without a WM Provider, could you check again?

Yes, still having this issue. But confirming that this is because I had two versions of Akita installed, failing due to what you've described above.

@vezwork vezwork removed the regression Something that used to work isn't working anymore label Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vezwork vezwork

Labels
bug Something isn't working priority 1 Highest priority
Projects
None yet
Milestone
Submit to Firefox/Chrome/Edge
Development

Successfully merging a pull request may close this issue.

Fix the iframe uuid case where two akitas are installed vezwork/akita
2 participants
@vezwork @sharon-wang