From 37e1aacbbc94c3d5a2e710f1bbec122acf28ab86 Mon Sep 17 00:00:00 2001
From: Alex Bair <alexbair143@gmail.com>
Date: Wed, 15 Jan 2025 09:54:52 -0500
Subject: [PATCH] source-facebook-marketing: remove wish_bid from
 `ads_insights.json`

Multiple production tasks have encountered errors where any async job
requesting the `wish_bid` field have started consistently failing on
Facebook's side. Async jobs that do not request `wish_bid` still succeed.

Removing `wish_bid` from the `ads_insights.json` schema file also
removes it from the list of fields requested from async jobs, and tasks
that were previously failing should now work fine. It's unclear to me
what changed that causes async jobs requesting the `wish_bid` field to
fail, and maybe it can be added back later if there's motivation to
investigate further & determine root cause.
---
 .../schemas/ads_insights.json                 |  3 --
 .../snapshots__discover__capture.stdout.json  | 42 -------------------
 2 files changed, 45 deletions(-)

diff --git a/source-facebook-marketing/source_facebook_marketing/schemas/ads_insights.json b/source-facebook-marketing/source_facebook_marketing/schemas/ads_insights.json
index a82b46f81e..a63914e43e 100644
--- a/source-facebook-marketing/source_facebook_marketing/schemas/ads_insights.json
+++ b/source-facebook-marketing/source_facebook_marketing/schemas/ads_insights.json
@@ -309,9 +309,6 @@
     },
     "website_purchase_roas": {
       "$ref": "ads_action_stats.json"
-    },
-    "wish_bid": {
-      "type": ["null", "number"]
     }
   },
   "type": ["object"],
diff --git a/source-facebook-marketing/tests/snapshots/snapshots__discover__capture.stdout.json b/source-facebook-marketing/tests/snapshots/snapshots__discover__capture.stdout.json
index ccfb697d80..03fec0742c 100644
--- a/source-facebook-marketing/tests/snapshots/snapshots__discover__capture.stdout.json
+++ b/source-facebook-marketing/tests/snapshots/snapshots__discover__capture.stdout.json
@@ -15852,12 +15852,6 @@
             }
           }
         },
-        "wish_bid": {
-          "type": [
-            "null",
-            "number"
-          ]
-        },
         "_meta": {
           "type": "object",
           "properties": {
@@ -19539,12 +19533,6 @@
             }
           }
         },
-        "wish_bid": {
-          "type": [
-            "null",
-            "number"
-          ]
-        },
         "age": {
           "type": [
             "null",
@@ -23242,12 +23230,6 @@
             }
           }
         },
-        "wish_bid": {
-          "type": [
-            "null",
-            "number"
-          ]
-        },
         "country": {
           "type": [
             "null",
@@ -26937,12 +26919,6 @@
             }
           }
         },
-        "wish_bid": {
-          "type": [
-            "null",
-            "number"
-          ]
-        },
         "region": {
           "type": [
             "null",
@@ -30632,12 +30608,6 @@
             }
           }
         },
-        "wish_bid": {
-          "type": [
-            "null",
-            "number"
-          ]
-        },
         "dma": {
           "type": [
             "null",
@@ -34327,12 +34297,6 @@
             }
           }
         },
-        "wish_bid": {
-          "type": [
-            "null",
-            "number"
-          ]
-        },
         "publisher_platform": {
           "type": [
             "null",
@@ -38038,12 +38002,6 @@
             }
           }
         },
-        "wish_bid": {
-          "type": [
-            "null",
-            "number"
-          ]
-        },
         "_meta": {
           "type": "object",
           "properties": {