Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should esy/github-action be upgraded to v2? #10

Open
savi2w opened this issue Jan 29, 2021 · 1 comment
Open

Should esy/github-action be upgraded to v2? #10

savi2w opened this issue Jan 29, 2021 · 1 comment

Comments

@savi2w
Copy link
Contributor

savi2w commented Jan 29, 2021 •
edited
Loading

In #6 we get support for manifest files. However, this change is not present in v1, which is recommended in README.md by default

I see two options to fix the problem

  • Use esy/github-action@master instead of v1 in README.md
  • Deploy another release v2 with the current changes

What do you think?
@EduardoRFS
Copy link
Contributor

I think this can go on v1 if that's possible, there was no breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EduardoRFS @savi2w