From fd033c0918c2bf2168912f7391a55ae6eaf96a85 Mon Sep 17 00:00:00 2001 From: Jonathan Romano Date: Fri, 6 Sep 2024 16:37:53 -0400 Subject: [PATCH] Renaming secrets for clarity --- .github/workflows/ci.yml | 4 ++-- .github/workflows/rotate-apple-keys.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 97e79bb..bf4cbb3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -33,7 +33,7 @@ jobs: uses: actions/create-github-app-token@v1 id: engines-app-token with: - app-id: ${{ secrets.BUILT_ENGINE_CLIENT_ID }} + app-id: ${{ secrets.BUILT_ENGINE_APP_CLIENT_ID }} private-key: ${{ secrets.BUILT_ENGINE_APP_PRIVATE_KEY }} owner: eternagame repositories: eternajs-folding-engines @@ -168,7 +168,7 @@ jobs: brew link --overwrite openssl@3 npm ci - node src/index.js retrieve DEVELOPMENT ${{ secrets.APP_SIGNING_PRIVATE_KEY_BASE64 }} ${{ secrets.APP_STORE_CONNECT_API_KEY_BASE64 }} ${{ secrets.APP_STORE_CONNECT_API_KEY_ID }} ${{ secrets.APP_STORE_CONNECT_API_KEY_ISSUER_ID }} $CERTIFICATE_PATH $P12_PASSWORD + node src/index.js retrieve DEVELOPMENT ${{ secrets.APPLE_APP_SIGNING_PRIVATE_KEY_BASE64 }} ${{ secrets.APP_STORE_CONNECT_API_KEY_BASE64 }} ${{ secrets.APP_STORE_CONNECT_API_KEY_ID }} ${{ secrets.APP_STORE_CONNECT_API_KEY_ISSUER_ID }} $CERTIFICATE_PATH $P12_PASSWORD # create temporary keychain security create-keychain -p "$KEYCHAIN_PASSWORD" $KEYCHAIN_PATH security set-keychain-settings -lut 21600 $KEYCHAIN_PATH diff --git a/.github/workflows/rotate-apple-keys.yml b/.github/workflows/rotate-apple-keys.yml index 79639a8..b4e2fc4 100644 --- a/.github/workflows/rotate-apple-keys.yml +++ b/.github/workflows/rotate-apple-keys.yml @@ -33,5 +33,5 @@ jobs: run: npm ci working-directory: ./.github/workflows/setup-apple-signing - name: Rotate development key - run: node src/index.js rotate DEVELOPMENT ${{ secrets.APP_SIGNING_PRIVATE_KEY_BASE64 }} ${{ secrets.APP_STORE_CONNECT_API_KEY_BASE64 }} ${{ secrets.APP_STORE_CONNECT_API_KEY_ID }} ${{ secrets.APP_STORE_CONNECT_API_KEY_ISSUER_ID }} + run: node src/index.js rotate DEVELOPMENT ${{ secrets.APPLE_APP_SIGNING_PRIVATE_KEY_BASE64 }} ${{ secrets.APP_STORE_CONNECT_API_KEY_BASE64 }} ${{ secrets.APP_STORE_CONNECT_API_KEY_ID }} ${{ secrets.APP_STORE_CONNECT_API_KEY_ISSUER_ID }} working-directory: ./.github/workflows/setup-apple-signing