Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChatMemberXXX redesign #2384

Open
Badiboy opened this issue Aug 17, 2024 · 3 comments
Open

ChatMemberXXX redesign #2384

Badiboy opened this issue Aug 17, 2024 · 3 comments
Labels
in the backlog

Comments

@Badiboy
Copy link
Collaborator

Badiboy commented Aug 17, 2024 •
edited
Loading

@coder2020official

Looks like we need to redesign ChatMemberXXX family. Currently we have all-in-one ChatMember, but it does not correspond to API.

https://core.telegram.org/bots/api#chatmember

I don't remeber why it is done like this now, I suppose we left it for compatibility...
@coder2020official
Copy link
Collaborator

I'll take a look into it.

I don't remember any backward compatibility choices, though. All I remember is that Swiss was the one to implement it :)

@Badiboy
Copy link
Collaborator Author

Badiboy commented Aug 17, 2024

AFAIR some time before there was a single class ChatMember, which was later split into children. Thus we save full ChatMember to leave compatibility.

@coder2020official
Copy link
Collaborator

not really having time rn. Could you do so?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in the backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Badiboy @coder2020official