Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rocblas trmm3 in-place call with out-of-place version #966

Closed
msimberg opened this issue Sep 4, 2023 · 1 comment
Closed

Replace rocblas trmm3 in-place call with out-of-place version #966

msimberg opened this issue Sep 4, 2023 · 1 comment

Comments

@msimberg
Copy link
Collaborator

msimberg commented Sep 4, 2023

rocBLAS 5.0.0 introduced a new rocblas_Xtrmm_outofplace function to replace the two-matrix in-place version that exists. We should replace our use of the in-place one with the three-matrix out-of-place version.

However, rocblas_Xtrmm_outofplace also seems to be deprecated and will be replaced by rocblas_Xtrmm becoming the three-matrix out-of-place version. rocblas_Xtrmm_outofplace has been removed on develop at the time of writing (after 5.5.1). I tested the rocblas_Xtrmm_outofplace function and it works, but given that it's also going to be removed we can either:

  1. Conditionally use rocblas_Xtrmm_outofplace between 5.0.0 and 5.5.X (with the assumption that 5.6.X will actually remove it).
  2. Wait for rocblas_Xtrmm to become the out-of-place version and bump the version requirement to 5.6.X or newer.

The latter requires us to wait quite a while. E.g. LUMI still uses 5.2.3 by default so I think it's too soon to unconditionally require 5.6.X.

rocblas_Xtrmm_outofplace does not seem to solve the apparent performance drop that happened after 5.2.X which makes me lean towards: wait until we can require 5.6.X. But I'm happy to conditionally use rocblas_Xtrmm_outofplace as well if you prefer that. What do you think?

@msimberg
Copy link
Collaborator Author

msimberg commented Dec 8, 2023

Fixed by #978.

@msimberg msimberg closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants