From 621ce9dc729f6926c843cc8d6ba9e4ac8e071807 Mon Sep 17 00:00:00 2001 From: Mikael Simberg Date: Tue, 5 Dec 2023 16:47:28 +0100 Subject: [PATCH 01/62] Add inshpect CI action --- .github/workflows/check_format.yml | 57 ++++- .inshpect.toml | 349 +++++++++++++++++++++++++++++ 2 files changed, 394 insertions(+), 12 deletions(-) create mode 100644 .inshpect.toml diff --git a/.github/workflows/check_format.yml b/.github/workflows/check_format.yml index 364f65ac5c..f61743c81d 100644 --- a/.github/workflows/check_format.yml +++ b/.github/workflows/check_format.yml @@ -11,7 +11,7 @@ name: Check format on: - - pull_request + - push jobs: check: @@ -24,30 +24,56 @@ jobs: - name: Install tools run: | sudo apt-get update - sudo apt-get install --no-install-recommends clang-format-15 python3 + sudo apt-get install --no-install-recommends clang-format-15 fd-find python3 ripgrep pip3 install black==23.03.0 pip3 install cmakelang==0.6.13 + pushd /tmp + curl --output dasel \ + --location https://github.com/TomWright/dasel/releases/download/v1.27.3/dasel_linux_amd64 + sha256sum dasel + echo "1a5adbf8e5b69f48ad5d1665bf7ed056ea3ff8cf3312ce2dc7c3209939873489 dasel" | sha256sum --check + chmod +x dasel + mv dasel /usr/local/bin + popd + + pushd /tmp + curl --output inshpect \ + --location https://raw.githubusercontent.com/msimberg/inshpect/f7b6045cdf832da30be1b0fb88a35827cc443ffa/inshpect + sha256sum inshpect + echo "04b6160cc0b1a45a38db319617697a0bb6a0c1413313d945a4ba73811dd5288a inshpect" | sha256sum --check + chmod +x inshpect + mv inshpect /usr/local/bin + popd + + pushd /tmp + curl --output ripgrep.tar.gz \ + --location https://github.com/BurntSushi/ripgrep/releases/download/13.0.0/ripgrep-13.0.0-x86_64-unknown-linux-musl.tar.gz + echo "ee4e0751ab108b6da4f47c52da187d5177dc371f0f512a7caaec5434e711c091 ripgrep.tar.gz" | sha256sum --check + tar --extract --strip-components 1 --file ripgrep.tar.gz + mv rg /usr/local/bin + popd + - name: Fetch master run: git fetch --no-tags --depth=1 origin +refs/heads/master:refs/heads/master # Fails if there are tabs in source files. - - name: Check formatting - run: ./.github/format.sh + # - name: Check formatting + # run: ./.github/format.sh - - name: Check scripts formatting - if: always() - run: black --line-length 105 scripts/ + # - name: Check scripts formatting + # if: always() + # run: black --line-length 105 scripts/ - # Fails if there are differences. - - name: Formatting issues - if: always() - run: git diff --color --exit-code + # # Fails if there are differences. + # - name: Formatting issues + # if: always() + # run: git diff --color --exit-code - name: Check include guards if: always() run: | - find include test -type f '(' -name "*.h" -o -name "*.h.in" ')' \ + find . -type f '(' -name "*.h" -o -name "*.h.in" ')' \ | xargs -I{} sh -c \ "egrep -sq '^#pragma once' {} || echo {}" \ > pragma-once.check @@ -57,3 +83,10 @@ jobs: done test ! -s pragma-once.check + + - name: Inshpect + if: always() + run: | + export INSHPECT_NUMTHREADS=4 + export INSHPECT_FD=fdfind + inshpect . .inshpect.toml diff --git a/.inshpect.toml b/.inshpect.toml new file mode 100644 index 0000000000..a88bd5a134 --- /dev/null +++ b/.inshpect.toml @@ -0,0 +1,349 @@ +# +# Distributed Linear Algebra with Future (DLAF) +# +# Copyright (c) 2018-2023, ETH Zurich +# All rights reserved. +# +# Please, refer to the LICENSE file in the root directory. +# SPDX-License-Identifier: BSD-3-Clause +# + + +extensions = [ + "c", + "cu", + "h", +] + +[copyright] +enable = false + +[license] +enable = false + +[spdx] +enable = false + +[pragma_once] +enable = true +extensions = [ + "h", + "h.in", +] + +[deprecated_includes] +enable = false +patterns = [ + { pattern = 'boost/move/move\.hpp', replacement = 'utility' }, + { pattern = 'boost/atomic/atomic\.hpp', replacement = 'boost/atomic.hpp' }, + { pattern = 'boost/thread/locks.hpp', replacement = 'mutex or shared_mutex' }, + { pattern = 'boost/type_traits\.hpp', replacement = 'type_traits' }, + { pattern = 'boost/type_traits/([a-z_]+)\.hpp', replacement = 'type_traits' }, + { pattern = 'boost/unordered_map\.hpp', replacement = 'unordered_map' }, + { pattern = 'boost/unordered_set\.hpp', replacement = 'unordered_set' }, + { pattern = 'boost/utility/enable_if\.hpp', replacement = 'type_traits' }, + { pattern = 'boost/detail/atomic_count\.hpp', replacement = 'pika/thread_support/atomic_count.hpp' }, + { pattern = 'boost/function\.hpp', replacement = 'pika/util/function.hpp' }, + { pattern = 'boost/shared_pt\r\.hpp', replacement = 'memory' }, + { pattern = 'boost/intrusive_ptr\.hpp', replacement = 'pika/modules/memory.hpp' }, + { pattern = 'boost/make_shared\.hpp', replacement = 'memory' }, + { pattern = 'boost/enable_shared_from_this\.hpp', replacement = 'memory' }, + { pattern = 'boost/bind\.hpp', replacement = 'pika/util/bind.hpp' }, + { pattern = 'boost/(chrono/)?chrono\.hpp', replacement = 'chrono' }, + { pattern = 'boost/(core/)?ref\.hpp', replacement = 'functional' }, + { pattern = 'boost/cstdint\.hpp', replacement = 'cstdint' }, + { pattern = 'boost/thread/barrier\.hpp', replacement = 'pika/util/barrier.hpp' }, + { pattern = 'boost/exception_ptr\.hpp', replacement = 'exception' }, + { pattern = 'boost/range/iterator_range\.hpp', replacement = 'pika/iterator_support/iterator_range.hpp' }, + { pattern = 'pika/pika_fwd\.hpp', replacement = 'nothing (remove unconditionally)' }, + { pattern = 'boost/preprocessor/cat\.hpp', replacement = 'pika/util/detail/pp/cat.hpp' }, + { pattern = 'boost/preprocessor/stringize\.hpp', replacement = 'pika/util/detail/pp/stringize.hpp' }, + { pattern = 'boost/atomic\.hpp', replacement = 'atomic' }, + { pattern = 'boost/nondet_random.hpp', replacement = 'random' }, + { pattern = 'boost/random/([a-z_]+)\.hpp', replacement = 'random' }, + { pattern = 'boost/format\.hpp', replacement = 'pika/util/format.hpp' }, + { pattern = 'boost/regex.hpp', replacement = 'regex' }, + { pattern = 'boost/program_options([^\s]*)\.hpp', replacement = 'pika/program_options.hpp' }, + { pattern = 'boost/filesystem([^\s]*)\.hpp', replacement = 'filesystem' }, + { pattern = 'boost/lexical_cast\.hpp', replacement = 'pika/string_util/((from_string)|(to_string)).hpp' }, + { pattern = 'boost/system([^\s]*)\.hpp', replacement = 'system_error' }, +] + +[deprecated_names] +enable = false +patterns = [ + { pattern = '\bboost::move\b', replacement = 'std::move' }, + { pattern = '\bboost::forward\b', replacement = 'std::forward' }, + { pattern = '\bboost::noncopyable\b', replacement = 'PIKA_NON_COPYABLE' }, + { pattern = '\bboost::result_of\b', replacement = 'std::result_of' }, + { pattern = '\bboost::decay\b', replacement = 'std::decay' }, + { pattern = '\bboost::enable_if\b', replacement = 'std::enable_if' }, + { pattern = '\bboost::disable_if\b', replacement = 'std::enable_if' }, + { pattern = '\bboost::enable_if_c\b', replacement = 'std::enable_if' }, + { pattern = '\bboost::disable_if_c\b', replacement = 'std::enable_if' }, + { pattern = '\bboost::mpl\b', replacement = 'no specific replacement' }, + { pattern = '\bboost::(is_[a-z_]*?\b)', replacement = 'std::*' }, + { pattern = '\bboost::(add_[^\s]*?\b)', replacement = 'std::*' }, + { pattern = '\bboost::(remove_[a-z_]*?\b)', replacement = 'std::*' }, + { pattern = '\bboost::(((false)|(true))_type\b)', replacement = 'std::*' }, + { pattern = '\bboost::lock_guard\b', replacement = 'std::lock_guard' }, + { pattern = '\bboost::unordered_map\b', replacement = 'std::unordered_map' }, + { pattern = '\bboost::unordered_multimap\b', replacement = 'std::unordered_multimap' }, + { pattern = '\bboost::unordered_set\b', replacement = 'std::unordered_set' }, + { pattern = '\bboost::unordered_multiset\b', replacement = 'std::unordered_multiset' }, + { pattern = '\bboost::detail::atomic_count\b', replacement = 'pika::detail::atomic_count' }, + { pattern = '\bboost::function\b', replacement = 'pika::util::detail::function' }, + { pattern = '\bboost::intrusive_ptr\b', replacement = 'pika::intrusive_ptr' }, + { pattern = '\bboost::shared_ptr\b', replacement = 'std::shared_ptr' }, + { pattern = '\bboost::make_shared\b', replacement = 'std::make_shared' }, + { pattern = '\bboost::enable_shared_from_this\b', replacement = 'std::enable_shared_from_this' }, + { pattern = '\bboost::bind\b', replacement = 'pika::util::detail::bind' }, + { pattern = '\bboost::unique_lock\b', replacement = 'std::unique_lock' }, + { pattern = '\bboost::chrono\b', replacement = 'std::chrono' }, + { pattern = '\bboost::reference_wrapper\b', replacement = 'std::reference_wrapper' }, + { pattern = '\bboost::(c?ref)\b', replacement = 'std::*' }, + { pattern = '\bboost::(u?int[0-9]+_t)\b', replacement = 'std::*' }, + { pattern = '\bboost::exception_ptr\b', replacement = 'std::exception_ptr' }, + { pattern = '\bboost::copy_exception\b', replacement = 'std::make_exception_ptr' }, + { pattern = '\bboost::current_exception\b', replacement = 'std::current_exception' }, + { pattern = '\bboost::rethrow_exception\b', replacement = 'std::rethrow_exception' }, + { pattern = '\bboost::enable_error_info\b', replacement = 'pika::throw_with_info' }, + { pattern = '\bboost::iterator_range\b', replacement = 'pika::util::iterator_range' }, + { pattern = '\bboost::make_iterator_range\b', replacement = 'pika::util::make_iterator_range' }, + { pattern = '\bboost::atomic_flag\b', replacement = 'std::atomic_flag' }, + { pattern = '\bboost::atomic\b', replacement = 'std::atomic' }, + { pattern = '\bboost::memory_order_((relaxed)|(acquire)|(release)|(acq_rel)|(seq_cst))\b', replacement = 'std::memory_order_*' }, + { pattern = '\bboost::random::([a-z_]*)\b', replacement = 'std::*' }, + { pattern = '\bboost::format\b', replacement = 'pika::util::format[_to]' }, + { pattern = '\bboost::(regex[a-z_]*)\b', replacement = 'std::*' }, + { pattern = '\bboost::lexical_cast\b', replacement = 'pika::util::((from_string)|(to_string)' }, + { pattern = '\bboost::system::error_code\b', replacement = 'std::error_code' }, + { pattern = '\bboost::system::error_condition\b', replacement = 'std::error_condition' }, + { pattern = '\bboost::system::error_category\b', replacement = 'std::error_category' }, + { pattern = '\bboost::system::system_error\b', replacement = 'std::system_error' }, + { pattern = '(\bpika::\b)?\btraits::\bis_callable\b', replacement = 'std::is_invocable[_r]' }, + { pattern = '(\bpika::\b)?\butil::\bresult_of\b', replacement = 'std::invoke_result' }, + { pattern = '(\bpika::\b)?\butil::\bdecay\b', replacement = 'std::decay' }, + { pattern = '(\bpika::\b)?\butil::\bdecay_t\b', replacement = 'std::decay_t' }, + { pattern = '(\bpika::\b)?\butil::\bvoid\b', replacement = 'std::void' }, + { pattern = '(\bpika::\b)?\butil::\bvoid_t\b', replacement = 'std::void_t' }, + { pattern = '\bNULL\b', replacement = 'nullptr' }, + { pattern = '\b(BOOST_PP_CAT)\b', replacement = 'PIKA_PP_CAT' }, + { pattern = '\b(BOOST_PP_STRINGIZE)\b', replacement = 'PIKA_PP_STRINGIZE' }, + { pattern = '\b(BOOST_STRINGIZE)\b', replacement = 'PIKA_PP_STRINGIZE(PIKA_PP_EXPAND()' }, + { pattern = '\b(BOOST_ASSERT)\b', replacement = 'PIKA_ASSERT' }, +] + +[disallowed_macros] +enable = false +patterns = [ + "BOOST_NO_0X_HDR_ARRAY", + "BOOST_NO_0X_HDR_CHRONO", + "BOOST_NO_0X_HDR_CODECVT", + "BOOST_NO_0X_HDR_CONDITION_VARIABLE", + "BOOST_NO_0X_HDR_FORWARD_LIST", + "BOOST_NO_0X_HDR_FUTURE", + "BOOST_NO_0X_HDR_INITIALIZER_LIST", + "BOOST_NO_INITIALIZER_LISTS", + "BOOST_NO_0X_HDR_MUTEX", + "BOOST_NO_0X_HDR_RANDOM", + "BOOST_NO_0X_HDR_RATIO", + "BOOST_NO_0X_HDR_REGEX", + "BOOST_NO_0X_HDR_SYSTEM_ERROR", + "BOOST_NO_0X_HDR_THREAD", + "BOOST_NO_0X_HDR_TUPLE", + "BOOST_NO_0X_HDR_TYPE_TRAITS", + "BOOST_NO_0X_HDR_TYPEINDEX", + "BOOST_NO_0X_HDR_UNORDERED_SET", + "BOOST_NO_0X_HDR_UNORDERED_MAP", + "BOOST_NO_STD_UNORDERED", + "BOOST_NO_AUTO_DECLARATIONS", + "BOOST_NO_AUTO_MULTIDECLARATIONS", + "BOOST_NO_CHAR16_T", + "BOOST_NO_CHAR32_T", + "BOOST_NO_TEMPLATE_ALIASES", + "BOOST_NO_CONSTEXPR", + "BOOST_NO_DECLTYPE", + "BOOST_NO_DECLTYPE_N3276", + "BOOST_NO_DEFAULTED_FUNCTIONS", + "BOOST_NO_DELETED_FUNCTIONS", + "BOOST_NO_EXPLICIT_CONVERSION_OPERATORS", + "BOOST_NO_EXTERN_TEMPLATE", + "BOOST_NO_FUNCTION_TEMPLATE_DEFAULT_ARGS", + "BOOST_NO_LAMBDAS", + "BOOST_NO_LOCAL_CLASS_TEMPLATE_PARAMETERS", + "BOOST_NO_NOEXCEPT", + "BOOST_NO_NULLPTR", + "BOOST_NO_RAW_LITERALS", + "BOOST_NO_RVALUE_REFERENCES", + "BOOST_NO_SCOPED_ENUMS", + "BOOST_NO_STATIC_ASSERT", + "BOOST_NO_STD_UNORDERED", + "BOOST_NO_UNICODE_LITERALS", + "BOOST_NO_UNIFIED_INITIALIZATION_SYNTAX", + "BOOST_NO_VARIADIC_TEMPLATES", + "BOOST_NO_VARIADIC_MACROS", + "BOOST_NO_NUMERIC_LIMITS_LOWEST", + "BOOST_HAS_STATIC_ASSERT", + "BOOST_HAS_RVALUE_REFS", + "BOOST_HAS_VARIADIC_TMPL", + "BOOST_HAS_CHAR16_T", + "BOOST_HAS_CHAR32_T", +] + +[includes] +enable = false +patterns = [ + { pattern = '\bstd::make_shared\b', include = 'memory' }, + { pattern = '\bstd::map\b', include = 'map' }, + { pattern = '\bstd::set\b', include = 'set' }, + { pattern = '\bstd::multi_map\b', include = 'multi_map' }, + { pattern = '\bstd::multi_set\b', include = 'multi_set' }, + { pattern = '\bstd::unordered_map\b', include = 'unordered_map' }, + { pattern = '\bstd::unordered_set\b', include = 'unordered_set' }, + { pattern = '\bstd::unordered_multi_map\b', include = 'unordered_map' }, + { pattern = '\bstd::unordered_multi_set\b', include = 'unordered_set' }, + { pattern = '\bstd::((shared|unique)_ptr)\b', include = 'memory' }, + { pattern = '\bstd::addressof\b', include = 'memory' }, + { pattern = '\bstd::list\b', include = 'list' }, + { pattern = '\bstd::string\b', include = 'string' }, + { pattern = '\bstd::vector\b', include = 'vector' }, + { pattern = '\bstd::array\b', include = 'array' }, + { pattern = '\bstd::reference_wrapper\b', include = 'functional' }, + { pattern = '\bstd::(c?ref)\b', include = 'functional' }, + { pattern = '\bstd::(u?int[0-9]+_t)\b', include = 'cstdint' }, + { pattern = '\bstd::((i|o)?stringstream)\b', include = 'sstream' }, + { pattern = '\bstd::((i|o)?fstream)\b', include = 'fstream' }, + { pattern = '\bstd::(cin|cout|cerr|clog)\b', include = 'iostream' }, + { pattern = '\bstd::setw\b', include = 'iomanip' }, + { pattern = '\bstd::setprecision\b', include = 'iomanip' }, + { pattern = '\bstd::size_t\b', include = 'cstddef' }, + { pattern = '\bstd::ptrdiff_t\b', include = 'cstddef' }, + { pattern = '\bstd::nullptr_t\b', include = 'cstddef' }, + { pattern = '\bstd::(true|false)_type\b', include = 'type_traits' }, + { pattern = '\bstd::(bool|integral)_constant\b', include = 'type_traits' }, + { pattern = '\bstd::invoke_result\b', include = 'type_traits' }, + { pattern = '\bstd::invoke_result_t\b', include = 'type_traits' }, + { pattern = '\bstd::is_void\b', include = 'type_traits' }, + { pattern = '\bstd::is_void_t\b', include = 'type_traits' }, + { pattern = '\bstd::is_null_pointer\b', include = 'type_traits' }, + { pattern = '\bstd::is_integral\b', include = 'type_traits' }, + { pattern = '\bstd::is_floating_point\b', include = 'type_traits' }, + { pattern = '\bstd::is_array\b', include = 'type_traits' }, + { pattern = '\bstd::is_enum\b', include = 'type_traits' }, + { pattern = '\bstd::is_union\b', include = 'type_traits' }, + { pattern = '\bstd::is_class\b', include = 'type_traits' }, + { pattern = '\bstd::is_function\b', include = 'type_traits' }, + { pattern = '\bstd::is_pointer\b', include = 'type_traits' }, + { pattern = '\bstd::is_lvalue_reference\b', include = 'type_traits' }, + { pattern = '\bstd::is_rvalue_reference\b', include = 'type_traits' }, + { pattern = '\bstd::is_member_object_pointer\b', include = 'type_traits' }, + { pattern = '\bstd::is_member_function_pointer\b', include = 'type_traits' }, + { pattern = '\bstd::is_fundamental\b', include = 'type_traits' }, + { pattern = '\bstd::is_arithmetic\b', include = 'type_traits' }, + { pattern = '\bstd::is_scalar\b', include = 'type_traits' }, + { pattern = '\bstd::is_object\b', include = 'type_traits' }, + { pattern = '\bstd::is_compound\b', include = 'type_traits' }, + { pattern = '\bstd::is_reference\b', include = 'type_traits' }, + { pattern = '\bstd::is_member_pointer\b', include = 'type_traits' }, + { pattern = '\bstd::is_const\b', include = 'type_traits' }, + { pattern = '\bstd::is_volatile\b', include = 'type_traits' }, + { pattern = '\bstd::is_trivial\b', include = 'type_traits' }, + { pattern = '\bstd::is_trivially_copyable\b', include = 'type_traits' }, + { pattern = '\bstd::is_standard_layout\b', include = 'type_traits' }, + { pattern = '\bstd::is_pod\b', include = 'type_traits' }, + { pattern = '\bstd::is_literal_type\b', include = 'type_traits' }, + { pattern = '\bstd::is_empty\b', include = 'type_traits' }, + { pattern = '\bstd::is_polymorphic\b', include = 'type_traits' }, + { pattern = '\bstd::is_abstract\b', include = 'type_traits' }, + { pattern = '\bstd::is_signed\b', include = 'type_traits' }, + { pattern = '\bstd::is_unsigned\b', include = 'type_traits' }, + { pattern = '\bstd::is_constructible\b', include = 'type_traits' }, + { pattern = '\bstd::is_trivially_constructible\b', include = 'type_traits' }, + { pattern = '\bstd::is_nothrow_constructible\b', include = 'type_traits' }, + { pattern = '\bstd::is_default_constructible\b', include = 'type_traits' }, + { pattern = '\bstd::is_trivially_default_constructible\b', include = 'type_traits' }, + { pattern = '\bstd::is_nothrow_default_constructible\b', include = 'type_traits' }, + { pattern = '\bstd::is_copy_constructible\b', include = 'type_traits' }, + { pattern = '\bstd::is_trivially_copy_constructible\b', include = 'type_traits' }, + { pattern = '\bstd::is_nothrow_copy_constructible\b', include = 'type_traits' }, + { pattern = '\bstd::is_move_constructible\b', include = 'type_traits' }, + { pattern = '\bstd::is_trivially_move_constructible\b', include = 'type_traits' }, + { pattern = '\bstd::is_nothrow_move_constructible\b', include = 'type_traits' }, + { pattern = '\bstd::is_assignable\b', include = 'type_traits' }, + { pattern = '\bstd::is_trivially_assignable\b', include = 'type_traits' }, + { pattern = '\bstd::is_nothrow_assignable\b', include = 'type_traits' }, + { pattern = '\bstd::is_copy_assignable\b', include = 'type_traits' }, + { pattern = '\bstd::is_trivially_copy_assignable\b', include = 'type_traits' }, + { pattern = '\bstd::is_nothrow_copy_assignable\b', include = 'type_traits' }, + { pattern = '\bstd::is_move_assignable\b', include = 'type_traits' }, + { pattern = '\bstd::is_trivially_move_assignable\b', include = 'type_traits' }, + { pattern = '\bstd::is_nothrow_move_assignable\b', include = 'type_traits' }, + { pattern = '\bstd::is_destructible\b', include = 'type_traits' }, + { pattern = '\bstd::is_trivially_destructible\b', include = 'type_traits' }, + { pattern = '\bstd::is_same\b', include = 'type_traits' }, + { pattern = '\bstd::is_base_of\b', include = 'type_traits' }, + { pattern = '\bstd::is_convertible\b', include = 'type_traits' }, + { pattern = '\bstd::has_virtual_destructor\b', include = 'type_traits' }, + { pattern = '\bstd::alignment_of\b', include = 'type_traits' }, + { pattern = '\bstd::aligned_storage\b', include = 'type_traits' }, + { pattern = '\bstd::aligned_union\b', include = 'type_traits' }, + { pattern = '\bstd::rank\b', include = 'type_traits' }, + { pattern = '\bstd::extent\b', include = 'type_traits' }, + { pattern = '\bstd::add_(cv|const|pointer|volatile|lvalue_reference|rvalue_reference)\b', include = 'type_traits' }, + { pattern = '\bstd::make_signed\b', include = 'type_traits' }, + { pattern = '\bstd::make_unsigned\b', include = 'type_traits' }, + { pattern = '\bstd::remove_(cv|const|volatile|reference|pointer|extent|all_extents)\b', include = 'type_traits' }, + { pattern = '\bstd::decay\b', include = 'type_traits' }, + { pattern = '\bstd::enable_if\b', include = 'type_traits' }, + { pattern = '\bstd::conditional\b', include = 'type_traits' }, + { pattern = '\bstd::common_type\b', include = 'type_traits' }, + { pattern = '\bstd::underlying_type\b', include = 'type_traits' }, + { pattern = '\bstd::result_of\b', include = 'type_traits' }, + { pattern = '\bstd::is_invocable([a-z_]*)\b', include = 'type_traits' }, + { pattern = '\bstd::(mem((set)|(cpy)|(move)))\b', include = 'cstring' }, + { pattern = '\bstd::swap\b', include = 'utility' }, + { pattern = '\bstd::move\b', include = 'utility' }, + { pattern = '\bstd::forward\b', include = 'utility' }, + { pattern = '\bstd::declval\b', include = 'utility' }, + { pattern = '\bstd::pair\b', include = 'utility' }, + { pattern = '\bstd::make_pair\b', include = 'utility' }, + { pattern = '\bstd::in_place\b', include = 'utility' }, + { pattern = '\bstd::exception_ptr\b', include = 'exception' }, + { pattern = '\bstd::terminate\b', include = 'exception' }, + { pattern = '\bstd::(s|g)et_terminate\b', include = 'exception' }, + { pattern = '\bstd::swap_ranges\b', include = 'algorithm' }, + { pattern = '\bstd::iter_swap\b', include = 'algorithm' }, + { pattern = '\bstd::atomic\b', include = 'atomic' }, + { pattern = '\bstd::(memory_order_[a-z_]+)\b', include = 'atomic' }, + { pattern = '\bstd::(minstd_rand(0)?)\b', include = 'random' }, + { pattern = '\bstd::(mt19937(_64)?)\b', include = 'random' }, + { pattern = '\bstd::random_device\b', include = 'random' }, + { pattern = '\bstd::uniform_(int|uniform)_distribution\b', include = 'random' }, + { pattern = '\bstd::apply\b', include = 'tuple' }, + { pattern = '\bstd::(forward_as_|make_|)tuple\b', include = 'tuple' }, + { pattern = '\bstd::ignore\b', include = 'tuple' }, + { pattern = '\bstd::tie\b', include = 'tuple' }, + { pattern = '\bstd::tuple_(cat|element|size)\b', include = 'tuple' }, + { pattern = '\bstd::(make_)optional\b', include = 'optional' }, + { pattern = '\bstd::nullopt\b', include = 'optional' }, + { pattern = '\bstd::any(|_cast)\b', include = 'any' }, + { pattern = '\bstd::error_(code|condition|category)\b', include = 'system_error' }, + { pattern = '\bstd::system_error\b', include = 'system_error' }, + { pattern = '\bstd::chrono\b', include = 'chrono' }, + { pattern = '\bpika::intrusive_ptr\b', include = 'pika/memory/intrusive_ptr.hpp' }, + { pattern = '\bpika::detail::from_string\b', include = 'pika/string_util/from_string.hpp' }, + { pattern = '\bpika::detail::to_string\b', include = 'pika/string_util/to_string.hpp' }, + { pattern = '\bPIKA_PP_CAT\b', include = 'pika/preprocessor/cat.hpp' }, + { pattern = '\bPIKA_PP_EXPAND\b', include = 'pika/preprocessor/expand.hpp' }, + { pattern = '\bPIKA_PP_NARGS\b', include = 'pika/preprocessor/nargs.hpp' }, + { pattern = '\bPIKA_PP_STRINGIZE\b', include = 'pika/preprocessor/stringize.hpp' }, + { pattern = '\bPIKA_PP_STRIP_PARENS\b', include = 'pika/preprocessor/strip_parens.hpp' }, + { pattern = '\bPIKA_ASSERT\b', include = 'pika/assert.hpp' }, + { pattern = '\bPIKA_ASSERT_MSG\b', include = 'pika/assert.hpp' }, + { pattern = '\bwhip::([a-z_]+)\b', include = 'whip.hpp' }, + { pattern = '\bfmt::format\b', include = 'fmt/format.h' }, + { pattern = '\bfmt::format_to\b', include = 'fmt/format.h' }, + { pattern = '\bfmt::ptr\b', include = 'fmt/format.h' }, + { pattern = '\bfmt::print\b', include = 'fmt/printf.h' }, +] From dfab9f80d34e3eb2ba679c807e4fdd6048b024ab Mon Sep 17 00:00:00 2001 From: Mikael Simberg Date: Fri, 8 Dec 2023 15:07:49 +0100 Subject: [PATCH 02/62] Simplify inshpect config file --- .inshpect.toml | 219 +++++-------------------------------------------- 1 file changed, 22 insertions(+), 197 deletions(-) diff --git a/.inshpect.toml b/.inshpect.toml index a88bd5a134..40cc472c7a 100644 --- a/.inshpect.toml +++ b/.inshpect.toml @@ -8,188 +8,7 @@ # SPDX-License-Identifier: BSD-3-Clause # - -extensions = [ - "c", - "cu", - "h", -] - -[copyright] -enable = false - -[license] -enable = false - -[spdx] -enable = false - -[pragma_once] -enable = true -extensions = [ - "h", - "h.in", -] - -[deprecated_includes] -enable = false -patterns = [ - { pattern = 'boost/move/move\.hpp', replacement = 'utility' }, - { pattern = 'boost/atomic/atomic\.hpp', replacement = 'boost/atomic.hpp' }, - { pattern = 'boost/thread/locks.hpp', replacement = 'mutex or shared_mutex' }, - { pattern = 'boost/type_traits\.hpp', replacement = 'type_traits' }, - { pattern = 'boost/type_traits/([a-z_]+)\.hpp', replacement = 'type_traits' }, - { pattern = 'boost/unordered_map\.hpp', replacement = 'unordered_map' }, - { pattern = 'boost/unordered_set\.hpp', replacement = 'unordered_set' }, - { pattern = 'boost/utility/enable_if\.hpp', replacement = 'type_traits' }, - { pattern = 'boost/detail/atomic_count\.hpp', replacement = 'pika/thread_support/atomic_count.hpp' }, - { pattern = 'boost/function\.hpp', replacement = 'pika/util/function.hpp' }, - { pattern = 'boost/shared_pt\r\.hpp', replacement = 'memory' }, - { pattern = 'boost/intrusive_ptr\.hpp', replacement = 'pika/modules/memory.hpp' }, - { pattern = 'boost/make_shared\.hpp', replacement = 'memory' }, - { pattern = 'boost/enable_shared_from_this\.hpp', replacement = 'memory' }, - { pattern = 'boost/bind\.hpp', replacement = 'pika/util/bind.hpp' }, - { pattern = 'boost/(chrono/)?chrono\.hpp', replacement = 'chrono' }, - { pattern = 'boost/(core/)?ref\.hpp', replacement = 'functional' }, - { pattern = 'boost/cstdint\.hpp', replacement = 'cstdint' }, - { pattern = 'boost/thread/barrier\.hpp', replacement = 'pika/util/barrier.hpp' }, - { pattern = 'boost/exception_ptr\.hpp', replacement = 'exception' }, - { pattern = 'boost/range/iterator_range\.hpp', replacement = 'pika/iterator_support/iterator_range.hpp' }, - { pattern = 'pika/pika_fwd\.hpp', replacement = 'nothing (remove unconditionally)' }, - { pattern = 'boost/preprocessor/cat\.hpp', replacement = 'pika/util/detail/pp/cat.hpp' }, - { pattern = 'boost/preprocessor/stringize\.hpp', replacement = 'pika/util/detail/pp/stringize.hpp' }, - { pattern = 'boost/atomic\.hpp', replacement = 'atomic' }, - { pattern = 'boost/nondet_random.hpp', replacement = 'random' }, - { pattern = 'boost/random/([a-z_]+)\.hpp', replacement = 'random' }, - { pattern = 'boost/format\.hpp', replacement = 'pika/util/format.hpp' }, - { pattern = 'boost/regex.hpp', replacement = 'regex' }, - { pattern = 'boost/program_options([^\s]*)\.hpp', replacement = 'pika/program_options.hpp' }, - { pattern = 'boost/filesystem([^\s]*)\.hpp', replacement = 'filesystem' }, - { pattern = 'boost/lexical_cast\.hpp', replacement = 'pika/string_util/((from_string)|(to_string)).hpp' }, - { pattern = 'boost/system([^\s]*)\.hpp', replacement = 'system_error' }, -] - -[deprecated_names] -enable = false -patterns = [ - { pattern = '\bboost::move\b', replacement = 'std::move' }, - { pattern = '\bboost::forward\b', replacement = 'std::forward' }, - { pattern = '\bboost::noncopyable\b', replacement = 'PIKA_NON_COPYABLE' }, - { pattern = '\bboost::result_of\b', replacement = 'std::result_of' }, - { pattern = '\bboost::decay\b', replacement = 'std::decay' }, - { pattern = '\bboost::enable_if\b', replacement = 'std::enable_if' }, - { pattern = '\bboost::disable_if\b', replacement = 'std::enable_if' }, - { pattern = '\bboost::enable_if_c\b', replacement = 'std::enable_if' }, - { pattern = '\bboost::disable_if_c\b', replacement = 'std::enable_if' }, - { pattern = '\bboost::mpl\b', replacement = 'no specific replacement' }, - { pattern = '\bboost::(is_[a-z_]*?\b)', replacement = 'std::*' }, - { pattern = '\bboost::(add_[^\s]*?\b)', replacement = 'std::*' }, - { pattern = '\bboost::(remove_[a-z_]*?\b)', replacement = 'std::*' }, - { pattern = '\bboost::(((false)|(true))_type\b)', replacement = 'std::*' }, - { pattern = '\bboost::lock_guard\b', replacement = 'std::lock_guard' }, - { pattern = '\bboost::unordered_map\b', replacement = 'std::unordered_map' }, - { pattern = '\bboost::unordered_multimap\b', replacement = 'std::unordered_multimap' }, - { pattern = '\bboost::unordered_set\b', replacement = 'std::unordered_set' }, - { pattern = '\bboost::unordered_multiset\b', replacement = 'std::unordered_multiset' }, - { pattern = '\bboost::detail::atomic_count\b', replacement = 'pika::detail::atomic_count' }, - { pattern = '\bboost::function\b', replacement = 'pika::util::detail::function' }, - { pattern = '\bboost::intrusive_ptr\b', replacement = 'pika::intrusive_ptr' }, - { pattern = '\bboost::shared_ptr\b', replacement = 'std::shared_ptr' }, - { pattern = '\bboost::make_shared\b', replacement = 'std::make_shared' }, - { pattern = '\bboost::enable_shared_from_this\b', replacement = 'std::enable_shared_from_this' }, - { pattern = '\bboost::bind\b', replacement = 'pika::util::detail::bind' }, - { pattern = '\bboost::unique_lock\b', replacement = 'std::unique_lock' }, - { pattern = '\bboost::chrono\b', replacement = 'std::chrono' }, - { pattern = '\bboost::reference_wrapper\b', replacement = 'std::reference_wrapper' }, - { pattern = '\bboost::(c?ref)\b', replacement = 'std::*' }, - { pattern = '\bboost::(u?int[0-9]+_t)\b', replacement = 'std::*' }, - { pattern = '\bboost::exception_ptr\b', replacement = 'std::exception_ptr' }, - { pattern = '\bboost::copy_exception\b', replacement = 'std::make_exception_ptr' }, - { pattern = '\bboost::current_exception\b', replacement = 'std::current_exception' }, - { pattern = '\bboost::rethrow_exception\b', replacement = 'std::rethrow_exception' }, - { pattern = '\bboost::enable_error_info\b', replacement = 'pika::throw_with_info' }, - { pattern = '\bboost::iterator_range\b', replacement = 'pika::util::iterator_range' }, - { pattern = '\bboost::make_iterator_range\b', replacement = 'pika::util::make_iterator_range' }, - { pattern = '\bboost::atomic_flag\b', replacement = 'std::atomic_flag' }, - { pattern = '\bboost::atomic\b', replacement = 'std::atomic' }, - { pattern = '\bboost::memory_order_((relaxed)|(acquire)|(release)|(acq_rel)|(seq_cst))\b', replacement = 'std::memory_order_*' }, - { pattern = '\bboost::random::([a-z_]*)\b', replacement = 'std::*' }, - { pattern = '\bboost::format\b', replacement = 'pika::util::format[_to]' }, - { pattern = '\bboost::(regex[a-z_]*)\b', replacement = 'std::*' }, - { pattern = '\bboost::lexical_cast\b', replacement = 'pika::util::((from_string)|(to_string)' }, - { pattern = '\bboost::system::error_code\b', replacement = 'std::error_code' }, - { pattern = '\bboost::system::error_condition\b', replacement = 'std::error_condition' }, - { pattern = '\bboost::system::error_category\b', replacement = 'std::error_category' }, - { pattern = '\bboost::system::system_error\b', replacement = 'std::system_error' }, - { pattern = '(\bpika::\b)?\btraits::\bis_callable\b', replacement = 'std::is_invocable[_r]' }, - { pattern = '(\bpika::\b)?\butil::\bresult_of\b', replacement = 'std::invoke_result' }, - { pattern = '(\bpika::\b)?\butil::\bdecay\b', replacement = 'std::decay' }, - { pattern = '(\bpika::\b)?\butil::\bdecay_t\b', replacement = 'std::decay_t' }, - { pattern = '(\bpika::\b)?\butil::\bvoid\b', replacement = 'std::void' }, - { pattern = '(\bpika::\b)?\butil::\bvoid_t\b', replacement = 'std::void_t' }, - { pattern = '\bNULL\b', replacement = 'nullptr' }, - { pattern = '\b(BOOST_PP_CAT)\b', replacement = 'PIKA_PP_CAT' }, - { pattern = '\b(BOOST_PP_STRINGIZE)\b', replacement = 'PIKA_PP_STRINGIZE' }, - { pattern = '\b(BOOST_STRINGIZE)\b', replacement = 'PIKA_PP_STRINGIZE(PIKA_PP_EXPAND()' }, - { pattern = '\b(BOOST_ASSERT)\b', replacement = 'PIKA_ASSERT' }, -] - -[disallowed_macros] -enable = false -patterns = [ - "BOOST_NO_0X_HDR_ARRAY", - "BOOST_NO_0X_HDR_CHRONO", - "BOOST_NO_0X_HDR_CODECVT", - "BOOST_NO_0X_HDR_CONDITION_VARIABLE", - "BOOST_NO_0X_HDR_FORWARD_LIST", - "BOOST_NO_0X_HDR_FUTURE", - "BOOST_NO_0X_HDR_INITIALIZER_LIST", - "BOOST_NO_INITIALIZER_LISTS", - "BOOST_NO_0X_HDR_MUTEX", - "BOOST_NO_0X_HDR_RANDOM", - "BOOST_NO_0X_HDR_RATIO", - "BOOST_NO_0X_HDR_REGEX", - "BOOST_NO_0X_HDR_SYSTEM_ERROR", - "BOOST_NO_0X_HDR_THREAD", - "BOOST_NO_0X_HDR_TUPLE", - "BOOST_NO_0X_HDR_TYPE_TRAITS", - "BOOST_NO_0X_HDR_TYPEINDEX", - "BOOST_NO_0X_HDR_UNORDERED_SET", - "BOOST_NO_0X_HDR_UNORDERED_MAP", - "BOOST_NO_STD_UNORDERED", - "BOOST_NO_AUTO_DECLARATIONS", - "BOOST_NO_AUTO_MULTIDECLARATIONS", - "BOOST_NO_CHAR16_T", - "BOOST_NO_CHAR32_T", - "BOOST_NO_TEMPLATE_ALIASES", - "BOOST_NO_CONSTEXPR", - "BOOST_NO_DECLTYPE", - "BOOST_NO_DECLTYPE_N3276", - "BOOST_NO_DEFAULTED_FUNCTIONS", - "BOOST_NO_DELETED_FUNCTIONS", - "BOOST_NO_EXPLICIT_CONVERSION_OPERATORS", - "BOOST_NO_EXTERN_TEMPLATE", - "BOOST_NO_FUNCTION_TEMPLATE_DEFAULT_ARGS", - "BOOST_NO_LAMBDAS", - "BOOST_NO_LOCAL_CLASS_TEMPLATE_PARAMETERS", - "BOOST_NO_NOEXCEPT", - "BOOST_NO_NULLPTR", - "BOOST_NO_RAW_LITERALS", - "BOOST_NO_RVALUE_REFERENCES", - "BOOST_NO_SCOPED_ENUMS", - "BOOST_NO_STATIC_ASSERT", - "BOOST_NO_STD_UNORDERED", - "BOOST_NO_UNICODE_LITERALS", - "BOOST_NO_UNIFIED_INITIALIZATION_SYNTAX", - "BOOST_NO_VARIADIC_TEMPLATES", - "BOOST_NO_VARIADIC_MACROS", - "BOOST_NO_NUMERIC_LIMITS_LOWEST", - "BOOST_HAS_STATIC_ASSERT", - "BOOST_HAS_RVALUE_REFS", - "BOOST_HAS_VARIADIC_TMPL", - "BOOST_HAS_CHAR16_T", - "BOOST_HAS_CHAR32_T", -] +extensions = ["c", "cu", "h"] [includes] enable = false @@ -331,19 +150,25 @@ patterns = [ { pattern = '\bstd::error_(code|condition|category)\b', include = 'system_error' }, { pattern = '\bstd::system_error\b', include = 'system_error' }, { pattern = '\bstd::chrono\b', include = 'chrono' }, - { pattern = '\bpika::intrusive_ptr\b', include = 'pika/memory/intrusive_ptr.hpp' }, - { pattern = '\bpika::detail::from_string\b', include = 'pika/string_util/from_string.hpp' }, - { pattern = '\bpika::detail::to_string\b', include = 'pika/string_util/to_string.hpp' }, - { pattern = '\bPIKA_PP_CAT\b', include = 'pika/preprocessor/cat.hpp' }, - { pattern = '\bPIKA_PP_EXPAND\b', include = 'pika/preprocessor/expand.hpp' }, - { pattern = '\bPIKA_PP_NARGS\b', include = 'pika/preprocessor/nargs.hpp' }, - { pattern = '\bPIKA_PP_STRINGIZE\b', include = 'pika/preprocessor/stringize.hpp' }, - { pattern = '\bPIKA_PP_STRIP_PARENS\b', include = 'pika/preprocessor/strip_parens.hpp' }, - { pattern = '\bPIKA_ASSERT\b', include = 'pika/assert.hpp' }, - { pattern = '\bPIKA_ASSERT_MSG\b', include = 'pika/assert.hpp' }, - { pattern = '\bwhip::([a-z_]+)\b', include = 'whip.hpp' }, - { pattern = '\bfmt::format\b', include = 'fmt/format.h' }, - { pattern = '\bfmt::format_to\b', include = 'fmt/format.h' }, - { pattern = '\bfmt::ptr\b', include = 'fmt/format.h' }, - { pattern = '\bfmt::print\b', include = 'fmt/printf.h' }, ] + +[copyright] +enable = false + +[license] +enable = false + +[spdx] +enable = false + +[pragma_once] +enable = false + +[deprecated_includes] +enable = false + +[deprecated_names] +enable = false + +[disallowed_macros] +enable = false From 7e7144e2d144129f025007515c740fed61d9b092 Mon Sep 17 00:00:00 2001 From: Mikael Simberg Date: Fri, 8 Dec 2023 15:09:25 +0100 Subject: [PATCH 03/62] Enable inshpect includes check --- .inshpect.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.inshpect.toml b/.inshpect.toml index 40cc472c7a..2e341a680c 100644 --- a/.inshpect.toml +++ b/.inshpect.toml @@ -11,7 +11,7 @@ extensions = ["c", "cu", "h"] [includes] -enable = false +enable = true patterns = [ { pattern = '\bstd::make_shared\b', include = 'memory' }, { pattern = '\bstd::map\b', include = 'map' }, From 83ea3974a990dce1608f9b226a0bb5d949c1001d Mon Sep 17 00:00:00 2001 From: Mikael Simberg Date: Fri, 8 Dec 2023 15:18:19 +0100 Subject: [PATCH 04/62] Add more file extensions to inshpect config --- .inshpect.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.inshpect.toml b/.inshpect.toml index 2e341a680c..c04b57bfa0 100644 --- a/.inshpect.toml +++ b/.inshpect.toml @@ -8,7 +8,7 @@ # SPDX-License-Identifier: BSD-3-Clause # -extensions = ["c", "cu", "h"] +extensions = ["c", "cpp", "cu", "h", "h.in"] [includes] enable = true From 9b3f002fde6cd0949f722a64aac584d019b45ecb Mon Sep 17 00:00:00 2001 From: Mikael Simberg Date: Fri, 8 Dec 2023 15:22:00 +0100 Subject: [PATCH 05/62] Fix missing and includes --- include/dlaf/eigensolver/band_to_tridiag/mc.h | 2 ++ include/dlaf/matrix/panel.h | 2 ++ include/dlaf/matrix/tile.h | 1 + test/include/dlaf_test/matrix/util_tile.h | 1 + test/unit/communication/test_communicator_grid.cpp | 2 ++ test/unit/init/test_init.cpp | 1 + test/unit/memory/test_memory_chunk.cpp | 2 ++ test/unit/memory/test_memory_view.cpp | 2 ++ 8 files changed, 13 insertions(+) diff --git a/include/dlaf/eigensolver/band_to_tridiag/mc.h b/include/dlaf/eigensolver/band_to_tridiag/mc.h index a2c55d940a..1dbe211d9f 100644 --- a/include/dlaf/eigensolver/band_to_tridiag/mc.h +++ b/include/dlaf/eigensolver/band_to_tridiag/mc.h @@ -10,6 +10,8 @@ #pragma once +#include + #include #include diff --git a/include/dlaf/matrix/panel.h b/include/dlaf/matrix/panel.h index 6db6608bf4..1564fccb8a 100644 --- a/include/dlaf/matrix/panel.h +++ b/include/dlaf/matrix/panel.h @@ -11,6 +11,8 @@ /// @file +#include + #include #include diff --git a/include/dlaf/matrix/tile.h b/include/dlaf/matrix/tile.h index 589d4cbb50..99a66368b4 100644 --- a/include/dlaf/matrix/tile.h +++ b/include/dlaf/matrix/tile.h @@ -13,6 +13,7 @@ /// @file #include +#include #include #include #include diff --git a/test/include/dlaf_test/matrix/util_tile.h b/test/include/dlaf_test/matrix/util_tile.h index 39d4e7b805..5a28c558db 100644 --- a/test/include/dlaf_test/matrix/util_tile.h +++ b/test/include/dlaf_test/matrix/util_tile.h @@ -15,6 +15,7 @@ #include #include #include +#include #include #include diff --git a/test/unit/communication/test_communicator_grid.cpp b/test/unit/communication/test_communicator_grid.cpp index dd16c4b806..b051169f64 100644 --- a/test/unit/communication/test_communicator_grid.cpp +++ b/test/unit/communication/test_communicator_grid.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include diff --git a/test/unit/init/test_init.cpp b/test/unit/init/test_init.cpp index c17b9c16de..3a9c073aa9 100644 --- a/test/unit/init/test_init.cpp +++ b/test/unit/init/test_init.cpp @@ -9,6 +9,7 @@ // #include +#include #include diff --git a/test/unit/memory/test_memory_chunk.cpp b/test/unit/memory/test_memory_chunk.cpp index aef85c73cc..53eb7ec2ea 100644 --- a/test/unit/memory/test_memory_chunk.cpp +++ b/test/unit/memory/test_memory_chunk.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include diff --git a/test/unit/memory/test_memory_view.cpp b/test/unit/memory/test_memory_view.cpp index de0d8b5338..a6d1207def 100644 --- a/test/unit/memory/test_memory_view.cpp +++ b/test/unit/memory/test_memory_view.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include From a26be9cac7976ae32324d37e5caa72b5e79121f6 Mon Sep 17 00:00:00 2001 From: Mikael Simberg Date: Fri, 8 Dec 2023 15:22:52 +0100 Subject: [PATCH 06/62] Fix missing includes --- src/c_api/grid.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/c_api/grid.cpp b/src/c_api/grid.cpp index e286e79127..618348d7cb 100644 --- a/src/c_api/grid.cpp +++ b/src/c_api/grid.cpp @@ -9,6 +9,7 @@ // #include +#include #include From 986080c9ceb99d0fbda9381c2f955215914d3705 Mon Sep 17 00:00:00 2001 From: Mikael Simberg Date: Fri, 8 Dec 2023 15:28:30 +0100 Subject: [PATCH 07/62] Add missing includes --- include/dlaf/common/assert.h | 1 + include/dlaf/init.h | 1 + include/dlaf/matrix/print_csv.h | 2 ++ miniapp/kernel/miniapp_laset.cpp | 1 + miniapp/miniapp_band_to_tridiag.cpp | 1 + miniapp/miniapp_cholesky.cpp | 1 + miniapp/miniapp_gen_eigensolver.cpp | 1 + miniapp/miniapp_gen_to_std.cpp | 1 + miniapp/miniapp_reduction_to_band.cpp | 1 + miniapp/miniapp_triangular_solver.cpp | 1 + src/init.cpp | 2 ++ test/include/dlaf_test/matrix/util_matrix_local.h | 1 + test/src/gtest_mpi_listener.cpp | 1 + test/src/gtest_mpi_listener.h | 1 + test/unit/communication/test_collective_async.cpp | 2 ++ test/unit/init/test_init.cpp | 1 + test/unit/matrix/test_matrix_local.cpp | 1 + test/unit/matrix/test_matrix_output.cpp | 1 + test/unit/matrix/test_panel.cpp | 1 + test/unit/matrix/test_tile.cpp | 2 ++ test/unit/matrix/test_views.cpp | 1 + 21 files changed, 25 insertions(+) diff --git a/include/dlaf/common/assert.h b/include/dlaf/common/assert.h index a07e011010..c731a8d4d7 100644 --- a/include/dlaf/common/assert.h +++ b/include/dlaf/common/assert.h @@ -14,6 +14,7 @@ #include #include #include +#include #include diff --git a/include/dlaf/init.h b/include/dlaf/init.h index 7ca7a6605e..e2384b8439 100644 --- a/include/dlaf/init.h +++ b/include/dlaf/init.h @@ -12,6 +12,7 @@ /// @file #include +#include #include #include diff --git a/include/dlaf/matrix/print_csv.h b/include/dlaf/matrix/print_csv.h index 284ed69d93..e27c236dce 100644 --- a/include/dlaf/matrix/print_csv.h +++ b/include/dlaf/matrix/print_csv.h @@ -11,6 +11,8 @@ /// @file +#include + #include #include #include diff --git a/miniapp/kernel/miniapp_laset.cpp b/miniapp/kernel/miniapp_laset.cpp index e24d967ed8..8d246f3f81 100644 --- a/miniapp/kernel/miniapp_laset.cpp +++ b/miniapp/kernel/miniapp_laset.cpp @@ -9,6 +9,7 @@ // #include +#include #ifdef DLAF_WITH_GPU #include diff --git a/miniapp/miniapp_band_to_tridiag.cpp b/miniapp/miniapp_band_to_tridiag.cpp index f3d81c047a..bace372c48 100644 --- a/miniapp/miniapp_band_to_tridiag.cpp +++ b/miniapp/miniapp_band_to_tridiag.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include #include diff --git a/miniapp/miniapp_cholesky.cpp b/miniapp/miniapp_cholesky.cpp index b082334c8b..2d3d921460 100644 --- a/miniapp/miniapp_cholesky.cpp +++ b/miniapp/miniapp_cholesky.cpp @@ -10,6 +10,7 @@ #include #include +#include #include #include diff --git a/miniapp/miniapp_gen_eigensolver.cpp b/miniapp/miniapp_gen_eigensolver.cpp index 3c63dc766d..40659b7c49 100644 --- a/miniapp/miniapp_gen_eigensolver.cpp +++ b/miniapp/miniapp_gen_eigensolver.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include #include diff --git a/miniapp/miniapp_gen_to_std.cpp b/miniapp/miniapp_gen_to_std.cpp index ae93c667b3..8fa3a8c70d 100644 --- a/miniapp/miniapp_gen_to_std.cpp +++ b/miniapp/miniapp_gen_to_std.cpp @@ -10,6 +10,7 @@ #include #include +#include #include #include diff --git a/miniapp/miniapp_reduction_to_band.cpp b/miniapp/miniapp_reduction_to_band.cpp index 6856a73396..299af230b0 100644 --- a/miniapp/miniapp_reduction_to_band.cpp +++ b/miniapp/miniapp_reduction_to_band.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include #include diff --git a/miniapp/miniapp_triangular_solver.cpp b/miniapp/miniapp_triangular_solver.cpp index 8c0b35fa48..f2b98b8f4b 100644 --- a/miniapp/miniapp_triangular_solver.cpp +++ b/miniapp/miniapp_triangular_solver.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include #include diff --git a/src/init.cpp b/src/init.cpp index 3fdba264b5..0696c8cf1d 100644 --- a/src/init.cpp +++ b/src/init.cpp @@ -16,6 +16,7 @@ #include #include #include +#include #include @@ -188,6 +189,7 @@ void updateConfiguration(const pika::program_options::variables_map& vm, configu updateConfigurationValue(vm, cfg.umpire_device_memory_pool_initial_bytes, "UMPIRE_DEVICE_MEMORY_POOL_INITIAL_BYTES", "umpire-device-memory-pool-initial-bytes"); + // TODO: Warn if disabled cfg.mpi_pool = (pika::resource::pool_exists("mpi")) ? "mpi" : "default"; // Warn if not using MPI pool without --dlaf:no-mpi-pool diff --git a/test/include/dlaf_test/matrix/util_matrix_local.h b/test/include/dlaf_test/matrix/util_matrix_local.h index aa9b37cb1b..c450943315 100644 --- a/test/include/dlaf_test/matrix/util_matrix_local.h +++ b/test/include/dlaf_test/matrix/util_matrix_local.h @@ -13,6 +13,7 @@ /// @file #include +#include #include #include diff --git a/test/src/gtest_mpi_listener.cpp b/test/src/gtest_mpi_listener.cpp index c97fe93432..86a32d6fa3 100644 --- a/test/src/gtest_mpi_listener.cpp +++ b/test/src/gtest_mpi_listener.cpp @@ -10,6 +10,7 @@ #include #include +#include #include "gtest_mpi_listener.h" diff --git a/test/src/gtest_mpi_listener.h b/test/src/gtest_mpi_listener.h index 53ca3b07f6..7916f2bc8d 100644 --- a/test/src/gtest_mpi_listener.h +++ b/test/src/gtest_mpi_listener.h @@ -11,6 +11,7 @@ #pragma once #include +#include #include #include diff --git a/test/unit/communication/test_collective_async.cpp b/test/unit/communication/test_collective_async.cpp index 707b094694..8e8e1577d9 100644 --- a/test/unit/communication/test_collective_async.cpp +++ b/test/unit/communication/test_collective_async.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include diff --git a/test/unit/init/test_init.cpp b/test/unit/init/test_init.cpp index 3a9c073aa9..29a068e5e6 100644 --- a/test/unit/init/test_init.cpp +++ b/test/unit/init/test_init.cpp @@ -10,6 +10,7 @@ #include #include +#include #include diff --git a/test/unit/matrix/test_matrix_local.cpp b/test/unit/matrix/test_matrix_local.cpp index 32f6b6a1ec..4ba7ebd7ea 100644 --- a/test/unit/matrix/test_matrix_local.cpp +++ b/test/unit/matrix/test_matrix_local.cpp @@ -9,6 +9,7 @@ // #include +#include #include #include diff --git a/test/unit/matrix/test_matrix_output.cpp b/test/unit/matrix/test_matrix_output.cpp index c37ec80992..07ef9ce4bd 100644 --- a/test/unit/matrix/test_matrix_output.cpp +++ b/test/unit/matrix/test_matrix_output.cpp @@ -9,6 +9,7 @@ // #include +#include #include #include diff --git a/test/unit/matrix/test_panel.cpp b/test/unit/matrix/test_panel.cpp index 6057f8817c..8e3c4fa927 100644 --- a/test/unit/matrix/test_panel.cpp +++ b/test/unit/matrix/test_panel.cpp @@ -9,6 +9,7 @@ // #include +#include #include #include diff --git a/test/unit/matrix/test_tile.cpp b/test/unit/matrix/test_tile.cpp index 62f31179da..efc5881aad 100644 --- a/test/unit/matrix/test_tile.cpp +++ b/test/unit/matrix/test_tile.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include diff --git a/test/unit/matrix/test_views.cpp b/test/unit/matrix/test_views.cpp index 4116908c9e..e723d054b8 100644 --- a/test/unit/matrix/test_views.cpp +++ b/test/unit/matrix/test_views.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include From 8ad52bebeeb59858d93fc75ed84069aceaff6a04 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Tue, 16 Apr 2024 14:37:07 +0200 Subject: [PATCH 08/62] add mc.h file with the new include --- include/dlaf/auxiliary/norm/mc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/dlaf/auxiliary/norm/mc.h b/include/dlaf/auxiliary/norm/mc.h index cf887f0d2c..69130e98c1 100644 --- a/include/dlaf/auxiliary/norm/mc.h +++ b/include/dlaf/auxiliary/norm/mc.h @@ -9,6 +9,8 @@ // #pragma once +#include + #include #include #include From fe17144c245b50b6b8f4f0aa03ff6f18c4f5e253 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Thu, 18 Apr 2024 11:27:21 +0200 Subject: [PATCH 09/62] add 80 #include --- include/dlaf/blas/tile.h | 1 + include/dlaf/common/assert.h | 1 + .../communication/communicator_pipeline.h | 2 + include/dlaf/communication/sync/broadcast.h | 2 + include/dlaf/eigensolver/band_to_tridiag/mc.h | 1 + .../eigensolver/bt_band_to_tridiag/impl.h | 1 + .../eigensolver/bt_reduction_to_band/impl.h | 2 + include/dlaf/eigensolver/eigensolver.h | 2 + include/dlaf/eigensolver/gen_eigensolver.h | 2 + .../dlaf/eigensolver/reduction_to_band/impl.h | 1 + .../tridiag_solver/index_manipulation.h | 1 + .../tridiag_solver/kernels_async.h | 2 + .../dlaf/eigensolver/tridiag_solver/merge.h | 1 + include/dlaf/eigensolver/tridiag_solver/rot.h | 2 + include/dlaf/factorization/qr.h | 2 + include/dlaf/factorization/qr/t_factor_impl.h | 2 + include/dlaf/lapack/tile.h | 1 + include/dlaf/matrix/copy_tile.h | 1 + include/dlaf/matrix/create_matrix.h | 2 + include/dlaf/matrix/hdf5.h | 1 + include/dlaf/matrix/internal/tile_pipeline.h | 2 + include/dlaf/matrix/matrix.h | 1 + include/dlaf/matrix/matrix_base.h | 1 + include/dlaf/matrix/matrix_ref.h | 2 + include/dlaf/matrix/panel.h | 2 + include/dlaf/permutations/general/impl.h | 1 + include/dlaf/sender/transform.h | 2 + include/dlaf/sender/transform_mpi.h | 1 + include/dlaf/sender/with_temporary_tile.h | 2 + include/dlaf/util_matrix.h | 1 + inshpect.output | 237 ++++++++++++++++++ miniapp/include/dlaf/miniapp/work_tiles.h | 1 + miniapp/miniapp_cholesky.cpp | 1 + miniapp/miniapp_communication.cpp | 1 + 34 files changed, 285 insertions(+) create mode 100644 inshpect.output diff --git a/include/dlaf/blas/tile.h b/include/dlaf/blas/tile.h index c9098f788e..d534f93d5d 100644 --- a/include/dlaf/blas/tile.h +++ b/include/dlaf/blas/tile.h @@ -13,6 +13,7 @@ /// Provides `Tile` wrappers for BLAS operations. #include +#include #include diff --git a/include/dlaf/common/assert.h b/include/dlaf/common/assert.h index c731a8d4d7..5244f73303 100644 --- a/include/dlaf/common/assert.h +++ b/include/dlaf/common/assert.h @@ -15,6 +15,7 @@ #include #include #include +#include #include diff --git a/include/dlaf/communication/communicator_pipeline.h b/include/dlaf/communication/communicator_pipeline.h index 11e527797c..80d8c66de4 100644 --- a/include/dlaf/communication/communicator_pipeline.h +++ b/include/dlaf/communication/communicator_pipeline.h @@ -12,6 +12,8 @@ #pragma once +#include + #include #include #include diff --git a/include/dlaf/communication/sync/broadcast.h b/include/dlaf/communication/sync/broadcast.h index dbcb3b4268..eb352d75e7 100644 --- a/include/dlaf/communication/sync/broadcast.h +++ b/include/dlaf/communication/sync/broadcast.h @@ -12,6 +12,8 @@ /// @file +#include + #include #include #include diff --git a/include/dlaf/eigensolver/band_to_tridiag/mc.h b/include/dlaf/eigensolver/band_to_tridiag/mc.h index 1dbe211d9f..d314c88b37 100644 --- a/include/dlaf/eigensolver/band_to_tridiag/mc.h +++ b/include/dlaf/eigensolver/band_to_tridiag/mc.h @@ -11,6 +11,7 @@ #pragma once #include +#include #include #include diff --git a/include/dlaf/eigensolver/bt_band_to_tridiag/impl.h b/include/dlaf/eigensolver/bt_band_to_tridiag/impl.h index 081e0fa0b5..8966a53792 100644 --- a/include/dlaf/eigensolver/bt_band_to_tridiag/impl.h +++ b/include/dlaf/eigensolver/bt_band_to_tridiag/impl.h @@ -12,6 +12,7 @@ #include #include +#include #include #include diff --git a/include/dlaf/eigensolver/bt_reduction_to_band/impl.h b/include/dlaf/eigensolver/bt_reduction_to_band/impl.h index 4bc42cb69a..d56ea330b2 100644 --- a/include/dlaf/eigensolver/bt_reduction_to_band/impl.h +++ b/include/dlaf/eigensolver/bt_reduction_to_band/impl.h @@ -9,6 +9,8 @@ // #pragma once +#include + #include #include diff --git a/include/dlaf/eigensolver/eigensolver.h b/include/dlaf/eigensolver/eigensolver.h index bddf4ddc6e..1167f86193 100644 --- a/include/dlaf/eigensolver/eigensolver.h +++ b/include/dlaf/eigensolver/eigensolver.h @@ -11,6 +11,8 @@ /// @file +#include + #include #include diff --git a/include/dlaf/eigensolver/gen_eigensolver.h b/include/dlaf/eigensolver/gen_eigensolver.h index 41842bc2ec..495018f7c3 100644 --- a/include/dlaf/eigensolver/gen_eigensolver.h +++ b/include/dlaf/eigensolver/gen_eigensolver.h @@ -11,6 +11,8 @@ /// @file +#include + #include #include diff --git a/include/dlaf/eigensolver/reduction_to_band/impl.h b/include/dlaf/eigensolver/reduction_to_band/impl.h index c61151102f..c9c1448b4c 100644 --- a/include/dlaf/eigensolver/reduction_to_band/impl.h +++ b/include/dlaf/eigensolver/reduction_to_band/impl.h @@ -11,6 +11,7 @@ #include #include +#include #include #include diff --git a/include/dlaf/eigensolver/tridiag_solver/index_manipulation.h b/include/dlaf/eigensolver/tridiag_solver/index_manipulation.h index 7e6dc5912b..9c9e848865 100644 --- a/include/dlaf/eigensolver/tridiag_solver/index_manipulation.h +++ b/include/dlaf/eigensolver/tridiag_solver/index_manipulation.h @@ -10,6 +10,7 @@ #pragma once #include +#include #include diff --git a/include/dlaf/eigensolver/tridiag_solver/kernels_async.h b/include/dlaf/eigensolver/tridiag_solver/kernels_async.h index 72bb3207eb..b6bbd2cf21 100644 --- a/include/dlaf/eigensolver/tridiag_solver/kernels_async.h +++ b/include/dlaf/eigensolver/tridiag_solver/kernels_async.h @@ -10,6 +10,8 @@ #pragma once +#include + #include #include #include diff --git a/include/dlaf/eigensolver/tridiag_solver/merge.h b/include/dlaf/eigensolver/tridiag_solver/merge.h index 53ba9aac27..d07fc56787 100644 --- a/include/dlaf/eigensolver/tridiag_solver/merge.h +++ b/include/dlaf/eigensolver/tridiag_solver/merge.h @@ -14,6 +14,7 @@ #include #include #include +#include #include #include diff --git a/include/dlaf/eigensolver/tridiag_solver/rot.h b/include/dlaf/eigensolver/tridiag_solver/rot.h index e2b8eb1b56..52ddf1c17b 100644 --- a/include/dlaf/eigensolver/tridiag_solver/rot.h +++ b/include/dlaf/eigensolver/tridiag_solver/rot.h @@ -13,6 +13,8 @@ #include #endif +#include + #include #include #include diff --git a/include/dlaf/factorization/qr.h b/include/dlaf/factorization/qr.h index ff0dae09e2..7337412e0e 100644 --- a/include/dlaf/factorization/qr.h +++ b/include/dlaf/factorization/qr.h @@ -9,6 +9,8 @@ // #pragma once +#include + /// @file #include diff --git a/include/dlaf/factorization/qr/t_factor_impl.h b/include/dlaf/factorization/qr/t_factor_impl.h index 4523ee7a28..87ed14e845 100644 --- a/include/dlaf/factorization/qr/t_factor_impl.h +++ b/include/dlaf/factorization/qr/t_factor_impl.h @@ -10,6 +10,8 @@ #pragma once +#include + #include #include diff --git a/include/dlaf/lapack/tile.h b/include/dlaf/lapack/tile.h index c90364c371..8f36976731 100644 --- a/include/dlaf/lapack/tile.h +++ b/include/dlaf/lapack/tile.h @@ -13,6 +13,7 @@ /// @file #include +#include #include // LAPACKPP includes complex.h which defines the macro I. diff --git a/include/dlaf/matrix/copy_tile.h b/include/dlaf/matrix/copy_tile.h index 0fb2645c23..695c2963a4 100644 --- a/include/dlaf/matrix/copy_tile.h +++ b/include/dlaf/matrix/copy_tile.h @@ -13,6 +13,7 @@ /// @file #include +#include #if DLAF_WITH_GPU #include diff --git a/include/dlaf/matrix/create_matrix.h b/include/dlaf/matrix/create_matrix.h index 18c8d43fc8..4d071cfcd2 100644 --- a/include/dlaf/matrix/create_matrix.h +++ b/include/dlaf/matrix/create_matrix.h @@ -9,6 +9,8 @@ // #pragma once +#include + #include #include #include diff --git a/include/dlaf/matrix/hdf5.h b/include/dlaf/matrix/hdf5.h index 50e8b2d334..4e5b883f10 100644 --- a/include/dlaf/matrix/hdf5.h +++ b/include/dlaf/matrix/hdf5.h @@ -15,6 +15,7 @@ #include #include #include +#include #include #include diff --git a/include/dlaf/matrix/internal/tile_pipeline.h b/include/dlaf/matrix/internal/tile_pipeline.h index ee27bfe6fd..b7e1db41c1 100644 --- a/include/dlaf/matrix/internal/tile_pipeline.h +++ b/include/dlaf/matrix/internal/tile_pipeline.h @@ -10,6 +10,8 @@ #pragma once +#include + #include #include diff --git a/include/dlaf/matrix/matrix.h b/include/dlaf/matrix/matrix.h index 58194daaff..a6d16b5f82 100644 --- a/include/dlaf/matrix/matrix.h +++ b/include/dlaf/matrix/matrix.h @@ -13,6 +13,7 @@ /// @file #include +#include #include #include diff --git a/include/dlaf/matrix/matrix_base.h b/include/dlaf/matrix/matrix_base.h index 7a1a225631..c2f3e42bbd 100644 --- a/include/dlaf/matrix/matrix_base.h +++ b/include/dlaf/matrix/matrix_base.h @@ -14,6 +14,7 @@ #include #include +#include #include diff --git a/include/dlaf/matrix/matrix_ref.h b/include/dlaf/matrix/matrix_ref.h index 685acf9b81..b77275c271 100644 --- a/include/dlaf/matrix/matrix_ref.h +++ b/include/dlaf/matrix/matrix_ref.h @@ -12,6 +12,8 @@ /// @file +#include + #include #include #include diff --git a/include/dlaf/matrix/panel.h b/include/dlaf/matrix/panel.h index 1564fccb8a..15e8449633 100644 --- a/include/dlaf/matrix/panel.h +++ b/include/dlaf/matrix/panel.h @@ -1,3 +1,4 @@ + // // Distributed Linear Algebra with Future (DLAF) // @@ -12,6 +13,7 @@ /// @file #include +#include #include diff --git a/include/dlaf/permutations/general/impl.h b/include/dlaf/permutations/general/impl.h index 6876ed46ed..45b0de297d 100644 --- a/include/dlaf/permutations/general/impl.h +++ b/include/dlaf/permutations/general/impl.h @@ -11,6 +11,7 @@ #pragma once #include +#include #include diff --git a/include/dlaf/sender/transform.h b/include/dlaf/sender/transform.h index 202a526216..78b66eb001 100644 --- a/include/dlaf/sender/transform.h +++ b/include/dlaf/sender/transform.h @@ -9,6 +9,8 @@ // #pragma once +#include + #include #include diff --git a/include/dlaf/sender/transform_mpi.h b/include/dlaf/sender/transform_mpi.h index 9f1f4b93fd..97bb6bb380 100644 --- a/include/dlaf/sender/transform_mpi.h +++ b/include/dlaf/sender/transform_mpi.h @@ -10,6 +10,7 @@ #pragma once #include +#include #include diff --git a/include/dlaf/sender/with_temporary_tile.h b/include/dlaf/sender/with_temporary_tile.h index 3263206487..80d2bc81f1 100644 --- a/include/dlaf/sender/with_temporary_tile.h +++ b/include/dlaf/sender/with_temporary_tile.h @@ -10,6 +10,8 @@ #pragma once +#include + #include #include diff --git a/include/dlaf/util_matrix.h b/include/dlaf/util_matrix.h index 130bce86b9..40b67967f0 100644 --- a/include/dlaf/util_matrix.h +++ b/include/dlaf/util_matrix.h @@ -13,6 +13,7 @@ #include #include #include +#include #ifndef M_PI constexpr double M_PI = 3.141592; diff --git a/inshpect.output b/inshpect.output new file mode 100644 index 0000000000..d2a5dc315f --- /dev/null +++ b/inshpect.output @@ -0,0 +1,237 @@ +# Includes + +Include for \bstd::move\b: +./include/dlaf/matrix/tile.h:41: : size_(size), memory_view_(std::move(memory_view)), ld_(ld) { +./src/c_api/factorization/cholesky.h:43: dlaf::matrix::Matrix matrix_host(std::move(distribution), layout, a); +./src/matrix/distribution.cpp:94: : Distribution(std::move(rhs)) { +./test/include/dlaf_test/matrix/util_matrix_local.h:97: return MatrixLocal(std::move(dest)); +./test/include/dlaf_test/matrix/util_matrix_senders.h:150: std::move(previous[index]).get(); +./test/include/dlaf_test/matrix/util_tile.h:63: pika::this_thread::experimental::sync_wait(std::move(sender)); +./test/src/gtest_mpi_listener.cpp:27: : listener_(std::move(other)) { +./test/unit/auxiliary/mc/test_norm.cpp:57: Matrix matrix(std::move(distribution)); +./test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp:173: return EigensolverResult{std::move(eigenvalues), std::move(eigenvectors)}; +./test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp:190: return EigensolverResult{std::move(eigenvalues), std::move(eigenvectors)}; +./test/unit/c_api/factorization/test_cholesky_c_api.cpp:74: Matrix mat_h(std::move(distribution)); +./test/unit/common/test_pipeline.cpp:115: tt::sync_wait(ex::when_all(std::move(checkpoint0), std::move(checkpoint1), std::move(checkpoint2))); +./test/unit/communication/test_all_reduce.cpp:117: sync::allReduce(communicator, op, std::move(message_input), std::move(message_output)); +./test/unit/communication/test_collective_async.cpp:131: auto tile = tt::sync_wait(std::move(after)); +./test/unit/communication/test_comm_sender.cpp:44: sync_wait(when_all(std::move(send), std::move(recv)) | then([](int e1, int e2) { +./test/unit/communication/test_message.cpp:115: auto new_message = std::move(message); +./test/unit/communication/test_reduce.cpp:162: sync::reduce(root, communicator, op, std::move(message_input), std::move(message_output)); +./test/unit/communication/test_transform_mpi.cpp:87: return std::move(pg); +./test/unit/eigensolver/test_band_to_tridiag.cpp:145: Matrix mat_a_h(std::move(distr)); +./test/unit/eigensolver/test_bt_reduction_to_band.cpp:211: Matrix mat_c_h(std::move(dist_c)); +./test/unit/eigensolver/test_eigensolver.cpp:123: return EigensolverResult{std::move(eigenvalues), std::move(eigenvectors)}; +./test/unit/eigensolver/test_gen_eigensolver.cpp:120: return EigensolverResult{std::move(eigenvalues), std::move(eigenvectors)}; +./test/unit/eigensolver/test_gen_to_std.cpp:91: Matrix mat_ah(std::move(distr_a)); +./test/unit/eigensolver/test_tridiag_solver_distributed.cpp:98: matrix::util::set(tridiag, std::move(tridiag_fn)); +./test/unit/eigensolver/test_tridiag_solver_local.cpp:77: matrix::util::set(tridiag, std::move(tridiag_fn)); +./test/unit/eigensolver/test_tridiag_solver_merge.cpp:145: const SizeType k = tt::sync_wait(std::move(k_sender)); +./test/unit/factorization/test_cholesky.cpp:86: Matrix mat_h(std::move(distribution)); +./test/unit/factorization/test_compute_t_factor.cpp:162: return std::make_tuple(std::move(mat_taus), std::move(h_expected)); +./test/unit/matrix/test_copy.cpp:88: Matrix mat_src_const = std::move(mat_src); +./test/unit/matrix/test_distribution.cpp:351: Distribution obj_move(std::move(obj)); +./test/unit/matrix/test_matrix.cpp:208: Matrix mat(std::move(distribution)); +./test/unit/matrix/test_matrix_hdf5.cpp:76: return std::make_tuple(std::move(matrix), std::move(original_values)); +./test/unit/matrix/test_matrix_local.cpp:130: return std::make_pair(std::move(mat), output); +./test/unit/matrix/test_matrix_mirror.cpp:247: Matrix mat(std::move(mat_nonconst)); +./test/unit/matrix/test_matrix_output.cpp:63: return std::make_tuple(std::move(mat), output, output_csv); +./test/unit/matrix/test_retiled_matrix.cpp:256: std::move(rwsender0).get(); +./test/unit/matrix/test_tile.cpp:98: Tile tile(size, std::move(mem_view), ld); +./test/unit/matrix/test_util_matrix.cpp:71: Matrix matrix(std::move(distribution), layout, mem()); +./test/unit/memory/test_memory_chunk.cpp:60: memory::MemoryChunk mem2(std::move(mem)); +./test/unit/memory/test_memory_view.cpp:215: memory::MemoryView mem2(std::move(mem)); +./test/unit/multiplication/test_multiplication_general.cpp:183: Matrix matrix(std::move(dist)); +./test/unit/multiplication/test_multiplication_hermitian.cpp:115: Matrix mat_ah(std::move(distr_a)); +./test/unit/multiplication/test_multiplication_triangular.cpp:119: Matrix mat_ah(std::move(distr_a)); +./test/unit/permutations/test_permutations_distributed.cpp:77: return {m, mb, i_begin_tile, i_end_tile, std::move(perms)}; +./test/unit/sender/test_with_temporary_tile.cpp:119: return internal::whenAllLift(std::move(check_tile_sender), blas::Uplo::General, output_value, +./test/unit/solver/test_triangular.cpp:116: Matrix mat_ah(std::move(distr_a)); +./test/unit/test_lapack_tile.cpp:302: auto tridiag = createTile(std::move(tridiag_f), TileElementSize(sz, 2), sz); +Include for \bstd::array\b: +./include/dlaf/eigensolver/reduction_to_band/impl.h:73:std::array computeX0AndSquares(const bool has_head, const std::vector>& panel, +./test/unit/communication/test_communicator_grid.cpp:28:std::array computeGridDims(int nranks) { +./test/unit/eigensolver/test_tridiag_solver_merge.cpp:121: constexpr std::array in_arr{1, 4, 2, 3, 0, 5, 6, 7, 8, 9}; +Include for \bstd::declval\b: +./include/dlaf/eigensolver/tridiag_solver/impl.h:75: ex::ensure_started(cuppensDecompAsync(tridiag.readwrite(std::declval()), +Include for \bstd::nullopt\b: +./include/dlaf/common/pipeline.h:49: : pipeline(std::exchange(other.pipeline, std::nullopt)), +./include/dlaf/util_matrix.h:342: std::optional band_size = std::nullopt) { +Include for \bstd::is_floating_point\b: +./include/dlaf/types.h:145:struct IsFloatingPointOrComplex : std::is_floating_point {}; +Include for \bstd::pair\b: +./include/dlaf/communication/broadcast_panel.h:38:std::pair transposedOwner(const matrix::Distribution& dist, +./test/include/dlaf_c_test/c_api_helpers.h:65:std::pair top_left_tile(dlaf::matrix::Matrix& mat) { +Include for \bstd::terminate\b: +./include/dlaf/memory/memory_chunk.h:72: std::terminate(); +./src/c_api/utils.cpp:62: std::terminate(); +Include for \bstd::size_t\b: +./include/dlaf/common/data_descriptor.h:142:template +./include/dlaf/common/round_robin.h:27: RoundRobin(std::size_t n, Args... args) { +./include/dlaf/communication/communicator_grid.h:41: std::size_t npipelines = getTuneParameters().communicator_grid_num_pipelines); +./include/dlaf/eigensolver/band_to_tridiag/mc.h:1155: constexpr std::size_t n_workspaces = 4; +./include/dlaf/eigensolver/bt_band_to_tridiag/impl.h:509: HHManager(const SizeType b, const std::size_t, matrix::Distribution, matrix::Distribution) : b(b) {} +./include/dlaf/eigensolver/bt_reduction_to_band/impl.h:155: constexpr std::size_t n_workspaces = 2; +./include/dlaf/eigensolver/gen_to_std/impl.h:292: constexpr std::size_t n_workspaces = 2; +./include/dlaf/eigensolver/internal/get_red2band_panel_nworkers.h:23: const std::size_t available_workers = pika::resource::get_thread_pool("default").get_os_thread_count(); +./include/dlaf/eigensolver/internal/get_tridiag_rank1_nworkers.h:21:inline std::size_t getTridiagRank1NWorkers() noexcept { +./include/dlaf/eigensolver/tridiag_solver/merge.h:269:inline std::size_t ev_sort_order(const ColType coltype) { +./include/dlaf/eigensolver/tridiag_solver/rot.h:290: const std::size_t linear_tile_col = to_sizet(dist_sub.localTileLinearIndex(tile_col)); +./include/dlaf/factorization/cholesky/impl.h:195: constexpr std::size_t n_workspaces = 2; +./include/dlaf/init.h:37: std::size_t num_np_gpu_streams_per_thread = 3; +./include/dlaf/matrix/copy_tile.h:83: const std::size_t m = to_sizet(source.size().rows()); +./include/dlaf/matrix/hdf5.h:42: static constexpr std::size_t dims = 1; +./include/dlaf/matrix/matrix.h:386: for (std::size_t i = 0; i < n; ++i) { +./include/dlaf/memory/memory_chunk.h:27:void initializeUmpireHostAllocator(std::size_t initial_bytes); +./include/dlaf/multiplication/general/impl.h:89: constexpr std::size_t n_workspaces = 2; +./include/dlaf/multiplication/hermitian/impl.h:112: constexpr std::size_t n_workspaces = 2; +./include/dlaf/multiplication/triangular/impl.h:414: constexpr std::size_t n_workspaces = 2; +./include/dlaf/permutations/general/impl.h:104: for (std::size_t i_split = 0; i_split < splits.size() - 1; ++i_split) { +./include/dlaf/solver/triangular/impl.h:492: constexpr std::size_t n_workspaces = 2; +./include/dlaf/tune.h:81: red2band_panel_nworkers = std::max(1, default_pool_thread_count / 2); +./include/dlaf/util_matrix.h:155: getter_random(SizeType seed) : random_engine_(static_cast(seed)) { +./miniapp/include/dlaf/miniapp/options.h:163: for (std::size_t i = 0; i < valid_values.size(); ++i) { +./src/communication/communicator_grid.cpp:19: common::Ordering ordering, std::size_t npipelines) { +./src/init.cpp:69:void initializeGpuPool(int device, std::size_t num_np_streams, std::size_t num_hp_streams) { +./src/memory/memory_chunk.cpp:37:void initializeUmpireHostAllocator(std::size_t initial_bytes) { +./test/include/dlaf_test/comm_grids/grids_6_ranks.h:80: const std::size_t ncommunicator_pipelines = 3; +./test/include/dlaf_test/matrix/matrix_local.h:123: std::size_t tileLinearIndex(const GlobalTileIndex& index) const noexcept { +./test/include/dlaf_test/matrix/util_matrix_local.h:53: const auto linear_size = static_cast(source.size().rows() * source.size().cols()); +./test/include/dlaf_test/matrix/util_matrix_senders.h:38: result.reserve(static_cast(dist.localNrTiles().linear_size())); +./test/src/gtest_mpi_listener.cpp:87: return last_test_part_results_[static_cast(index)]; +./test/unit/common/test_data_descriptor.cpp:46: return {std::make_unique(static_cast(blocksize)), num_blocks, blocksize, stride}; +./test/unit/communication/test_comm_sender.cpp:36: std::vector send_buf(static_cast(size), rank); +./test/unit/communication/test_communicator_grid.cpp:214: const std::vector test_npipelines{1, 3, 10}; +./test/unit/init/test_init.cpp:92: const std::size_t default_val = default_cfg.num_hp_gpu_streams_per_thread; +./test/unit/matrix/test_tile.cpp:388: const std::vector& specs, std::size_t last_dep, +./test/unit/permutations/test_permutations_distributed.cpp:74: const std::size_t nperms = to_sizet(i_end - i_begin); +Include for \bstd::swap\b: +./include/dlaf/common/index2d.h:107: std::swap(row_, col_); +./include/dlaf/util_math.h:47: std::swap(small, big); +./miniapp/kernel/miniapp_laset.cpp:57: std::swap(m, n); +./test/unit/test_lapack_tile.cpp:120: std::swap(m, n); +Include for \bstd::(c?ref)\b: +./include/dlaf/communication/kernels/internal/all_reduce.h:72: return whenAllLift(std::move(pcomm), reduce_op, std::cref(tile_in_comm), +./include/dlaf/communication/kernels/internal/broadcast.h:58: return whenAllLift(std::move(pcomm), std::cref(tile_comm)) | transformMPI(sendBcast_o); +./include/dlaf/communication/kernels/internal/p2p.h:62: return whenAllLift(std::move(pcomm), dest, tag, std::cref(tile_comm)) | transformMPI(send_o); +./include/dlaf/communication/kernels/internal/reduce.h:80: return whenAllLift(std::move(pcomm), reduce_op, std::cref(tile_comm)) | +./include/dlaf/sender/with_temporary_tile.h:126: return ex::just(std::cref(in)) | +./test/unit/sender/test_with_temporary_tile.cpp:112: ex::just(std::cref(temp)) | +Include for \bstd::(forward_as_|make_|)tuple\b: +./include/dlaf/eigensolver/tridiag_solver/impl.h:46: std::vector>& indices) { +./include/dlaf/permutations/general/impl.h:159: return std::tuple(std::move(splits), std::move(index_tile_futs), std::move(mat_in_tiles), +./src/c_api/utils.cpp:31:std::tuple distribution_and_layout( +./src/c_api/utils.h:15:std::tuple distribution_and_layout( +./test/unit/eigensolver/test_tridiag_solver_distributed.cpp:48:const std::vector> tested_problems = { +./test/unit/eigensolver/test_tridiag_solver_local.cpp:40: std::vector> expected_indices{{0, 1, 2}, {0, 2, 3}, +./test/unit/lapack/gpu/test_lacpy.cpp:32:std::vector> configs{ +./test/unit/matrix/test_distribution.cpp:191:std::tuple test_tile_size(const ParametersConstructor& test) { +./test/unit/matrix/test_layout_info.cpp:20:const std::vector> +./test/unit/matrix/test_matrix.cpp:742: return std::tuple(std::move(rosenders2a), std::move(rosenders2b), std::move(senders3)); +./test/unit/matrix/test_matrix_hdf5.cpp:76: return std::make_tuple(std::move(matrix), std::move(original_values)); +./test/unit/matrix/test_retiled_matrix.cpp:48:const std::vector> local_sizes_tests({ +./test/unit/matrix/test_tile.cpp:44:using TileSizes = std::tuple; +./test/unit/multiplication/test_multiplication_general.cpp:290:const std::vector> sizes = { +./test/unit/permutations/test_permutations_distributed.cpp:48:using testcase_t = std::tuple>; +./test/unit/permutations/test_permutations_local.cpp:88:const std::vector> sizes = { +./test/unit/test_blas_tile.cpp:47:std::vector> gemm_sizes = { +./test/unit/test_blas_tile_extensions.cpp:37:std::vector> scal_sizes = { +./test/unit/test_lapack_tile.cpp:54:std::vector> hegst_sizes = { +Include for \bstd::make_pair\b: +./include/dlaf/communication/broadcast_panel.h:42: return std::make_pair(idx_cross, rank_owner); +./include/dlaf/eigensolver/tridiag_solver/tile_collector.h:44: return std::make_pair(begin, size); +./test/include/dlaf_c_test/c_api_helpers.h:81: return std::make_pair(local_ptr, lld); +./test/unit/matrix/test_matrix_local.cpp:130: return std::make_pair(std::move(mat), output); +Include for \bstd::(cin|cout|cerr|clog)\b: +./include/dlaf/matrix/print_csv.h:33:void print(format::csv, const Tile& tile, std::ostream& os = std::cout) { +./include/dlaf/matrix/print_numpy.h:68:void print(format::numpy, const Tile& tile, std::ostream& os = std::cout) { +./include/dlaf/memory/memory_chunk.h:70: std::cout +./miniapp/kernel/miniapp_laset.cpp:107: std::cout << "[" << run_index << "]" +./src/c_api/grid.cpp:63: std::cerr << "Grid layout must be row major or column major." << std::endl; +./test/include/dlaf_test/matrix/util_matrix_local.h:139: std::ostream& os = std::cout) { +./test/unit/common/test_data_descriptor.cpp:79: std::cout << "Unknown memory type" << std::endl; +Include for \bstd::atomic\b: +./test/include/dlaf_test/matrix/util_tile.h:48: : ready(std::make_shared>(false)), +Include for \bstd::forward\b: +./include/dlaf/common/callable_object.h:29: auto operator()(Ts&&... ts) const noexcept(noexcept((fname) (std::forward(ts)...))) \ +./include/dlaf/communication/sync/basic.h:30: auto message = make_message(common::make_data(std::forward(data))); +./include/dlaf/eigensolver/gen_to_std/impl.h:39: dlaf::internal::whenAllLift(1, blas::Uplo::Lower, std::forward(a_kk), +./include/dlaf/factorization/cholesky/impl.h:41: dlaf::internal::whenAllLift(blas::Uplo::Lower, std::forward(matrix_tile)) | +./include/dlaf/multiplication/hermitian/impl.h:39: std::forward(a_tile), std::forward(b_tile), beta, +./include/dlaf/multiplication/triangular/impl.h:40: std::forward(in_tile), std::forward(out_tile)) | +./include/dlaf/solver/triangular/impl.h:43: std::forward(in_tile), std::forward(out_tile)) | +./miniapp/include/dlaf/miniapp/kernel_runner.h:87: return runInternal(std::forward(kernel_task), streams_); +./test/include/dlaf_test/blas/invoke.h:34: f(std::forward(args)...); +./test/include/dlaf_test/lapack/invoke.h:34: f(std::forward(args)...); +./test/include/dlaf_test/matrix/util_tile.h:49: sender(std::forward(sender) | +./test/unit/communication/test_comm_p2p.cpp:60: std::forward(tile)) | +./test/unit/init/test_init.cpp:47: init_ = std::make_unique(std::forward(args)...); +Include for \bstd::vector\b: +./include/dlaf/auxiliary/norm/mc.h:80: auto max_element = [](std::vector&& values) { +./include/dlaf/eigensolver/band_to_tridiag/mc.h:696: using TileVector = std::vector>; +./include/dlaf/eigensolver/bt_band_to_tridiag/impl.h:108: std::vector taus; +./include/dlaf/eigensolver/tridiag_solver/impl.h:46: std::vector>& indices) { +./include/dlaf/eigensolver/tridiag_solver/merge.h:224: std::vector> tiles_max; +./include/dlaf/eigensolver/tridiag_solver/rot.h:266: mb](std::vector> rots, std::vector> tiles, +./include/dlaf/matrix/tile.h:539:std::vector> splitTile(ReadOnlyTileSender tile, +./include/dlaf/permutations/general/impl.h:98: const SizeType i_perm, const std::vector& splits, const GlobalElementIndex out_begin, +./miniapp/include/dlaf/miniapp/options.h:154: const std::vector& valid_values) { +./src/permutations/general/perms.cu:40: const std::vector>& tiles) { +./test/include/dlaf_test/comm_grids/grids_6_ranks.h:21:std::vector comm_grids; +./test/include/dlaf_test/matrix/matrix_local.h:134: std::vector> tiles_; +./test/src/gtest_mpi_listener.cpp:183: std::vector message_buffer(static_cast(message_length)); +./test/unit/auxiliary/mc/test_norm.cpp:43:const std::vector lapack_norms({lapack::Norm::Fro, lapack::Norm::Inf, lapack::Norm::Max, +./test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp:57:const std::vector blas_uplos({blas::Uplo::Lower}); +./test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp:55:const std::vector blas_uplos({blas::Uplo::Lower}); +./test/unit/c_api/factorization/test_cholesky_c_api.cpp:51:const std::vector blas_uplos({blas::Uplo::Lower, blas::Uplo::Upper}); +./test/unit/common/test_data_descriptor.cpp:701: std::vector> memory_types; +./test/unit/communication/test_broadcast_panel.cpp:50:std::vector test_params{ +./test/unit/communication/test_communicator_grid.cpp:214: const std::vector test_npipelines{1, 3, 10}; +./test/unit/eigensolver/test_band_to_tridiag.cpp:49:const std::vector> sizes = { +./test/unit/eigensolver/test_bt_band_to_tridiag.cpp:253:std::vector configs{ +./test/unit/eigensolver/test_eigensolver.cpp:60:const std::vector blas_uplos({blas::Uplo::Lower}); +./test/unit/eigensolver/test_gen_eigensolver.cpp:60:const std::vector blas_uplos({blas::Uplo::Lower}); +./test/unit/eigensolver/test_gen_to_std.cpp:50:const std::vector blas_uplos({blas::Uplo::Lower, blas::Uplo::Upper}); +./test/unit/eigensolver/test_reduction_to_band.cpp:82:std::vector configs{ +./test/unit/eigensolver/test_tridiag_solver_distributed.cpp:48:const std::vector> tested_problems = { +./test/unit/eigensolver/test_tridiag_solver_local.cpp:40: std::vector> expected_indices{{0, 1, 2}, {0, 2, 3}, +./test/unit/eigensolver/test_tridiag_solver_merge.cpp:69: std::vector vec_arr{7, 2, 4, 8, 12, 1, 17, 32, 9, 6}; +./test/unit/eigensolver/test_tridiag_solver_rot.cpp:50: std::vector rots; +./test/unit/factorization/test_cholesky.cpp:50:const std::vector blas_uplos({blas::Uplo::Lower, blas::Uplo::Upper}); +./test/unit/factorization/test_compute_t_factor.cpp:206:std::vector> configs{ +./test/unit/lapack/gpu/test_lacpy.cpp:32:std::vector> configs{ +./test/unit/matrix/test_distribution.cpp:37:const std::vector tests_constructor = { +./test/unit/matrix/test_distribution_extensions.cpp:42:const std::vector tests_indices = { +./test/unit/matrix/test_layout_info.cpp:20:const std::vector> +./test/unit/matrix/test_tile.cpp:35:const std::vector sizes({0, 1, 13, 32}); +./test/unit/matrix/test_util_distribution.cpp:40: std::vector tests = { +./test/unit/matrix/test_views.cpp:53:const std::vector configs{ +./test/unit/multiplication/test_multiplication_general.cpp:221:std::vector gemm_configs = { +./test/unit/multiplication/test_multiplication_hermitian.cpp:52:const std::vector blas_sides({blas::Side::Left, blas::Side::Right}); +./test/unit/multiplication/test_multiplication_triangular.cpp:52:const std::vector blas_sides({blas::Side::Left, blas::Side::Right}); +./test/unit/permutations/test_permutations_distributed.cpp:48:using testcase_t = std::tuple>; +./test/unit/permutations/test_permutations_local.cpp:88:const std::vector> sizes = { +./test/unit/solver/test_triangular.cpp:52:const std::vector blas_sides({blas::Side::Left, blas::Side::Right}); +./test/unit/test_blas_tile.cpp:26:const std::vector blas_diags({blas::Diag::Unit, blas::Diag::NonUnit}); +./test/unit/test_blas_tile_extensions.cpp:37:std::vector> scal_sizes = { +./test/unit/test_lapack_tile.cpp:28:const std::vector blas_diags({blas::Diag::Unit, blas::Diag::NonUnit}); +./test/unit/test_util_math.cpp:231: std::vector splits = util::interleaveSplits(l, b, o1, o2); +Include for \bstd::string\b: +./miniapp/miniapp_communication.cpp:94:std::string string_default(std::string name, Device D) { +./miniapp/miniapp_triangular_multiplication.cpp:66: side(dlaf::miniapp::parseSide(vm["side"].as())), +Include for \bstd::setprecision\b: +./include/dlaf/matrix/print_csv.h:36: os << std::setprecision(5) << tile({ii, jj}) << ","; +Include for \bstd::is_same\b: +./src/eigensolver/tridiag_solver/gpu/kernels.cu:34: if constexpr (std::is_same::value) { +./test/unit/test_util_math.cpp:34: EXPECT_TRUE((std::is_same())); +Include for \bstd::((i|o)?stringstream)\b: +./include/dlaf/matrix/print_numpy.h:48: std::ostringstream os; +./miniapp/include/dlaf/miniapp/options.h:162: std::ostringstream valid_values_stream; +./miniapp/miniapp_communication.cpp:95: std::stringstream s; +./src/c_api/utils.cpp:56: std::stringstream ss; +./test/src/gtest_mpi_listener.cpp:63: std::ostringstream os; +./test/unit/common/test_size2d.cpp:94: std::stringstream s; +./test/unit/matrix/test_matrix.cpp:353: std::stringstream s; \ + + +Found 212 violation(s) \ No newline at end of file diff --git a/miniapp/include/dlaf/miniapp/work_tiles.h b/miniapp/include/dlaf/miniapp/work_tiles.h index eb0ccc2f85..e04ff0b8d4 100644 --- a/miniapp/include/dlaf/miniapp/work_tiles.h +++ b/miniapp/include/dlaf/miniapp/work_tiles.h @@ -11,6 +11,7 @@ #pragma once #include +#include #include #include diff --git a/miniapp/miniapp_cholesky.cpp b/miniapp/miniapp_cholesky.cpp index 2d3d921460..947835f955 100644 --- a/miniapp/miniapp_cholesky.cpp +++ b/miniapp/miniapp_cholesky.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include #include diff --git a/miniapp/miniapp_communication.cpp b/miniapp/miniapp_communication.cpp index 9e4582ffa6..762cba562e 100644 --- a/miniapp/miniapp_communication.cpp +++ b/miniapp/miniapp_communication.cpp @@ -10,6 +10,7 @@ #include #include +#include #include #include From 0501bfe0f37917d71d828c59debb10b177f28769 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Thu, 18 Apr 2024 11:52:08 +0200 Subject: [PATCH 10/62] add #include , in 70 files --- include/dlaf/matrix/tile.h | 1 + inshpect.output | 143 ++++++------------ src/c_api/factorization/cholesky.h | 2 + src/matrix/distribution.cpp | 1 + .../dlaf_test/matrix/util_matrix_local.h | 1 + .../dlaf_test/matrix/util_matrix_senders.h | 1 + test/include/dlaf_test/matrix/util_tile.h | 1 + test/src/gtest_mpi_listener.cpp | 1 + test/unit/auxiliary/mc/test_norm.cpp | 1 + .../eigensolver/test_eigensolver_c_api.cpp | 1 + .../test_gen_eigensolver_c_api.cpp | 1 + .../factorization/test_cholesky_c_api.cpp | 1 + test/unit/common/test_pipeline.cpp | 1 + test/unit/communication/test_all_reduce.cpp | 2 + .../communication/test_collective_async.cpp | 1 + test/unit/communication/test_comm_sender.cpp | 1 + test/unit/communication/test_message.cpp | 2 + test/unit/communication/test_reduce.cpp | 2 + .../unit/communication/test_transform_mpi.cpp | 1 + .../unit/eigensolver/test_band_to_tridiag.cpp | 1 + .../eigensolver/test_bt_reduction_to_band.cpp | 1 + test/unit/eigensolver/test_eigensolver.cpp | 1 + .../unit/eigensolver/test_gen_eigensolver.cpp | 1 + test/unit/eigensolver/test_gen_to_std.cpp | 1 + .../test_tridiag_solver_distributed.cpp | 2 + .../eigensolver/test_tridiag_solver_local.cpp | 2 + .../eigensolver/test_tridiag_solver_merge.cpp | 1 + test/unit/factorization/test_cholesky.cpp | 1 + .../factorization/test_compute_t_factor.cpp | 1 + test/unit/matrix/test_copy.cpp | 1 + test/unit/matrix/test_distribution.cpp | 1 + test/unit/matrix/test_matrix.cpp | 1 + test/unit/matrix/test_matrix_hdf5.cpp | 1 + test/unit/matrix/test_matrix_local.cpp | 1 + test/unit/matrix/test_matrix_mirror.cpp | 1 + test/unit/matrix/test_matrix_output.cpp | 1 + test/unit/matrix/test_retiled_matrix.cpp | 1 + test/unit/matrix/test_tile.cpp | 1 + test/unit/matrix/test_util_matrix.cpp | 1 + test/unit/memory/test_memory_chunk.cpp | 1 + test/unit/memory/test_memory_view.cpp | 1 + .../test_multiplication_general.cpp | 2 + .../test_multiplication_hermitian.cpp | 1 + .../test_multiplication_triangular.cpp | 1 + .../test_permutations_distributed.cpp | 1 + test/unit/sender/test_with_temporary_tile.cpp | 2 + test/unit/solver/test_triangular.cpp | 1 + test/unit/test_lapack_tile.cpp | 1 + 48 files changed, 101 insertions(+), 97 deletions(-) diff --git a/include/dlaf/matrix/tile.h b/include/dlaf/matrix/tile.h index 99a66368b4..917febaef0 100644 --- a/include/dlaf/matrix/tile.h +++ b/include/dlaf/matrix/tile.h @@ -17,6 +17,7 @@ #include #include #include +#include #include #include diff --git a/inshpect.output b/inshpect.output index d2a5dc315f..d57daba99e 100644 --- a/inshpect.output +++ b/inshpect.output @@ -1,57 +1,9 @@ # Includes -Include for \bstd::move\b: -./include/dlaf/matrix/tile.h:41: : size_(size), memory_view_(std::move(memory_view)), ld_(ld) { -./src/c_api/factorization/cholesky.h:43: dlaf::matrix::Matrix matrix_host(std::move(distribution), layout, a); -./src/matrix/distribution.cpp:94: : Distribution(std::move(rhs)) { -./test/include/dlaf_test/matrix/util_matrix_local.h:97: return MatrixLocal(std::move(dest)); -./test/include/dlaf_test/matrix/util_matrix_senders.h:150: std::move(previous[index]).get(); -./test/include/dlaf_test/matrix/util_tile.h:63: pika::this_thread::experimental::sync_wait(std::move(sender)); -./test/src/gtest_mpi_listener.cpp:27: : listener_(std::move(other)) { -./test/unit/auxiliary/mc/test_norm.cpp:57: Matrix matrix(std::move(distribution)); -./test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp:173: return EigensolverResult{std::move(eigenvalues), std::move(eigenvectors)}; -./test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp:190: return EigensolverResult{std::move(eigenvalues), std::move(eigenvectors)}; -./test/unit/c_api/factorization/test_cholesky_c_api.cpp:74: Matrix mat_h(std::move(distribution)); -./test/unit/common/test_pipeline.cpp:115: tt::sync_wait(ex::when_all(std::move(checkpoint0), std::move(checkpoint1), std::move(checkpoint2))); -./test/unit/communication/test_all_reduce.cpp:117: sync::allReduce(communicator, op, std::move(message_input), std::move(message_output)); -./test/unit/communication/test_collective_async.cpp:131: auto tile = tt::sync_wait(std::move(after)); -./test/unit/communication/test_comm_sender.cpp:44: sync_wait(when_all(std::move(send), std::move(recv)) | then([](int e1, int e2) { -./test/unit/communication/test_message.cpp:115: auto new_message = std::move(message); -./test/unit/communication/test_reduce.cpp:162: sync::reduce(root, communicator, op, std::move(message_input), std::move(message_output)); -./test/unit/communication/test_transform_mpi.cpp:87: return std::move(pg); -./test/unit/eigensolver/test_band_to_tridiag.cpp:145: Matrix mat_a_h(std::move(distr)); -./test/unit/eigensolver/test_bt_reduction_to_band.cpp:211: Matrix mat_c_h(std::move(dist_c)); -./test/unit/eigensolver/test_eigensolver.cpp:123: return EigensolverResult{std::move(eigenvalues), std::move(eigenvectors)}; -./test/unit/eigensolver/test_gen_eigensolver.cpp:120: return EigensolverResult{std::move(eigenvalues), std::move(eigenvectors)}; -./test/unit/eigensolver/test_gen_to_std.cpp:91: Matrix mat_ah(std::move(distr_a)); -./test/unit/eigensolver/test_tridiag_solver_distributed.cpp:98: matrix::util::set(tridiag, std::move(tridiag_fn)); -./test/unit/eigensolver/test_tridiag_solver_local.cpp:77: matrix::util::set(tridiag, std::move(tridiag_fn)); -./test/unit/eigensolver/test_tridiag_solver_merge.cpp:145: const SizeType k = tt::sync_wait(std::move(k_sender)); -./test/unit/factorization/test_cholesky.cpp:86: Matrix mat_h(std::move(distribution)); -./test/unit/factorization/test_compute_t_factor.cpp:162: return std::make_tuple(std::move(mat_taus), std::move(h_expected)); -./test/unit/matrix/test_copy.cpp:88: Matrix mat_src_const = std::move(mat_src); -./test/unit/matrix/test_distribution.cpp:351: Distribution obj_move(std::move(obj)); -./test/unit/matrix/test_matrix.cpp:208: Matrix mat(std::move(distribution)); -./test/unit/matrix/test_matrix_hdf5.cpp:76: return std::make_tuple(std::move(matrix), std::move(original_values)); -./test/unit/matrix/test_matrix_local.cpp:130: return std::make_pair(std::move(mat), output); -./test/unit/matrix/test_matrix_mirror.cpp:247: Matrix mat(std::move(mat_nonconst)); -./test/unit/matrix/test_matrix_output.cpp:63: return std::make_tuple(std::move(mat), output, output_csv); -./test/unit/matrix/test_retiled_matrix.cpp:256: std::move(rwsender0).get(); -./test/unit/matrix/test_tile.cpp:98: Tile tile(size, std::move(mem_view), ld); -./test/unit/matrix/test_util_matrix.cpp:71: Matrix matrix(std::move(distribution), layout, mem()); -./test/unit/memory/test_memory_chunk.cpp:60: memory::MemoryChunk mem2(std::move(mem)); -./test/unit/memory/test_memory_view.cpp:215: memory::MemoryView mem2(std::move(mem)); -./test/unit/multiplication/test_multiplication_general.cpp:183: Matrix matrix(std::move(dist)); -./test/unit/multiplication/test_multiplication_hermitian.cpp:115: Matrix mat_ah(std::move(distr_a)); -./test/unit/multiplication/test_multiplication_triangular.cpp:119: Matrix mat_ah(std::move(distr_a)); -./test/unit/permutations/test_permutations_distributed.cpp:77: return {m, mb, i_begin_tile, i_end_tile, std::move(perms)}; -./test/unit/sender/test_with_temporary_tile.cpp:119: return internal::whenAllLift(std::move(check_tile_sender), blas::Uplo::General, output_value, -./test/unit/solver/test_triangular.cpp:116: Matrix mat_ah(std::move(distr_a)); -./test/unit/test_lapack_tile.cpp:302: auto tridiag = createTile(std::move(tridiag_f), TileElementSize(sz, 2), sz); Include for \bstd::array\b: ./include/dlaf/eigensolver/reduction_to_band/impl.h:73:std::array computeX0AndSquares(const bool has_head, const std::vector>& panel, ./test/unit/communication/test_communicator_grid.cpp:28:std::array computeGridDims(int nranks) { -./test/unit/eigensolver/test_tridiag_solver_merge.cpp:121: constexpr std::array in_arr{1, 4, 2, 3, 0, 5, 6, 7, 8, 9}; +./test/unit/eigensolver/test_tridiag_solver_merge.cpp:122: constexpr std::array in_arr{1, 4, 2, 3, 0, 5, 6, 7, 8, 9}; Include for \bstd::declval\b: ./include/dlaf/eigensolver/tridiag_solver/impl.h:75: ex::ensure_started(cuppensDecompAsync(tridiag.readwrite(std::declval()), Include for \bstd::nullopt\b: @@ -96,62 +48,60 @@ Include for \bstd::size_t\b: ./src/memory/memory_chunk.cpp:37:void initializeUmpireHostAllocator(std::size_t initial_bytes) { ./test/include/dlaf_test/comm_grids/grids_6_ranks.h:80: const std::size_t ncommunicator_pipelines = 3; ./test/include/dlaf_test/matrix/matrix_local.h:123: std::size_t tileLinearIndex(const GlobalTileIndex& index) const noexcept { -./test/include/dlaf_test/matrix/util_matrix_local.h:53: const auto linear_size = static_cast(source.size().rows() * source.size().cols()); -./test/include/dlaf_test/matrix/util_matrix_senders.h:38: result.reserve(static_cast(dist.localNrTiles().linear_size())); -./test/src/gtest_mpi_listener.cpp:87: return last_test_part_results_[static_cast(index)]; +./test/include/dlaf_test/matrix/util_matrix_local.h:54: const auto linear_size = static_cast(source.size().rows() * source.size().cols()); +./test/include/dlaf_test/matrix/util_matrix_senders.h:39: result.reserve(static_cast(dist.localNrTiles().linear_size())); +./test/src/gtest_mpi_listener.cpp:88: return last_test_part_results_[static_cast(index)]; ./test/unit/common/test_data_descriptor.cpp:46: return {std::make_unique(static_cast(blocksize)), num_blocks, blocksize, stride}; -./test/unit/communication/test_comm_sender.cpp:36: std::vector send_buf(static_cast(size), rank); +./test/unit/communication/test_comm_sender.cpp:37: std::vector send_buf(static_cast(size), rank); ./test/unit/communication/test_communicator_grid.cpp:214: const std::vector test_npipelines{1, 3, 10}; ./test/unit/init/test_init.cpp:92: const std::size_t default_val = default_cfg.num_hp_gpu_streams_per_thread; -./test/unit/matrix/test_tile.cpp:388: const std::vector& specs, std::size_t last_dep, -./test/unit/permutations/test_permutations_distributed.cpp:74: const std::size_t nperms = to_sizet(i_end - i_begin); +./test/unit/matrix/test_tile.cpp:389: const std::vector& specs, std::size_t last_dep, +./test/unit/permutations/test_permutations_distributed.cpp:75: const std::size_t nperms = to_sizet(i_end - i_begin); Include for \bstd::swap\b: ./include/dlaf/common/index2d.h:107: std::swap(row_, col_); ./include/dlaf/util_math.h:47: std::swap(small, big); ./miniapp/kernel/miniapp_laset.cpp:57: std::swap(m, n); -./test/unit/test_lapack_tile.cpp:120: std::swap(m, n); Include for \bstd::(c?ref)\b: ./include/dlaf/communication/kernels/internal/all_reduce.h:72: return whenAllLift(std::move(pcomm), reduce_op, std::cref(tile_in_comm), ./include/dlaf/communication/kernels/internal/broadcast.h:58: return whenAllLift(std::move(pcomm), std::cref(tile_comm)) | transformMPI(sendBcast_o); ./include/dlaf/communication/kernels/internal/p2p.h:62: return whenAllLift(std::move(pcomm), dest, tag, std::cref(tile_comm)) | transformMPI(send_o); ./include/dlaf/communication/kernels/internal/reduce.h:80: return whenAllLift(std::move(pcomm), reduce_op, std::cref(tile_comm)) | ./include/dlaf/sender/with_temporary_tile.h:126: return ex::just(std::cref(in)) | -./test/unit/sender/test_with_temporary_tile.cpp:112: ex::just(std::cref(temp)) | +./test/unit/sender/test_with_temporary_tile.cpp:114: ex::just(std::cref(temp)) | Include for \bstd::(forward_as_|make_|)tuple\b: ./include/dlaf/eigensolver/tridiag_solver/impl.h:46: std::vector>& indices) { ./include/dlaf/permutations/general/impl.h:159: return std::tuple(std::move(splits), std::move(index_tile_futs), std::move(mat_in_tiles), ./src/c_api/utils.cpp:31:std::tuple distribution_and_layout( ./src/c_api/utils.h:15:std::tuple distribution_and_layout( -./test/unit/eigensolver/test_tridiag_solver_distributed.cpp:48:const std::vector> tested_problems = { -./test/unit/eigensolver/test_tridiag_solver_local.cpp:40: std::vector> expected_indices{{0, 1, 2}, {0, 2, 3}, +./test/unit/eigensolver/test_tridiag_solver_distributed.cpp:50:const std::vector> tested_problems = { +./test/unit/eigensolver/test_tridiag_solver_local.cpp:42: std::vector> expected_indices{{0, 1, 2}, {0, 2, 3}, ./test/unit/lapack/gpu/test_lacpy.cpp:32:std::vector> configs{ -./test/unit/matrix/test_distribution.cpp:191:std::tuple test_tile_size(const ParametersConstructor& test) { +./test/unit/matrix/test_distribution.cpp:192:std::tuple test_tile_size(const ParametersConstructor& test) { ./test/unit/matrix/test_layout_info.cpp:20:const std::vector> -./test/unit/matrix/test_matrix.cpp:742: return std::tuple(std::move(rosenders2a), std::move(rosenders2b), std::move(senders3)); -./test/unit/matrix/test_matrix_hdf5.cpp:76: return std::make_tuple(std::move(matrix), std::move(original_values)); -./test/unit/matrix/test_retiled_matrix.cpp:48:const std::vector> local_sizes_tests({ -./test/unit/matrix/test_tile.cpp:44:using TileSizes = std::tuple; -./test/unit/multiplication/test_multiplication_general.cpp:290:const std::vector> sizes = { -./test/unit/permutations/test_permutations_distributed.cpp:48:using testcase_t = std::tuple>; +./test/unit/matrix/test_matrix.cpp:743: return std::tuple(std::move(rosenders2a), std::move(rosenders2b), std::move(senders3)); +./test/unit/matrix/test_matrix_hdf5.cpp:77: return std::make_tuple(std::move(matrix), std::move(original_values)); +./test/unit/matrix/test_retiled_matrix.cpp:49:const std::vector> local_sizes_tests({ +./test/unit/matrix/test_tile.cpp:45:using TileSizes = std::tuple; +./test/unit/multiplication/test_multiplication_general.cpp:292:const std::vector> sizes = { +./test/unit/permutations/test_permutations_distributed.cpp:49:using testcase_t = std::tuple>; ./test/unit/permutations/test_permutations_local.cpp:88:const std::vector> sizes = { ./test/unit/test_blas_tile.cpp:47:std::vector> gemm_sizes = { ./test/unit/test_blas_tile_extensions.cpp:37:std::vector> scal_sizes = { -./test/unit/test_lapack_tile.cpp:54:std::vector> hegst_sizes = { +./test/unit/test_lapack_tile.cpp:55:std::vector> hegst_sizes = { Include for \bstd::make_pair\b: ./include/dlaf/communication/broadcast_panel.h:42: return std::make_pair(idx_cross, rank_owner); ./include/dlaf/eigensolver/tridiag_solver/tile_collector.h:44: return std::make_pair(begin, size); ./test/include/dlaf_c_test/c_api_helpers.h:81: return std::make_pair(local_ptr, lld); -./test/unit/matrix/test_matrix_local.cpp:130: return std::make_pair(std::move(mat), output); Include for \bstd::(cin|cout|cerr|clog)\b: ./include/dlaf/matrix/print_csv.h:33:void print(format::csv, const Tile& tile, std::ostream& os = std::cout) { ./include/dlaf/matrix/print_numpy.h:68:void print(format::numpy, const Tile& tile, std::ostream& os = std::cout) { ./include/dlaf/memory/memory_chunk.h:70: std::cout ./miniapp/kernel/miniapp_laset.cpp:107: std::cout << "[" << run_index << "]" ./src/c_api/grid.cpp:63: std::cerr << "Grid layout must be row major or column major." << std::endl; -./test/include/dlaf_test/matrix/util_matrix_local.h:139: std::ostream& os = std::cout) { +./test/include/dlaf_test/matrix/util_matrix_local.h:140: std::ostream& os = std::cout) { ./test/unit/common/test_data_descriptor.cpp:79: std::cout << "Unknown memory type" << std::endl; Include for \bstd::atomic\b: -./test/include/dlaf_test/matrix/util_tile.h:48: : ready(std::make_shared>(false)), +./test/include/dlaf_test/matrix/util_tile.h:49: : ready(std::make_shared>(false)), Include for \bstd::forward\b: ./include/dlaf/common/callable_object.h:29: auto operator()(Ts&&... ts) const noexcept(noexcept((fname) (std::forward(ts)...))) \ ./include/dlaf/communication/sync/basic.h:30: auto message = make_message(common::make_data(std::forward(data))); @@ -163,7 +113,6 @@ Include for \bstd::forward\b: ./miniapp/include/dlaf/miniapp/kernel_runner.h:87: return runInternal(std::forward(kernel_task), streams_); ./test/include/dlaf_test/blas/invoke.h:34: f(std::forward(args)...); ./test/include/dlaf_test/lapack/invoke.h:34: f(std::forward(args)...); -./test/include/dlaf_test/matrix/util_tile.h:49: sender(std::forward(sender) | ./test/unit/communication/test_comm_p2p.cpp:60: std::forward(tile)) | ./test/unit/init/test_init.cpp:47: init_ = std::make_unique(std::forward(args)...); Include for \bstd::vector\b: @@ -173,48 +122,48 @@ Include for \bstd::vector\b: ./include/dlaf/eigensolver/tridiag_solver/impl.h:46: std::vector>& indices) { ./include/dlaf/eigensolver/tridiag_solver/merge.h:224: std::vector> tiles_max; ./include/dlaf/eigensolver/tridiag_solver/rot.h:266: mb](std::vector> rots, std::vector> tiles, -./include/dlaf/matrix/tile.h:539:std::vector> splitTile(ReadOnlyTileSender tile, +./include/dlaf/matrix/tile.h:540:std::vector> splitTile(ReadOnlyTileSender tile, ./include/dlaf/permutations/general/impl.h:98: const SizeType i_perm, const std::vector& splits, const GlobalElementIndex out_begin, ./miniapp/include/dlaf/miniapp/options.h:154: const std::vector& valid_values) { ./src/permutations/general/perms.cu:40: const std::vector>& tiles) { ./test/include/dlaf_test/comm_grids/grids_6_ranks.h:21:std::vector comm_grids; ./test/include/dlaf_test/matrix/matrix_local.h:134: std::vector> tiles_; -./test/src/gtest_mpi_listener.cpp:183: std::vector message_buffer(static_cast(message_length)); -./test/unit/auxiliary/mc/test_norm.cpp:43:const std::vector lapack_norms({lapack::Norm::Fro, lapack::Norm::Inf, lapack::Norm::Max, -./test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp:57:const std::vector blas_uplos({blas::Uplo::Lower}); -./test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp:55:const std::vector blas_uplos({blas::Uplo::Lower}); -./test/unit/c_api/factorization/test_cholesky_c_api.cpp:51:const std::vector blas_uplos({blas::Uplo::Lower, blas::Uplo::Upper}); +./test/src/gtest_mpi_listener.cpp:184: std::vector message_buffer(static_cast(message_length)); +./test/unit/auxiliary/mc/test_norm.cpp:44:const std::vector lapack_norms({lapack::Norm::Fro, lapack::Norm::Inf, lapack::Norm::Max, +./test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp:58:const std::vector blas_uplos({blas::Uplo::Lower}); +./test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp:56:const std::vector blas_uplos({blas::Uplo::Lower}); +./test/unit/c_api/factorization/test_cholesky_c_api.cpp:52:const std::vector blas_uplos({blas::Uplo::Lower, blas::Uplo::Upper}); ./test/unit/common/test_data_descriptor.cpp:701: std::vector> memory_types; ./test/unit/communication/test_broadcast_panel.cpp:50:std::vector test_params{ ./test/unit/communication/test_communicator_grid.cpp:214: const std::vector test_npipelines{1, 3, 10}; -./test/unit/eigensolver/test_band_to_tridiag.cpp:49:const std::vector> sizes = { +./test/unit/eigensolver/test_band_to_tridiag.cpp:50:const std::vector> sizes = { ./test/unit/eigensolver/test_bt_band_to_tridiag.cpp:253:std::vector configs{ -./test/unit/eigensolver/test_eigensolver.cpp:60:const std::vector blas_uplos({blas::Uplo::Lower}); -./test/unit/eigensolver/test_gen_eigensolver.cpp:60:const std::vector blas_uplos({blas::Uplo::Lower}); -./test/unit/eigensolver/test_gen_to_std.cpp:50:const std::vector blas_uplos({blas::Uplo::Lower, blas::Uplo::Upper}); +./test/unit/eigensolver/test_eigensolver.cpp:61:const std::vector blas_uplos({blas::Uplo::Lower}); +./test/unit/eigensolver/test_gen_eigensolver.cpp:61:const std::vector blas_uplos({blas::Uplo::Lower}); +./test/unit/eigensolver/test_gen_to_std.cpp:51:const std::vector blas_uplos({blas::Uplo::Lower, blas::Uplo::Upper}); ./test/unit/eigensolver/test_reduction_to_band.cpp:82:std::vector configs{ -./test/unit/eigensolver/test_tridiag_solver_distributed.cpp:48:const std::vector> tested_problems = { -./test/unit/eigensolver/test_tridiag_solver_local.cpp:40: std::vector> expected_indices{{0, 1, 2}, {0, 2, 3}, -./test/unit/eigensolver/test_tridiag_solver_merge.cpp:69: std::vector vec_arr{7, 2, 4, 8, 12, 1, 17, 32, 9, 6}; +./test/unit/eigensolver/test_tridiag_solver_distributed.cpp:50:const std::vector> tested_problems = { +./test/unit/eigensolver/test_tridiag_solver_local.cpp:42: std::vector> expected_indices{{0, 1, 2}, {0, 2, 3}, +./test/unit/eigensolver/test_tridiag_solver_merge.cpp:70: std::vector vec_arr{7, 2, 4, 8, 12, 1, 17, 32, 9, 6}; ./test/unit/eigensolver/test_tridiag_solver_rot.cpp:50: std::vector rots; -./test/unit/factorization/test_cholesky.cpp:50:const std::vector blas_uplos({blas::Uplo::Lower, blas::Uplo::Upper}); -./test/unit/factorization/test_compute_t_factor.cpp:206:std::vector> configs{ +./test/unit/factorization/test_cholesky.cpp:51:const std::vector blas_uplos({blas::Uplo::Lower, blas::Uplo::Upper}); +./test/unit/factorization/test_compute_t_factor.cpp:207:std::vector> configs{ ./test/unit/lapack/gpu/test_lacpy.cpp:32:std::vector> configs{ -./test/unit/matrix/test_distribution.cpp:37:const std::vector tests_constructor = { +./test/unit/matrix/test_distribution.cpp:38:const std::vector tests_constructor = { ./test/unit/matrix/test_distribution_extensions.cpp:42:const std::vector tests_indices = { ./test/unit/matrix/test_layout_info.cpp:20:const std::vector> -./test/unit/matrix/test_tile.cpp:35:const std::vector sizes({0, 1, 13, 32}); +./test/unit/matrix/test_tile.cpp:36:const std::vector sizes({0, 1, 13, 32}); ./test/unit/matrix/test_util_distribution.cpp:40: std::vector tests = { ./test/unit/matrix/test_views.cpp:53:const std::vector configs{ -./test/unit/multiplication/test_multiplication_general.cpp:221:std::vector gemm_configs = { -./test/unit/multiplication/test_multiplication_hermitian.cpp:52:const std::vector blas_sides({blas::Side::Left, blas::Side::Right}); -./test/unit/multiplication/test_multiplication_triangular.cpp:52:const std::vector blas_sides({blas::Side::Left, blas::Side::Right}); -./test/unit/permutations/test_permutations_distributed.cpp:48:using testcase_t = std::tuple>; +./test/unit/multiplication/test_multiplication_general.cpp:223:std::vector gemm_configs = { +./test/unit/multiplication/test_multiplication_hermitian.cpp:53:const std::vector blas_sides({blas::Side::Left, blas::Side::Right}); +./test/unit/multiplication/test_multiplication_triangular.cpp:53:const std::vector blas_sides({blas::Side::Left, blas::Side::Right}); +./test/unit/permutations/test_permutations_distributed.cpp:49:using testcase_t = std::tuple>; ./test/unit/permutations/test_permutations_local.cpp:88:const std::vector> sizes = { -./test/unit/solver/test_triangular.cpp:52:const std::vector blas_sides({blas::Side::Left, blas::Side::Right}); +./test/unit/solver/test_triangular.cpp:53:const std::vector blas_sides({blas::Side::Left, blas::Side::Right}); ./test/unit/test_blas_tile.cpp:26:const std::vector blas_diags({blas::Diag::Unit, blas::Diag::NonUnit}); ./test/unit/test_blas_tile_extensions.cpp:37:std::vector> scal_sizes = { -./test/unit/test_lapack_tile.cpp:28:const std::vector blas_diags({blas::Diag::Unit, blas::Diag::NonUnit}); +./test/unit/test_lapack_tile.cpp:29:const std::vector blas_diags({blas::Diag::Unit, blas::Diag::NonUnit}); ./test/unit/test_util_math.cpp:231: std::vector splits = util::interleaveSplits(l, b, o1, o2); Include for \bstd::string\b: ./miniapp/miniapp_communication.cpp:94:std::string string_default(std::string name, Device D) { @@ -229,9 +178,9 @@ Include for \bstd::((i|o)?stringstream)\b: ./miniapp/include/dlaf/miniapp/options.h:162: std::ostringstream valid_values_stream; ./miniapp/miniapp_communication.cpp:95: std::stringstream s; ./src/c_api/utils.cpp:56: std::stringstream ss; -./test/src/gtest_mpi_listener.cpp:63: std::ostringstream os; +./test/src/gtest_mpi_listener.cpp:64: std::ostringstream os; ./test/unit/common/test_size2d.cpp:94: std::stringstream s; -./test/unit/matrix/test_matrix.cpp:353: std::stringstream s; \ +./test/unit/matrix/test_matrix.cpp:354: std::stringstream s; \ -Found 212 violation(s) \ No newline at end of file +Found 162 violation(s) \ No newline at end of file diff --git a/src/c_api/factorization/cholesky.h b/src/c_api/factorization/cholesky.h index 71d57821ac..407f77bcb3 100644 --- a/src/c_api/factorization/cholesky.h +++ b/src/c_api/factorization/cholesky.h @@ -10,6 +10,8 @@ #pragma once +#include + #include #include #include diff --git a/src/matrix/distribution.cpp b/src/matrix/distribution.cpp index 8203b4ac4c..b5bb9b2779 100644 --- a/src/matrix/distribution.cpp +++ b/src/matrix/distribution.cpp @@ -9,6 +9,7 @@ // #include +#include #include diff --git a/test/include/dlaf_test/matrix/util_matrix_local.h b/test/include/dlaf_test/matrix/util_matrix_local.h index c450943315..914a28afc7 100644 --- a/test/include/dlaf_test/matrix/util_matrix_local.h +++ b/test/include/dlaf_test/matrix/util_matrix_local.h @@ -15,6 +15,7 @@ #include #include #include +#include #include #include diff --git a/test/include/dlaf_test/matrix/util_matrix_senders.h b/test/include/dlaf_test/matrix/util_matrix_senders.h index 9e6aee6f8f..a5122eacc3 100644 --- a/test/include/dlaf_test/matrix/util_matrix_senders.h +++ b/test/include/dlaf_test/matrix/util_matrix_senders.h @@ -13,6 +13,7 @@ /// @file #include +#include #include #include diff --git a/test/include/dlaf_test/matrix/util_tile.h b/test/include/dlaf_test/matrix/util_tile.h index 5a28c558db..ea51af40d7 100644 --- a/test/include/dlaf_test/matrix/util_tile.h +++ b/test/include/dlaf_test/matrix/util_tile.h @@ -17,6 +17,7 @@ #include #include #include +#include #include #include diff --git a/test/src/gtest_mpi_listener.cpp b/test/src/gtest_mpi_listener.cpp index 86a32d6fa3..ad29532dcf 100644 --- a/test/src/gtest_mpi_listener.cpp +++ b/test/src/gtest_mpi_listener.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include "gtest_mpi_listener.h" diff --git a/test/unit/auxiliary/mc/test_norm.cpp b/test/unit/auxiliary/mc/test_norm.cpp index c23c02e388..238a950143 100644 --- a/test/unit/auxiliary/mc/test_norm.cpp +++ b/test/unit/auxiliary/mc/test_norm.cpp @@ -9,6 +9,7 @@ // #include +#include #include #include diff --git a/test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp b/test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp index 07644be243..6460b60af6 100644 --- a/test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp +++ b/test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp @@ -10,6 +10,7 @@ #include #include +#include #include diff --git a/test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp b/test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp index f6b936ba03..9b0465bf3e 100644 --- a/test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp +++ b/test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp @@ -10,6 +10,7 @@ #include #include +#include #include diff --git a/test/unit/c_api/factorization/test_cholesky_c_api.cpp b/test/unit/c_api/factorization/test_cholesky_c_api.cpp index 79286f5e17..0df751f765 100644 --- a/test/unit/c_api/factorization/test_cholesky_c_api.cpp +++ b/test/unit/c_api/factorization/test_cholesky_c_api.cpp @@ -10,6 +10,7 @@ #include #include +#include #include diff --git a/test/unit/common/test_pipeline.cpp b/test/unit/common/test_pipeline.cpp index 75f6b72015..daf69ee79e 100644 --- a/test/unit/common/test_pipeline.cpp +++ b/test/unit/common/test_pipeline.cpp @@ -13,6 +13,7 @@ #include #include #include +#include #include #include diff --git a/test/unit/communication/test_all_reduce.cpp b/test/unit/communication/test_all_reduce.cpp index 112302ddb1..cab786c2fc 100644 --- a/test/unit/communication/test_all_reduce.cpp +++ b/test/unit/communication/test_all_reduce.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include #include diff --git a/test/unit/communication/test_collective_async.cpp b/test/unit/communication/test_collective_async.cpp index 8e8e1577d9..7d0afcc634 100644 --- a/test/unit/communication/test_collective_async.cpp +++ b/test/unit/communication/test_collective_async.cpp @@ -9,6 +9,7 @@ // #include +#include #include diff --git a/test/unit/communication/test_comm_sender.cpp b/test/unit/communication/test_comm_sender.cpp index c34fd41526..818d97eb0c 100644 --- a/test/unit/communication/test_comm_sender.cpp +++ b/test/unit/communication/test_comm_sender.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include diff --git a/test/unit/communication/test_message.cpp b/test/unit/communication/test_message.cpp index 8c8e6f7b8f..f598b490d1 100644 --- a/test/unit/communication/test_message.cpp +++ b/test/unit/communication/test_message.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include #include diff --git a/test/unit/communication/test_reduce.cpp b/test/unit/communication/test_reduce.cpp index 92c9120e85..6e10b47c19 100644 --- a/test/unit/communication/test_reduce.cpp +++ b/test/unit/communication/test_reduce.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include #include diff --git a/test/unit/communication/test_transform_mpi.cpp b/test/unit/communication/test_transform_mpi.cpp index 47d81c9c47..bf9f857e0d 100644 --- a/test/unit/communication/test_transform_mpi.cpp +++ b/test/unit/communication/test_transform_mpi.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include #include diff --git a/test/unit/eigensolver/test_band_to_tridiag.cpp b/test/unit/eigensolver/test_band_to_tridiag.cpp index f2caef3adf..02798f1bea 100644 --- a/test/unit/eigensolver/test_band_to_tridiag.cpp +++ b/test/unit/eigensolver/test_band_to_tridiag.cpp @@ -12,6 +12,7 @@ #include #include #include +#include #include #include diff --git a/test/unit/eigensolver/test_bt_reduction_to_band.cpp b/test/unit/eigensolver/test_bt_reduction_to_band.cpp index 8648908878..d85ca65357 100644 --- a/test/unit/eigensolver/test_bt_reduction_to_band.cpp +++ b/test/unit/eigensolver/test_bt_reduction_to_band.cpp @@ -12,6 +12,7 @@ #include #include #include +#include #include #include diff --git a/test/unit/eigensolver/test_eigensolver.cpp b/test/unit/eigensolver/test_eigensolver.cpp index cc9d7386b4..9887d7601b 100644 --- a/test/unit/eigensolver/test_eigensolver.cpp +++ b/test/unit/eigensolver/test_eigensolver.cpp @@ -10,6 +10,7 @@ #include #include +#include #include #include diff --git a/test/unit/eigensolver/test_gen_eigensolver.cpp b/test/unit/eigensolver/test_gen_eigensolver.cpp index 19fcbbb056..1e88a2f2d4 100644 --- a/test/unit/eigensolver/test_gen_eigensolver.cpp +++ b/test/unit/eigensolver/test_gen_eigensolver.cpp @@ -10,6 +10,7 @@ #include #include +#include #include diff --git a/test/unit/eigensolver/test_gen_to_std.cpp b/test/unit/eigensolver/test_gen_to_std.cpp index b17f662f24..4fa7ea4292 100644 --- a/test/unit/eigensolver/test_gen_to_std.cpp +++ b/test/unit/eigensolver/test_gen_to_std.cpp @@ -10,6 +10,7 @@ #include #include +#include #include diff --git a/test/unit/eigensolver/test_tridiag_solver_distributed.cpp b/test/unit/eigensolver/test_tridiag_solver_distributed.cpp index 8cd17aa51b..3ef820b0e0 100644 --- a/test/unit/eigensolver/test_tridiag_solver_distributed.cpp +++ b/test/unit/eigensolver/test_tridiag_solver_distributed.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include diff --git a/test/unit/eigensolver/test_tridiag_solver_local.cpp b/test/unit/eigensolver/test_tridiag_solver_local.cpp index b3ea23ac40..f95abe9be1 100644 --- a/test/unit/eigensolver/test_tridiag_solver_local.cpp +++ b/test/unit/eigensolver/test_tridiag_solver_local.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include #include diff --git a/test/unit/eigensolver/test_tridiag_solver_merge.cpp b/test/unit/eigensolver/test_tridiag_solver_merge.cpp index ccf01c349e..dadce0734b 100644 --- a/test/unit/eigensolver/test_tridiag_solver_merge.cpp +++ b/test/unit/eigensolver/test_tridiag_solver_merge.cpp @@ -10,6 +10,7 @@ #include #include +#include #include #include diff --git a/test/unit/factorization/test_cholesky.cpp b/test/unit/factorization/test_cholesky.cpp index 572f304e2a..1bafc8149d 100644 --- a/test/unit/factorization/test_cholesky.cpp +++ b/test/unit/factorization/test_cholesky.cpp @@ -10,6 +10,7 @@ #include #include +#include #include diff --git a/test/unit/factorization/test_compute_t_factor.cpp b/test/unit/factorization/test_compute_t_factor.cpp index 62a623dad8..f23b0c68fc 100644 --- a/test/unit/factorization/test_compute_t_factor.cpp +++ b/test/unit/factorization/test_compute_t_factor.cpp @@ -9,6 +9,7 @@ // #include +#include #include diff --git a/test/unit/matrix/test_copy.cpp b/test/unit/matrix/test_copy.cpp index 72d6236e18..df728df86a 100644 --- a/test/unit/matrix/test_copy.cpp +++ b/test/unit/matrix/test_copy.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include diff --git a/test/unit/matrix/test_distribution.cpp b/test/unit/matrix/test_distribution.cpp index 9f347bfa1e..99194c2bb9 100644 --- a/test/unit/matrix/test_distribution.cpp +++ b/test/unit/matrix/test_distribution.cpp @@ -10,6 +10,7 @@ #include #include +#include #include diff --git a/test/unit/matrix/test_matrix.cpp b/test/unit/matrix/test_matrix.cpp index f2603fa936..8afb342e2f 100644 --- a/test/unit/matrix/test_matrix.cpp +++ b/test/unit/matrix/test_matrix.cpp @@ -10,6 +10,7 @@ #include #include +#include #include #include diff --git a/test/unit/matrix/test_matrix_hdf5.cpp b/test/unit/matrix/test_matrix_hdf5.cpp index 511fac83e3..7d3cfedf50 100644 --- a/test/unit/matrix/test_matrix_hdf5.cpp +++ b/test/unit/matrix/test_matrix_hdf5.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include #include diff --git a/test/unit/matrix/test_matrix_local.cpp b/test/unit/matrix/test_matrix_local.cpp index 4ba7ebd7ea..29eef594b6 100644 --- a/test/unit/matrix/test_matrix_local.cpp +++ b/test/unit/matrix/test_matrix_local.cpp @@ -10,6 +10,7 @@ #include #include +#include #include #include diff --git a/test/unit/matrix/test_matrix_mirror.cpp b/test/unit/matrix/test_matrix_mirror.cpp index b32ba83c6c..9b36620a14 100644 --- a/test/unit/matrix/test_matrix_mirror.cpp +++ b/test/unit/matrix/test_matrix_mirror.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include diff --git a/test/unit/matrix/test_matrix_output.cpp b/test/unit/matrix/test_matrix_output.cpp index 07ef9ce4bd..34cf1466b0 100644 --- a/test/unit/matrix/test_matrix_output.cpp +++ b/test/unit/matrix/test_matrix_output.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include #include diff --git a/test/unit/matrix/test_retiled_matrix.cpp b/test/unit/matrix/test_retiled_matrix.cpp index e9987974c3..b4a0cfde69 100644 --- a/test/unit/matrix/test_retiled_matrix.cpp +++ b/test/unit/matrix/test_retiled_matrix.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include diff --git a/test/unit/matrix/test_tile.cpp b/test/unit/matrix/test_tile.cpp index efc5881aad..cab77fb64b 100644 --- a/test/unit/matrix/test_tile.cpp +++ b/test/unit/matrix/test_tile.cpp @@ -9,6 +9,7 @@ // #include +#include #include diff --git a/test/unit/matrix/test_util_matrix.cpp b/test/unit/matrix/test_util_matrix.cpp index e65a5209a1..84d7aa493f 100644 --- a/test/unit/matrix/test_util_matrix.cpp +++ b/test/unit/matrix/test_util_matrix.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include diff --git a/test/unit/memory/test_memory_chunk.cpp b/test/unit/memory/test_memory_chunk.cpp index 53eb7ec2ea..f638eacd9b 100644 --- a/test/unit/memory/test_memory_chunk.cpp +++ b/test/unit/memory/test_memory_chunk.cpp @@ -9,6 +9,7 @@ // #include +#include #include diff --git a/test/unit/memory/test_memory_view.cpp b/test/unit/memory/test_memory_view.cpp index a6d1207def..88ccdb7830 100644 --- a/test/unit/memory/test_memory_view.cpp +++ b/test/unit/memory/test_memory_view.cpp @@ -9,6 +9,7 @@ // #include +#include #include diff --git a/test/unit/multiplication/test_multiplication_general.cpp b/test/unit/multiplication/test_multiplication_general.cpp index 0a48f5d37f..5a84c6bb2a 100644 --- a/test/unit/multiplication/test_multiplication_general.cpp +++ b/test/unit/multiplication/test_multiplication_general.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include diff --git a/test/unit/multiplication/test_multiplication_hermitian.cpp b/test/unit/multiplication/test_multiplication_hermitian.cpp index 941dae2516..effb7ae679 100644 --- a/test/unit/multiplication/test_multiplication_hermitian.cpp +++ b/test/unit/multiplication/test_multiplication_hermitian.cpp @@ -10,6 +10,7 @@ #include #include +#include #include diff --git a/test/unit/multiplication/test_multiplication_triangular.cpp b/test/unit/multiplication/test_multiplication_triangular.cpp index 84fe2c6330..175ccb4a54 100644 --- a/test/unit/multiplication/test_multiplication_triangular.cpp +++ b/test/unit/multiplication/test_multiplication_triangular.cpp @@ -10,6 +10,7 @@ #include #include +#include #include diff --git a/test/unit/permutations/test_permutations_distributed.cpp b/test/unit/permutations/test_permutations_distributed.cpp index a4b3f388ce..239a9ea5f6 100644 --- a/test/unit/permutations/test_permutations_distributed.cpp +++ b/test/unit/permutations/test_permutations_distributed.cpp @@ -9,6 +9,7 @@ // #include +#include #include diff --git a/test/unit/sender/test_with_temporary_tile.cpp b/test/unit/sender/test_with_temporary_tile.cpp index 4ae6547da4..cd48c0d5bc 100644 --- a/test/unit/sender/test_with_temporary_tile.cpp +++ b/test/unit/sender/test_with_temporary_tile.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include #include diff --git a/test/unit/solver/test_triangular.cpp b/test/unit/solver/test_triangular.cpp index 128a774895..49d19be501 100644 --- a/test/unit/solver/test_triangular.cpp +++ b/test/unit/solver/test_triangular.cpp @@ -10,6 +10,7 @@ #include #include +#include #include diff --git a/test/unit/test_lapack_tile.cpp b/test/unit/test_lapack_tile.cpp index cfd8e0a2e0..25fc746060 100644 --- a/test/unit/test_lapack_tile.cpp +++ b/test/unit/test_lapack_tile.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // #include +#include #include From 4031cf2a832492f33ae657f589b01d8a323c6b73 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Thu, 18 Apr 2024 12:41:08 +0200 Subject: [PATCH 11/62] add #include , in 10 files, #include --- .../dlaf/eigensolver/reduction_to_band/impl.h | 1 + include/dlaf/matrix/print_numpy.h | 1 + inshpect.output | 39 ++++++------------- miniapp/include/dlaf/miniapp/options.h | 1 + miniapp/miniapp_communication.cpp | 2 + miniapp/miniapp_triangular_multiplication.cpp | 1 + src/c_api/utils.cpp | 1 + test/src/gtest_mpi_listener.cpp | 1 + test/unit/common/test_size2d.cpp | 1 + .../communication/test_communicator_grid.cpp | 1 + .../eigensolver/test_tridiag_solver_merge.cpp | 1 + test/unit/matrix/test_matrix.cpp | 1 + 12 files changed, 24 insertions(+), 27 deletions(-) diff --git a/include/dlaf/eigensolver/reduction_to_band/impl.h b/include/dlaf/eigensolver/reduction_to_band/impl.h index c9c1448b4c..60860909a5 100644 --- a/include/dlaf/eigensolver/reduction_to_band/impl.h +++ b/include/dlaf/eigensolver/reduction_to_band/impl.h @@ -9,6 +9,7 @@ // #pragma once +#include #include #include #include diff --git a/include/dlaf/matrix/print_numpy.h b/include/dlaf/matrix/print_numpy.h index fc2acb94ff..27c8761249 100644 --- a/include/dlaf/matrix/print_numpy.h +++ b/include/dlaf/matrix/print_numpy.h @@ -12,6 +12,7 @@ /// @file +#include #include #include diff --git a/inshpect.output b/inshpect.output index d57daba99e..c4044ed427 100644 --- a/inshpect.output +++ b/inshpect.output @@ -1,9 +1,5 @@ # Includes -Include for \bstd::array\b: -./include/dlaf/eigensolver/reduction_to_band/impl.h:73:std::array computeX0AndSquares(const bool has_head, const std::vector>& panel, -./test/unit/communication/test_communicator_grid.cpp:28:std::array computeGridDims(int nranks) { -./test/unit/eigensolver/test_tridiag_solver_merge.cpp:122: constexpr std::array in_arr{1, 4, 2, 3, 0, 5, 6, 7, 8, 9}; Include for \bstd::declval\b: ./include/dlaf/eigensolver/tridiag_solver/impl.h:75: ex::ensure_started(cuppensDecompAsync(tridiag.readwrite(std::declval()), Include for \bstd::nullopt\b: @@ -16,7 +12,7 @@ Include for \bstd::pair\b: ./test/include/dlaf_c_test/c_api_helpers.h:65:std::pair top_left_tile(dlaf::matrix::Matrix& mat) { Include for \bstd::terminate\b: ./include/dlaf/memory/memory_chunk.h:72: std::terminate(); -./src/c_api/utils.cpp:62: std::terminate(); +./src/c_api/utils.cpp:63: std::terminate(); Include for \bstd::size_t\b: ./include/dlaf/common/data_descriptor.h:142:template ./include/dlaf/common/round_robin.h:27: RoundRobin(std::size_t n, Args... args) { @@ -42,7 +38,7 @@ Include for \bstd::size_t\b: ./include/dlaf/solver/triangular/impl.h:492: constexpr std::size_t n_workspaces = 2; ./include/dlaf/tune.h:81: red2band_panel_nworkers = std::max(1, default_pool_thread_count / 2); ./include/dlaf/util_matrix.h:155: getter_random(SizeType seed) : random_engine_(static_cast(seed)) { -./miniapp/include/dlaf/miniapp/options.h:163: for (std::size_t i = 0; i < valid_values.size(); ++i) { +./miniapp/include/dlaf/miniapp/options.h:164: for (std::size_t i = 0; i < valid_values.size(); ++i) { ./src/communication/communicator_grid.cpp:19: common::Ordering ordering, std::size_t npipelines) { ./src/init.cpp:69:void initializeGpuPool(int device, std::size_t num_np_streams, std::size_t num_hp_streams) { ./src/memory/memory_chunk.cpp:37:void initializeUmpireHostAllocator(std::size_t initial_bytes) { @@ -50,10 +46,10 @@ Include for \bstd::size_t\b: ./test/include/dlaf_test/matrix/matrix_local.h:123: std::size_t tileLinearIndex(const GlobalTileIndex& index) const noexcept { ./test/include/dlaf_test/matrix/util_matrix_local.h:54: const auto linear_size = static_cast(source.size().rows() * source.size().cols()); ./test/include/dlaf_test/matrix/util_matrix_senders.h:39: result.reserve(static_cast(dist.localNrTiles().linear_size())); -./test/src/gtest_mpi_listener.cpp:88: return last_test_part_results_[static_cast(index)]; +./test/src/gtest_mpi_listener.cpp:89: return last_test_part_results_[static_cast(index)]; ./test/unit/common/test_data_descriptor.cpp:46: return {std::make_unique(static_cast(blocksize)), num_blocks, blocksize, stride}; ./test/unit/communication/test_comm_sender.cpp:37: std::vector send_buf(static_cast(size), rank); -./test/unit/communication/test_communicator_grid.cpp:214: const std::vector test_npipelines{1, 3, 10}; +./test/unit/communication/test_communicator_grid.cpp:215: const std::vector test_npipelines{1, 3, 10}; ./test/unit/init/test_init.cpp:92: const std::size_t default_val = default_cfg.num_hp_gpu_streams_per_thread; ./test/unit/matrix/test_tile.cpp:389: const std::vector& specs, std::size_t last_dep, ./test/unit/permutations/test_permutations_distributed.cpp:75: const std::size_t nperms = to_sizet(i_end - i_begin); @@ -71,14 +67,14 @@ Include for \bstd::(c?ref)\b: Include for \bstd::(forward_as_|make_|)tuple\b: ./include/dlaf/eigensolver/tridiag_solver/impl.h:46: std::vector>& indices) { ./include/dlaf/permutations/general/impl.h:159: return std::tuple(std::move(splits), std::move(index_tile_futs), std::move(mat_in_tiles), -./src/c_api/utils.cpp:31:std::tuple distribution_and_layout( +./src/c_api/utils.cpp:32:std::tuple distribution_and_layout( ./src/c_api/utils.h:15:std::tuple distribution_and_layout( ./test/unit/eigensolver/test_tridiag_solver_distributed.cpp:50:const std::vector> tested_problems = { ./test/unit/eigensolver/test_tridiag_solver_local.cpp:42: std::vector> expected_indices{{0, 1, 2}, {0, 2, 3}, ./test/unit/lapack/gpu/test_lacpy.cpp:32:std::vector> configs{ ./test/unit/matrix/test_distribution.cpp:192:std::tuple test_tile_size(const ParametersConstructor& test) { ./test/unit/matrix/test_layout_info.cpp:20:const std::vector> -./test/unit/matrix/test_matrix.cpp:743: return std::tuple(std::move(rosenders2a), std::move(rosenders2b), std::move(senders3)); +./test/unit/matrix/test_matrix.cpp:744: return std::tuple(std::move(rosenders2a), std::move(rosenders2b), std::move(senders3)); ./test/unit/matrix/test_matrix_hdf5.cpp:77: return std::make_tuple(std::move(matrix), std::move(original_values)); ./test/unit/matrix/test_retiled_matrix.cpp:49:const std::vector> local_sizes_tests({ ./test/unit/matrix/test_tile.cpp:45:using TileSizes = std::tuple; @@ -94,7 +90,7 @@ Include for \bstd::make_pair\b: ./test/include/dlaf_c_test/c_api_helpers.h:81: return std::make_pair(local_ptr, lld); Include for \bstd::(cin|cout|cerr|clog)\b: ./include/dlaf/matrix/print_csv.h:33:void print(format::csv, const Tile& tile, std::ostream& os = std::cout) { -./include/dlaf/matrix/print_numpy.h:68:void print(format::numpy, const Tile& tile, std::ostream& os = std::cout) { +./include/dlaf/matrix/print_numpy.h:69:void print(format::numpy, const Tile& tile, std::ostream& os = std::cout) { ./include/dlaf/memory/memory_chunk.h:70: std::cout ./miniapp/kernel/miniapp_laset.cpp:107: std::cout << "[" << run_index << "]" ./src/c_api/grid.cpp:63: std::cerr << "Grid layout must be row major or column major." << std::endl; @@ -124,18 +120,18 @@ Include for \bstd::vector\b: ./include/dlaf/eigensolver/tridiag_solver/rot.h:266: mb](std::vector> rots, std::vector> tiles, ./include/dlaf/matrix/tile.h:540:std::vector> splitTile(ReadOnlyTileSender tile, ./include/dlaf/permutations/general/impl.h:98: const SizeType i_perm, const std::vector& splits, const GlobalElementIndex out_begin, -./miniapp/include/dlaf/miniapp/options.h:154: const std::vector& valid_values) { +./miniapp/include/dlaf/miniapp/options.h:155: const std::vector& valid_values) { ./src/permutations/general/perms.cu:40: const std::vector>& tiles) { ./test/include/dlaf_test/comm_grids/grids_6_ranks.h:21:std::vector comm_grids; ./test/include/dlaf_test/matrix/matrix_local.h:134: std::vector> tiles_; -./test/src/gtest_mpi_listener.cpp:184: std::vector message_buffer(static_cast(message_length)); +./test/src/gtest_mpi_listener.cpp:185: std::vector message_buffer(static_cast(message_length)); ./test/unit/auxiliary/mc/test_norm.cpp:44:const std::vector lapack_norms({lapack::Norm::Fro, lapack::Norm::Inf, lapack::Norm::Max, ./test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp:58:const std::vector blas_uplos({blas::Uplo::Lower}); ./test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp:56:const std::vector blas_uplos({blas::Uplo::Lower}); ./test/unit/c_api/factorization/test_cholesky_c_api.cpp:52:const std::vector blas_uplos({blas::Uplo::Lower, blas::Uplo::Upper}); ./test/unit/common/test_data_descriptor.cpp:701: std::vector> memory_types; ./test/unit/communication/test_broadcast_panel.cpp:50:std::vector test_params{ -./test/unit/communication/test_communicator_grid.cpp:214: const std::vector test_npipelines{1, 3, 10}; +./test/unit/communication/test_communicator_grid.cpp:215: const std::vector test_npipelines{1, 3, 10}; ./test/unit/eigensolver/test_band_to_tridiag.cpp:50:const std::vector> sizes = { ./test/unit/eigensolver/test_bt_band_to_tridiag.cpp:253:std::vector configs{ ./test/unit/eigensolver/test_eigensolver.cpp:61:const std::vector blas_uplos({blas::Uplo::Lower}); @@ -144,7 +140,7 @@ Include for \bstd::vector\b: ./test/unit/eigensolver/test_reduction_to_band.cpp:82:std::vector configs{ ./test/unit/eigensolver/test_tridiag_solver_distributed.cpp:50:const std::vector> tested_problems = { ./test/unit/eigensolver/test_tridiag_solver_local.cpp:42: std::vector> expected_indices{{0, 1, 2}, {0, 2, 3}, -./test/unit/eigensolver/test_tridiag_solver_merge.cpp:70: std::vector vec_arr{7, 2, 4, 8, 12, 1, 17, 32, 9, 6}; +./test/unit/eigensolver/test_tridiag_solver_merge.cpp:71: std::vector vec_arr{7, 2, 4, 8, 12, 1, 17, 32, 9, 6}; ./test/unit/eigensolver/test_tridiag_solver_rot.cpp:50: std::vector rots; ./test/unit/factorization/test_cholesky.cpp:51:const std::vector blas_uplos({blas::Uplo::Lower, blas::Uplo::Upper}); ./test/unit/factorization/test_compute_t_factor.cpp:207:std::vector> configs{ @@ -165,22 +161,11 @@ Include for \bstd::vector\b: ./test/unit/test_blas_tile_extensions.cpp:37:std::vector> scal_sizes = { ./test/unit/test_lapack_tile.cpp:29:const std::vector blas_diags({blas::Diag::Unit, blas::Diag::NonUnit}); ./test/unit/test_util_math.cpp:231: std::vector splits = util::interleaveSplits(l, b, o1, o2); -Include for \bstd::string\b: -./miniapp/miniapp_communication.cpp:94:std::string string_default(std::string name, Device D) { -./miniapp/miniapp_triangular_multiplication.cpp:66: side(dlaf::miniapp::parseSide(vm["side"].as())), Include for \bstd::setprecision\b: ./include/dlaf/matrix/print_csv.h:36: os << std::setprecision(5) << tile({ii, jj}) << ","; Include for \bstd::is_same\b: ./src/eigensolver/tridiag_solver/gpu/kernels.cu:34: if constexpr (std::is_same::value) { ./test/unit/test_util_math.cpp:34: EXPECT_TRUE((std::is_same())); -Include for \bstd::((i|o)?stringstream)\b: -./include/dlaf/matrix/print_numpy.h:48: std::ostringstream os; -./miniapp/include/dlaf/miniapp/options.h:162: std::ostringstream valid_values_stream; -./miniapp/miniapp_communication.cpp:95: std::stringstream s; -./src/c_api/utils.cpp:56: std::stringstream ss; -./test/src/gtest_mpi_listener.cpp:64: std::ostringstream os; -./test/unit/common/test_size2d.cpp:94: std::stringstream s; -./test/unit/matrix/test_matrix.cpp:354: std::stringstream s; \ -Found 162 violation(s) \ No newline at end of file +Found 150 violation(s) \ No newline at end of file diff --git a/miniapp/include/dlaf/miniapp/options.h b/miniapp/include/dlaf/miniapp/options.h index 5de4e97213..8ebd782891 100644 --- a/miniapp/include/dlaf/miniapp/options.h +++ b/miniapp/include/dlaf/miniapp/options.h @@ -14,6 +14,7 @@ #include #include #include +#include #include #include diff --git a/miniapp/miniapp_communication.cpp b/miniapp/miniapp_communication.cpp index 762cba562e..dd147d6d26 100644 --- a/miniapp/miniapp_communication.cpp +++ b/miniapp/miniapp_communication.cpp @@ -10,6 +10,8 @@ #include #include +#include +#include #include #include diff --git a/miniapp/miniapp_triangular_multiplication.cpp b/miniapp/miniapp_triangular_multiplication.cpp index 1341121d03..006dd65eb9 100644 --- a/miniapp/miniapp_triangular_multiplication.cpp +++ b/miniapp/miniapp_triangular_multiplication.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include #include diff --git a/src/c_api/utils.cpp b/src/c_api/utils.cpp index 3aa256461b..0456082658 100644 --- a/src/c_api/utils.cpp +++ b/src/c_api/utils.cpp @@ -9,6 +9,7 @@ // #include +#include #include #include diff --git a/test/src/gtest_mpi_listener.cpp b/test/src/gtest_mpi_listener.cpp index ad29532dcf..e0f6d8c5f5 100644 --- a/test/src/gtest_mpi_listener.cpp +++ b/test/src/gtest_mpi_listener.cpp @@ -10,6 +10,7 @@ #include #include +#include #include #include diff --git a/test/unit/common/test_size2d.cpp b/test/unit/common/test_size2d.cpp index cab07eccc1..a630bcfef6 100644 --- a/test/unit/common/test_size2d.cpp +++ b/test/unit/common/test_size2d.cpp @@ -9,6 +9,7 @@ // #include +#include #include diff --git a/test/unit/communication/test_communicator_grid.cpp b/test/unit/communication/test_communicator_grid.cpp index b051169f64..ae622c215b 100644 --- a/test/unit/communication/test_communicator_grid.cpp +++ b/test/unit/communication/test_communicator_grid.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include diff --git a/test/unit/eigensolver/test_tridiag_solver_merge.cpp b/test/unit/eigensolver/test_tridiag_solver_merge.cpp index dadce0734b..1f86738534 100644 --- a/test/unit/eigensolver/test_tridiag_solver_merge.cpp +++ b/test/unit/eigensolver/test_tridiag_solver_merge.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include #include diff --git a/test/unit/matrix/test_matrix.cpp b/test/unit/matrix/test_matrix.cpp index 8afb342e2f..b2d6e759d7 100644 --- a/test/unit/matrix/test_matrix.cpp +++ b/test/unit/matrix/test_matrix.cpp @@ -10,6 +10,7 @@ #include #include +#include #include #include From f39982b4ecf17e77a7859333d94a4b48e15463c3 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Thu, 18 Apr 2024 12:44:49 +0200 Subject: [PATCH 12/62] aa #include in 9 files --- include/dlaf/communication/kernels/internal/all_reduce.h | 1 + include/dlaf/communication/kernels/internal/broadcast.h | 1 + include/dlaf/communication/kernels/internal/p2p.h | 1 + include/dlaf/communication/kernels/internal/reduce.h | 1 + include/dlaf/sender/with_temporary_tile.h | 1 + inshpect.output | 9 +-------- test/unit/sender/test_with_temporary_tile.cpp | 1 + 7 files changed, 7 insertions(+), 8 deletions(-) diff --git a/include/dlaf/communication/kernels/internal/all_reduce.h b/include/dlaf/communication/kernels/internal/all_reduce.h index 78d91fed2d..6ba6be7693 100644 --- a/include/dlaf/communication/kernels/internal/all_reduce.h +++ b/include/dlaf/communication/kernels/internal/all_reduce.h @@ -11,6 +11,7 @@ #pragma once #include +#include #include #include diff --git a/include/dlaf/communication/kernels/internal/broadcast.h b/include/dlaf/communication/kernels/internal/broadcast.h index bc615d549f..aab56c910a 100644 --- a/include/dlaf/communication/kernels/internal/broadcast.h +++ b/include/dlaf/communication/kernels/internal/broadcast.h @@ -11,6 +11,7 @@ #pragma once #include +#include #include #include diff --git a/include/dlaf/communication/kernels/internal/p2p.h b/include/dlaf/communication/kernels/internal/p2p.h index fb4d2bdae4..d2672b0d0d 100644 --- a/include/dlaf/communication/kernels/internal/p2p.h +++ b/include/dlaf/communication/kernels/internal/p2p.h @@ -13,6 +13,7 @@ /// @file #include +#include #include #include diff --git a/include/dlaf/communication/kernels/internal/reduce.h b/include/dlaf/communication/kernels/internal/reduce.h index 76bd154560..bd8fa8d1f7 100644 --- a/include/dlaf/communication/kernels/internal/reduce.h +++ b/include/dlaf/communication/kernels/internal/reduce.h @@ -11,6 +11,7 @@ #pragma once #include +#include #include #include diff --git a/include/dlaf/sender/with_temporary_tile.h b/include/dlaf/sender/with_temporary_tile.h index 80d2bc81f1..476b885de8 100644 --- a/include/dlaf/sender/with_temporary_tile.h +++ b/include/dlaf/sender/with_temporary_tile.h @@ -10,6 +10,7 @@ #pragma once +#include #include #include diff --git a/inshpect.output b/inshpect.output index c4044ed427..d9ca4170e1 100644 --- a/inshpect.output +++ b/inshpect.output @@ -57,13 +57,6 @@ Include for \bstd::swap\b: ./include/dlaf/common/index2d.h:107: std::swap(row_, col_); ./include/dlaf/util_math.h:47: std::swap(small, big); ./miniapp/kernel/miniapp_laset.cpp:57: std::swap(m, n); -Include for \bstd::(c?ref)\b: -./include/dlaf/communication/kernels/internal/all_reduce.h:72: return whenAllLift(std::move(pcomm), reduce_op, std::cref(tile_in_comm), -./include/dlaf/communication/kernels/internal/broadcast.h:58: return whenAllLift(std::move(pcomm), std::cref(tile_comm)) | transformMPI(sendBcast_o); -./include/dlaf/communication/kernels/internal/p2p.h:62: return whenAllLift(std::move(pcomm), dest, tag, std::cref(tile_comm)) | transformMPI(send_o); -./include/dlaf/communication/kernels/internal/reduce.h:80: return whenAllLift(std::move(pcomm), reduce_op, std::cref(tile_comm)) | -./include/dlaf/sender/with_temporary_tile.h:126: return ex::just(std::cref(in)) | -./test/unit/sender/test_with_temporary_tile.cpp:114: ex::just(std::cref(temp)) | Include for \bstd::(forward_as_|make_|)tuple\b: ./include/dlaf/eigensolver/tridiag_solver/impl.h:46: std::vector>& indices) { ./include/dlaf/permutations/general/impl.h:159: return std::tuple(std::move(splits), std::move(index_tile_futs), std::move(mat_in_tiles), @@ -168,4 +161,4 @@ Include for \bstd::is_same\b: ./test/unit/test_util_math.cpp:34: EXPECT_TRUE((std::is_same())); -Found 150 violation(s) \ No newline at end of file +Found 144 violation(s) \ No newline at end of file diff --git a/test/unit/sender/test_with_temporary_tile.cpp b/test/unit/sender/test_with_temporary_tile.cpp index cd48c0d5bc..fa9f8f6350 100644 --- a/test/unit/sender/test_with_temporary_tile.cpp +++ b/test/unit/sender/test_with_temporary_tile.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include From faabe04166581c03ecb5f17411f905ba295fa5b3 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Thu, 18 Apr 2024 12:54:50 +0200 Subject: [PATCH 13/62] add last #include --- include/dlaf/common/callable_object.h | 2 + include/dlaf/common/index2d.h | 1 + include/dlaf/communication/broadcast_panel.h | 1 + include/dlaf/communication/sync/basic.h | 2 + include/dlaf/eigensolver/gen_to_std/impl.h | 3 ++ .../dlaf/eigensolver/tridiag_solver/impl.h | 1 + .../tridiag_solver/tile_collector.h | 2 + include/dlaf/factorization/cholesky/impl.h | 3 ++ include/dlaf/multiplication/hermitian/impl.h | 3 ++ include/dlaf/multiplication/triangular/impl.h | 3 ++ include/dlaf/solver/triangular/impl.h | 3 ++ include/dlaf/util_math.h | 1 + inshpect.output | 46 ++++--------------- miniapp/include/dlaf/miniapp/kernel_runner.h | 2 + miniapp/kernel/miniapp_laset.cpp | 1 + test/include/dlaf_c_test/c_api_helpers.h | 2 + test/include/dlaf_test/blas/invoke.h | 2 + test/include/dlaf_test/lapack/invoke.h | 2 + test/unit/communication/test_comm_p2p.cpp | 2 + test/unit/init/test_init.cpp | 1 + 20 files changed, 47 insertions(+), 36 deletions(-) diff --git a/include/dlaf/common/callable_object.h b/include/dlaf/common/callable_object.h index b167e8a63e..d40ae2e2d3 100644 --- a/include/dlaf/common/callable_object.h +++ b/include/dlaf/common/callable_object.h @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #pragma once /// @file diff --git a/include/dlaf/common/index2d.h b/include/dlaf/common/index2d.h index 59bf55efd2..42677666ba 100644 --- a/include/dlaf/common/index2d.h +++ b/include/dlaf/common/index2d.h @@ -17,6 +17,7 @@ #include #include #include +#include #include #include diff --git a/include/dlaf/communication/broadcast_panel.h b/include/dlaf/communication/broadcast_panel.h index ce465c49e2..e83e35a98d 100644 --- a/include/dlaf/communication/broadcast_panel.h +++ b/include/dlaf/communication/broadcast_panel.h @@ -13,6 +13,7 @@ /// @file #include +#include #include diff --git a/include/dlaf/communication/sync/basic.h b/include/dlaf/communication/sync/basic.h index 4cf7e1b547..833a915006 100644 --- a/include/dlaf/communication/sync/basic.h +++ b/include/dlaf/communication/sync/basic.h @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #pragma once /// @file diff --git a/include/dlaf/eigensolver/gen_to_std/impl.h b/include/dlaf/eigensolver/gen_to_std/impl.h index df04ce281f..83781e2267 100644 --- a/include/dlaf/eigensolver/gen_to_std/impl.h +++ b/include/dlaf/eigensolver/gen_to_std/impl.h @@ -7,6 +7,9 @@ // Please, refer to the LICENSE file in the root directory. // SPDX-License-Identifier: BSD-3-Clause // + +#include + #pragma once #include diff --git a/include/dlaf/eigensolver/tridiag_solver/impl.h b/include/dlaf/eigensolver/tridiag_solver/impl.h index fb6c584f4c..88fb0bff39 100644 --- a/include/dlaf/eigensolver/tridiag_solver/impl.h +++ b/include/dlaf/eigensolver/tridiag_solver/impl.h @@ -10,6 +10,7 @@ #pragma once #include +#include #include #include diff --git a/include/dlaf/eigensolver/tridiag_solver/tile_collector.h b/include/dlaf/eigensolver/tridiag_solver/tile_collector.h index 50a6cbc220..4cf19eb098 100644 --- a/include/dlaf/eigensolver/tridiag_solver/tile_collector.h +++ b/include/dlaf/eigensolver/tridiag_solver/tile_collector.h @@ -9,6 +9,8 @@ // #pragma once +#include + #include #include #include diff --git a/include/dlaf/factorization/cholesky/impl.h b/include/dlaf/factorization/cholesky/impl.h index 0834682d4e..1b698a2da1 100644 --- a/include/dlaf/factorization/cholesky/impl.h +++ b/include/dlaf/factorization/cholesky/impl.h @@ -7,6 +7,9 @@ // Please, refer to the LICENSE file in the root directory. // SPDX-License-Identifier: BSD-3-Clause // + +#include + #pragma once #include diff --git a/include/dlaf/multiplication/hermitian/impl.h b/include/dlaf/multiplication/hermitian/impl.h index fb522b8e33..992ba55862 100644 --- a/include/dlaf/multiplication/hermitian/impl.h +++ b/include/dlaf/multiplication/hermitian/impl.h @@ -7,6 +7,9 @@ // Please, refer to the LICENSE file in the root directory. // SPDX-License-Identifier: BSD-3-Clause // + +#include + #pragma once #include diff --git a/include/dlaf/multiplication/triangular/impl.h b/include/dlaf/multiplication/triangular/impl.h index 81629608ac..8d41c66e99 100644 --- a/include/dlaf/multiplication/triangular/impl.h +++ b/include/dlaf/multiplication/triangular/impl.h @@ -7,6 +7,9 @@ // Please, refer to the LICENSE file in the root directory. // SPDX-License-Identifier: BSD-3-Clause // + +#include + #pragma once #include diff --git a/include/dlaf/solver/triangular/impl.h b/include/dlaf/solver/triangular/impl.h index 6353650385..87e455b659 100644 --- a/include/dlaf/solver/triangular/impl.h +++ b/include/dlaf/solver/triangular/impl.h @@ -7,6 +7,9 @@ // Please, refer to the LICENSE file in the root directory. // SPDX-License-Identifier: BSD-3-Clause // + +#include + #pragma once #include diff --git a/include/dlaf/util_math.h b/include/dlaf/util_math.h index 411089e908..d26e0ba527 100644 --- a/include/dlaf/util_math.h +++ b/include/dlaf/util_math.h @@ -13,6 +13,7 @@ #include #include #include +#include #include #include diff --git a/inshpect.output b/inshpect.output index d9ca4170e1..3f6d8b5998 100644 --- a/inshpect.output +++ b/inshpect.output @@ -1,15 +1,10 @@ # Includes -Include for \bstd::declval\b: -./include/dlaf/eigensolver/tridiag_solver/impl.h:75: ex::ensure_started(cuppensDecompAsync(tridiag.readwrite(std::declval()), Include for \bstd::nullopt\b: ./include/dlaf/common/pipeline.h:49: : pipeline(std::exchange(other.pipeline, std::nullopt)), ./include/dlaf/util_matrix.h:342: std::optional band_size = std::nullopt) { Include for \bstd::is_floating_point\b: ./include/dlaf/types.h:145:struct IsFloatingPointOrComplex : std::is_floating_point {}; -Include for \bstd::pair\b: -./include/dlaf/communication/broadcast_panel.h:38:std::pair transposedOwner(const matrix::Distribution& dist, -./test/include/dlaf_c_test/c_api_helpers.h:65:std::pair top_left_tile(dlaf::matrix::Matrix& mat) { Include for \bstd::terminate\b: ./include/dlaf/memory/memory_chunk.h:72: std::terminate(); ./src/c_api/utils.cpp:63: std::terminate(); @@ -20,22 +15,22 @@ Include for \bstd::size_t\b: ./include/dlaf/eigensolver/band_to_tridiag/mc.h:1155: constexpr std::size_t n_workspaces = 4; ./include/dlaf/eigensolver/bt_band_to_tridiag/impl.h:509: HHManager(const SizeType b, const std::size_t, matrix::Distribution, matrix::Distribution) : b(b) {} ./include/dlaf/eigensolver/bt_reduction_to_band/impl.h:155: constexpr std::size_t n_workspaces = 2; -./include/dlaf/eigensolver/gen_to_std/impl.h:292: constexpr std::size_t n_workspaces = 2; +./include/dlaf/eigensolver/gen_to_std/impl.h:295: constexpr std::size_t n_workspaces = 2; ./include/dlaf/eigensolver/internal/get_red2band_panel_nworkers.h:23: const std::size_t available_workers = pika::resource::get_thread_pool("default").get_os_thread_count(); ./include/dlaf/eigensolver/internal/get_tridiag_rank1_nworkers.h:21:inline std::size_t getTridiagRank1NWorkers() noexcept { ./include/dlaf/eigensolver/tridiag_solver/merge.h:269:inline std::size_t ev_sort_order(const ColType coltype) { ./include/dlaf/eigensolver/tridiag_solver/rot.h:290: const std::size_t linear_tile_col = to_sizet(dist_sub.localTileLinearIndex(tile_col)); -./include/dlaf/factorization/cholesky/impl.h:195: constexpr std::size_t n_workspaces = 2; +./include/dlaf/factorization/cholesky/impl.h:198: constexpr std::size_t n_workspaces = 2; ./include/dlaf/init.h:37: std::size_t num_np_gpu_streams_per_thread = 3; ./include/dlaf/matrix/copy_tile.h:83: const std::size_t m = to_sizet(source.size().rows()); ./include/dlaf/matrix/hdf5.h:42: static constexpr std::size_t dims = 1; ./include/dlaf/matrix/matrix.h:386: for (std::size_t i = 0; i < n; ++i) { ./include/dlaf/memory/memory_chunk.h:27:void initializeUmpireHostAllocator(std::size_t initial_bytes); ./include/dlaf/multiplication/general/impl.h:89: constexpr std::size_t n_workspaces = 2; -./include/dlaf/multiplication/hermitian/impl.h:112: constexpr std::size_t n_workspaces = 2; -./include/dlaf/multiplication/triangular/impl.h:414: constexpr std::size_t n_workspaces = 2; +./include/dlaf/multiplication/hermitian/impl.h:115: constexpr std::size_t n_workspaces = 2; +./include/dlaf/multiplication/triangular/impl.h:417: constexpr std::size_t n_workspaces = 2; ./include/dlaf/permutations/general/impl.h:104: for (std::size_t i_split = 0; i_split < splits.size() - 1; ++i_split) { -./include/dlaf/solver/triangular/impl.h:492: constexpr std::size_t n_workspaces = 2; +./include/dlaf/solver/triangular/impl.h:495: constexpr std::size_t n_workspaces = 2; ./include/dlaf/tune.h:81: red2band_panel_nworkers = std::max(1, default_pool_thread_count / 2); ./include/dlaf/util_matrix.h:155: getter_random(SizeType seed) : random_engine_(static_cast(seed)) { ./miniapp/include/dlaf/miniapp/options.h:164: for (std::size_t i = 0; i < valid_values.size(); ++i) { @@ -50,15 +45,11 @@ Include for \bstd::size_t\b: ./test/unit/common/test_data_descriptor.cpp:46: return {std::make_unique(static_cast(blocksize)), num_blocks, blocksize, stride}; ./test/unit/communication/test_comm_sender.cpp:37: std::vector send_buf(static_cast(size), rank); ./test/unit/communication/test_communicator_grid.cpp:215: const std::vector test_npipelines{1, 3, 10}; -./test/unit/init/test_init.cpp:92: const std::size_t default_val = default_cfg.num_hp_gpu_streams_per_thread; +./test/unit/init/test_init.cpp:93: const std::size_t default_val = default_cfg.num_hp_gpu_streams_per_thread; ./test/unit/matrix/test_tile.cpp:389: const std::vector& specs, std::size_t last_dep, ./test/unit/permutations/test_permutations_distributed.cpp:75: const std::size_t nperms = to_sizet(i_end - i_begin); -Include for \bstd::swap\b: -./include/dlaf/common/index2d.h:107: std::swap(row_, col_); -./include/dlaf/util_math.h:47: std::swap(small, big); -./miniapp/kernel/miniapp_laset.cpp:57: std::swap(m, n); Include for \bstd::(forward_as_|make_|)tuple\b: -./include/dlaf/eigensolver/tridiag_solver/impl.h:46: std::vector>& indices) { +./include/dlaf/eigensolver/tridiag_solver/impl.h:47: std::vector>& indices) { ./include/dlaf/permutations/general/impl.h:159: return std::tuple(std::move(splits), std::move(index_tile_futs), std::move(mat_in_tiles), ./src/c_api/utils.cpp:32:std::tuple distribution_and_layout( ./src/c_api/utils.h:15:std::tuple distribution_and_layout( @@ -77,38 +68,21 @@ Include for \bstd::(forward_as_|make_|)tuple\b: ./test/unit/test_blas_tile.cpp:47:std::vector> gemm_sizes = { ./test/unit/test_blas_tile_extensions.cpp:37:std::vector> scal_sizes = { ./test/unit/test_lapack_tile.cpp:55:std::vector> hegst_sizes = { -Include for \bstd::make_pair\b: -./include/dlaf/communication/broadcast_panel.h:42: return std::make_pair(idx_cross, rank_owner); -./include/dlaf/eigensolver/tridiag_solver/tile_collector.h:44: return std::make_pair(begin, size); -./test/include/dlaf_c_test/c_api_helpers.h:81: return std::make_pair(local_ptr, lld); Include for \bstd::(cin|cout|cerr|clog)\b: ./include/dlaf/matrix/print_csv.h:33:void print(format::csv, const Tile& tile, std::ostream& os = std::cout) { ./include/dlaf/matrix/print_numpy.h:69:void print(format::numpy, const Tile& tile, std::ostream& os = std::cout) { ./include/dlaf/memory/memory_chunk.h:70: std::cout -./miniapp/kernel/miniapp_laset.cpp:107: std::cout << "[" << run_index << "]" +./miniapp/kernel/miniapp_laset.cpp:108: std::cout << "[" << run_index << "]" ./src/c_api/grid.cpp:63: std::cerr << "Grid layout must be row major or column major." << std::endl; ./test/include/dlaf_test/matrix/util_matrix_local.h:140: std::ostream& os = std::cout) { ./test/unit/common/test_data_descriptor.cpp:79: std::cout << "Unknown memory type" << std::endl; Include for \bstd::atomic\b: ./test/include/dlaf_test/matrix/util_tile.h:49: : ready(std::make_shared>(false)), -Include for \bstd::forward\b: -./include/dlaf/common/callable_object.h:29: auto operator()(Ts&&... ts) const noexcept(noexcept((fname) (std::forward(ts)...))) \ -./include/dlaf/communication/sync/basic.h:30: auto message = make_message(common::make_data(std::forward(data))); -./include/dlaf/eigensolver/gen_to_std/impl.h:39: dlaf::internal::whenAllLift(1, blas::Uplo::Lower, std::forward(a_kk), -./include/dlaf/factorization/cholesky/impl.h:41: dlaf::internal::whenAllLift(blas::Uplo::Lower, std::forward(matrix_tile)) | -./include/dlaf/multiplication/hermitian/impl.h:39: std::forward(a_tile), std::forward(b_tile), beta, -./include/dlaf/multiplication/triangular/impl.h:40: std::forward(in_tile), std::forward(out_tile)) | -./include/dlaf/solver/triangular/impl.h:43: std::forward(in_tile), std::forward(out_tile)) | -./miniapp/include/dlaf/miniapp/kernel_runner.h:87: return runInternal(std::forward(kernel_task), streams_); -./test/include/dlaf_test/blas/invoke.h:34: f(std::forward(args)...); -./test/include/dlaf_test/lapack/invoke.h:34: f(std::forward(args)...); -./test/unit/communication/test_comm_p2p.cpp:60: std::forward(tile)) | -./test/unit/init/test_init.cpp:47: init_ = std::make_unique(std::forward(args)...); Include for \bstd::vector\b: ./include/dlaf/auxiliary/norm/mc.h:80: auto max_element = [](std::vector&& values) { ./include/dlaf/eigensolver/band_to_tridiag/mc.h:696: using TileVector = std::vector>; ./include/dlaf/eigensolver/bt_band_to_tridiag/impl.h:108: std::vector taus; -./include/dlaf/eigensolver/tridiag_solver/impl.h:46: std::vector>& indices) { +./include/dlaf/eigensolver/tridiag_solver/impl.h:47: std::vector>& indices) { ./include/dlaf/eigensolver/tridiag_solver/merge.h:224: std::vector> tiles_max; ./include/dlaf/eigensolver/tridiag_solver/rot.h:266: mb](std::vector> rots, std::vector> tiles, ./include/dlaf/matrix/tile.h:540:std::vector> splitTile(ReadOnlyTileSender tile, @@ -161,4 +135,4 @@ Include for \bstd::is_same\b: ./test/unit/test_util_math.cpp:34: EXPECT_TRUE((std::is_same())); -Found 144 violation(s) \ No newline at end of file +Found 123 violation(s) \ No newline at end of file diff --git a/miniapp/include/dlaf/miniapp/kernel_runner.h b/miniapp/include/dlaf/miniapp/kernel_runner.h index 99ae9ebf97..d07459496b 100644 --- a/miniapp/include/dlaf/miniapp/kernel_runner.h +++ b/miniapp/include/dlaf/miniapp/kernel_runner.h @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #pragma once #ifdef DLAF_WITH_GPU diff --git a/miniapp/kernel/miniapp_laset.cpp b/miniapp/kernel/miniapp_laset.cpp index 8d246f3f81..3549757315 100644 --- a/miniapp/kernel/miniapp_laset.cpp +++ b/miniapp/kernel/miniapp_laset.cpp @@ -10,6 +10,7 @@ #include #include +#include #ifdef DLAF_WITH_GPU #include diff --git a/test/include/dlaf_c_test/c_api_helpers.h b/test/include/dlaf_c_test/c_api_helpers.h index 9806276dcf..312bb18127 100644 --- a/test/include/dlaf_c_test/c_api_helpers.h +++ b/test/include/dlaf_c_test/c_api_helpers.h @@ -10,6 +10,8 @@ #pragma once +#include + #include #include diff --git a/test/include/dlaf_test/blas/invoke.h b/test/include/dlaf_test/blas/invoke.h index 0962f7b8c4..8143eb4370 100644 --- a/test/include/dlaf_test/blas/invoke.h +++ b/test/include/dlaf_test/blas/invoke.h @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #pragma once #ifdef DLAF_WITH_GPU diff --git a/test/include/dlaf_test/lapack/invoke.h b/test/include/dlaf_test/lapack/invoke.h index 211fd5bbf0..1484e3ce31 100644 --- a/test/include/dlaf_test/lapack/invoke.h +++ b/test/include/dlaf_test/lapack/invoke.h @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #pragma once #ifdef DLAF_WITH_GPU diff --git a/test/unit/communication/test_comm_p2p.cpp b/test/unit/communication/test_comm_p2p.cpp index 13c38fc744..f84643db33 100644 --- a/test/unit/communication/test_comm_p2p.cpp +++ b/test/unit/communication/test_comm_p2p.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include #include diff --git a/test/unit/init/test_init.cpp b/test/unit/init/test_init.cpp index 29a068e5e6..9dab21a991 100644 --- a/test/unit/init/test_init.cpp +++ b/test/unit/init/test_init.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include From 4a856c33af834239788d8559d8452e118b01512f Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Thu, 18 Apr 2024 12:58:07 +0200 Subject: [PATCH 14/62] add #include in 4 files --- include/dlaf/matrix/print_csv.h | 3 +++ inshpect.output | 11 +++-------- src/eigensolver/tridiag_solver/gpu/kernels.cu | 2 ++ test/unit/test_util_math.cpp | 1 + 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/include/dlaf/matrix/print_csv.h b/include/dlaf/matrix/print_csv.h index e27c236dce..03df775b2e 100644 --- a/include/dlaf/matrix/print_csv.h +++ b/include/dlaf/matrix/print_csv.h @@ -7,6 +7,9 @@ // Please, refer to the LICENSE file in the root directory. // SPDX-License-Identifier: BSD-3-Clause // + +#include + #pragma once /// @file diff --git a/inshpect.output b/inshpect.output index 3f6d8b5998..e15a198480 100644 --- a/inshpect.output +++ b/inshpect.output @@ -69,7 +69,7 @@ Include for \bstd::(forward_as_|make_|)tuple\b: ./test/unit/test_blas_tile_extensions.cpp:37:std::vector> scal_sizes = { ./test/unit/test_lapack_tile.cpp:55:std::vector> hegst_sizes = { Include for \bstd::(cin|cout|cerr|clog)\b: -./include/dlaf/matrix/print_csv.h:33:void print(format::csv, const Tile& tile, std::ostream& os = std::cout) { +./include/dlaf/matrix/print_csv.h:36:void print(format::csv, const Tile& tile, std::ostream& os = std::cout) { ./include/dlaf/matrix/print_numpy.h:69:void print(format::numpy, const Tile& tile, std::ostream& os = std::cout) { ./include/dlaf/memory/memory_chunk.h:70: std::cout ./miniapp/kernel/miniapp_laset.cpp:108: std::cout << "[" << run_index << "]" @@ -127,12 +127,7 @@ Include for \bstd::vector\b: ./test/unit/test_blas_tile.cpp:26:const std::vector blas_diags({blas::Diag::Unit, blas::Diag::NonUnit}); ./test/unit/test_blas_tile_extensions.cpp:37:std::vector> scal_sizes = { ./test/unit/test_lapack_tile.cpp:29:const std::vector blas_diags({blas::Diag::Unit, blas::Diag::NonUnit}); -./test/unit/test_util_math.cpp:231: std::vector splits = util::interleaveSplits(l, b, o1, o2); -Include for \bstd::setprecision\b: -./include/dlaf/matrix/print_csv.h:36: os << std::setprecision(5) << tile({ii, jj}) << ","; -Include for \bstd::is_same\b: -./src/eigensolver/tridiag_solver/gpu/kernels.cu:34: if constexpr (std::is_same::value) { -./test/unit/test_util_math.cpp:34: EXPECT_TRUE((std::is_same())); +./test/unit/test_util_math.cpp:232: std::vector splits = util::interleaveSplits(l, b, o1, o2); -Found 123 violation(s) \ No newline at end of file +Found 120 violation(s) \ No newline at end of file diff --git a/src/eigensolver/tridiag_solver/gpu/kernels.cu b/src/eigensolver/tridiag_solver/gpu/kernels.cu index 6c93fa1baa..3ef6cf918d 100644 --- a/src/eigensolver/tridiag_solver/gpu/kernels.cu +++ b/src/eigensolver/tridiag_solver/gpu/kernels.cu @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include diff --git a/test/unit/test_util_math.cpp b/test/unit/test_util_math.cpp index 588be1369a..55db81c70a 100644 --- a/test/unit/test_util_math.cpp +++ b/test/unit/test_util_math.cpp @@ -10,6 +10,7 @@ #include #include +#include #include From 481135be50017bda9436463699a81bc54e6a08bd Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Thu, 18 Apr 2024 13:27:25 +0200 Subject: [PATCH 15/62] add #include in all files --- include/dlaf/auxiliary/norm/mc.h | 1 + include/dlaf/common/data_descriptor.h | 1 + include/dlaf/common/round_robin.h | 1 + .../dlaf/communication/communicator_grid.h | 1 + include/dlaf/eigensolver/band_to_tridiag/mc.h | 2 + .../eigensolver/bt_band_to_tridiag/impl.h | 2 + .../eigensolver/bt_reduction_to_band/impl.h | 1 + include/dlaf/eigensolver/gen_to_std/impl.h | 1 + .../internal/get_red2band_panel_nworkers.h | 1 + .../internal/get_tridiag_rank1_nworkers.h | 1 + .../dlaf/eigensolver/tridiag_solver/impl.h | 1 + .../dlaf/eigensolver/tridiag_solver/merge.h | 2 + include/dlaf/eigensolver/tridiag_solver/rot.h | 2 + include/dlaf/factorization/cholesky/impl.h | 1 + include/dlaf/init.h | 1 + include/dlaf/matrix/copy_tile.h | 1 + include/dlaf/matrix/hdf5.h | 1 + include/dlaf/matrix/matrix.h | 1 + include/dlaf/matrix/tile.h | 1 + include/dlaf/memory/memory_chunk.h | 1 + include/dlaf/multiplication/general/impl.h | 2 + include/dlaf/multiplication/hermitian/impl.h | 1 + include/dlaf/multiplication/triangular/impl.h | 1 + include/dlaf/permutations/general/impl.h | 2 + include/dlaf/solver/triangular/impl.h | 1 + include/dlaf/tune.h | 1 + include/dlaf/util_matrix.h | 1 + inshpect.output | 130 +++--------------- miniapp/include/dlaf/miniapp/options.h | 2 + src/communication/communicator_grid.cpp | 2 + src/init.cpp | 1 + src/memory/memory_chunk.cpp | 2 + src/permutations/general/perms.cu | 2 + .../dlaf_test/comm_grids/grids_6_ranks.h | 3 + test/include/dlaf_test/matrix/matrix_local.h | 2 + test/include/dlaf_test/matrix/util_matrix.h | 1 + .../dlaf_test/matrix/util_matrix_local.h | 1 + .../dlaf_test/matrix/util_matrix_senders.h | 1 + test/src/gtest_mpi_listener.cpp | 2 + test/unit/auxiliary/mc/test_norm.cpp | 1 + .../eigensolver/test_eigensolver_c_api.cpp | 1 + .../test_gen_eigensolver_c_api.cpp | 1 + .../factorization/test_cholesky_c_api.cpp | 1 + test/unit/common/test_data_descriptor.cpp | 2 + .../communication/test_broadcast_panel.cpp | 2 + test/unit/communication/test_comm_sender.cpp | 1 + .../communication/test_communicator_grid.cpp | 2 + .../unit/eigensolver/test_band_to_tridiag.cpp | 1 + .../eigensolver/test_bt_band_to_tridiag.cpp | 2 + test/unit/eigensolver/test_eigensolver.cpp | 1 + .../unit/eigensolver/test_gen_eigensolver.cpp | 1 + test/unit/eigensolver/test_gen_to_std.cpp | 1 + .../eigensolver/test_reduction_to_band.cpp | 1 + .../test_tridiag_solver_distributed.cpp | 1 + .../eigensolver/test_tridiag_solver_local.cpp | 1 + .../eigensolver/test_tridiag_solver_merge.cpp | 1 + .../eigensolver/test_tridiag_solver_rot.cpp | 2 + test/unit/factorization/test_cholesky.cpp | 1 + .../factorization/test_compute_t_factor.cpp | 1 + test/unit/init/test_init.cpp | 1 + test/unit/lapack/gpu/test_lacpy.cpp | 2 + test/unit/matrix/test_distribution.cpp | 1 + .../matrix/test_distribution_extensions.cpp | 1 + test/unit/matrix/test_layout_info.cpp | 2 + test/unit/matrix/test_tile.cpp | 2 + test/unit/matrix/test_util_distribution.cpp | 2 + test/unit/matrix/test_views.cpp | 1 + .../test_multiplication_general.cpp | 2 + .../test_multiplication_hermitian.cpp | 1 + .../test_multiplication_triangular.cpp | 1 + .../test_permutations_distributed.cpp | 2 + .../permutations/test_permutations_local.cpp | 2 + test/unit/solver/test_triangular.cpp | 1 + test/unit/test_blas_tile.cpp | 2 + test/unit/test_blas_tile_extensions.cpp | 2 + test/unit/test_lapack_tile.cpp | 1 + test/unit/test_util_math.cpp | 1 + 77 files changed, 124 insertions(+), 110 deletions(-) diff --git a/include/dlaf/auxiliary/norm/mc.h b/include/dlaf/auxiliary/norm/mc.h index 69130e98c1..b4c60286ef 100644 --- a/include/dlaf/auxiliary/norm/mc.h +++ b/include/dlaf/auxiliary/norm/mc.h @@ -10,6 +10,7 @@ #pragma once #include +#include #include #include diff --git a/include/dlaf/common/data_descriptor.h b/include/dlaf/common/data_descriptor.h index 87cfddc7cb..951a9c3d11 100644 --- a/include/dlaf/common/data_descriptor.h +++ b/include/dlaf/common/data_descriptor.h @@ -13,6 +13,7 @@ #pragma once #include +#include #include #include #include diff --git a/include/dlaf/common/round_robin.h b/include/dlaf/common/round_robin.h index d02924bf1e..4a430036a8 100644 --- a/include/dlaf/common/round_robin.h +++ b/include/dlaf/common/round_robin.h @@ -11,6 +11,7 @@ /// @file +#include #include #include diff --git a/include/dlaf/communication/communicator_grid.h b/include/dlaf/communication/communicator_grid.h index 6f6f033cb1..4099fb5945 100644 --- a/include/dlaf/communication/communicator_grid.h +++ b/include/dlaf/communication/communicator_grid.h @@ -13,6 +13,7 @@ #pragma once #include +#include #include #include diff --git a/include/dlaf/eigensolver/band_to_tridiag/mc.h b/include/dlaf/eigensolver/band_to_tridiag/mc.h index d314c88b37..439e4bef97 100644 --- a/include/dlaf/eigensolver/band_to_tridiag/mc.h +++ b/include/dlaf/eigensolver/band_to_tridiag/mc.h @@ -10,8 +10,10 @@ #pragma once +#include #include #include +#include #include #include diff --git a/include/dlaf/eigensolver/bt_band_to_tridiag/impl.h b/include/dlaf/eigensolver/bt_band_to_tridiag/impl.h index 8966a53792..850dc4e669 100644 --- a/include/dlaf/eigensolver/bt_band_to_tridiag/impl.h +++ b/include/dlaf/eigensolver/bt_band_to_tridiag/impl.h @@ -10,9 +10,11 @@ #pragma once +#include #include #include #include +#include #include #include diff --git a/include/dlaf/eigensolver/bt_reduction_to_band/impl.h b/include/dlaf/eigensolver/bt_reduction_to_band/impl.h index d56ea330b2..d268ab7158 100644 --- a/include/dlaf/eigensolver/bt_reduction_to_band/impl.h +++ b/include/dlaf/eigensolver/bt_reduction_to_band/impl.h @@ -9,6 +9,7 @@ // #pragma once +#include #include #include diff --git a/include/dlaf/eigensolver/gen_to_std/impl.h b/include/dlaf/eigensolver/gen_to_std/impl.h index 83781e2267..bc24cc9ea7 100644 --- a/include/dlaf/eigensolver/gen_to_std/impl.h +++ b/include/dlaf/eigensolver/gen_to_std/impl.h @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #pragma once diff --git a/include/dlaf/eigensolver/internal/get_red2band_panel_nworkers.h b/include/dlaf/eigensolver/internal/get_red2band_panel_nworkers.h index 1bf112b10f..f269232d18 100644 --- a/include/dlaf/eigensolver/internal/get_red2band_panel_nworkers.h +++ b/include/dlaf/eigensolver/internal/get_red2band_panel_nworkers.h @@ -10,6 +10,7 @@ #pragma once #include +#include #include #include diff --git a/include/dlaf/eigensolver/internal/get_tridiag_rank1_nworkers.h b/include/dlaf/eigensolver/internal/get_tridiag_rank1_nworkers.h index a3ab3d7569..8ab4269bbe 100644 --- a/include/dlaf/eigensolver/internal/get_tridiag_rank1_nworkers.h +++ b/include/dlaf/eigensolver/internal/get_tridiag_rank1_nworkers.h @@ -10,6 +10,7 @@ #pragma once #include +#include #include #include diff --git a/include/dlaf/eigensolver/tridiag_solver/impl.h b/include/dlaf/eigensolver/tridiag_solver/impl.h index 88fb0bff39..7bf1092621 100644 --- a/include/dlaf/eigensolver/tridiag_solver/impl.h +++ b/include/dlaf/eigensolver/tridiag_solver/impl.h @@ -11,6 +11,7 @@ #include #include +#include #include #include diff --git a/include/dlaf/eigensolver/tridiag_solver/merge.h b/include/dlaf/eigensolver/tridiag_solver/merge.h index d07fc56787..fbbb0832ad 100644 --- a/include/dlaf/eigensolver/tridiag_solver/merge.h +++ b/include/dlaf/eigensolver/tridiag_solver/merge.h @@ -11,10 +11,12 @@ #include #include +#include #include #include #include #include +#include #include #include diff --git a/include/dlaf/eigensolver/tridiag_solver/rot.h b/include/dlaf/eigensolver/tridiag_solver/rot.h index 52ddf1c17b..18adca31cb 100644 --- a/include/dlaf/eigensolver/tridiag_solver/rot.h +++ b/include/dlaf/eigensolver/tridiag_solver/rot.h @@ -13,7 +13,9 @@ #include #endif +#include #include +#include #include #include diff --git a/include/dlaf/factorization/cholesky/impl.h b/include/dlaf/factorization/cholesky/impl.h index 1b698a2da1..e8cc57a6d7 100644 --- a/include/dlaf/factorization/cholesky/impl.h +++ b/include/dlaf/factorization/cholesky/impl.h @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #pragma once diff --git a/include/dlaf/init.h b/include/dlaf/init.h index e2384b8439..c04ee0d947 100644 --- a/include/dlaf/init.h +++ b/include/dlaf/init.h @@ -11,6 +11,7 @@ /// @file +#include #include #include diff --git a/include/dlaf/matrix/copy_tile.h b/include/dlaf/matrix/copy_tile.h index 695c2963a4..64a887f5b9 100644 --- a/include/dlaf/matrix/copy_tile.h +++ b/include/dlaf/matrix/copy_tile.h @@ -12,6 +12,7 @@ /// @file +#include #include #include diff --git a/include/dlaf/matrix/hdf5.h b/include/dlaf/matrix/hdf5.h index 4e5b883f10..a63a144678 100644 --- a/include/dlaf/matrix/hdf5.h +++ b/include/dlaf/matrix/hdf5.h @@ -13,6 +13,7 @@ #ifdef DLAF_WITH_HDF5 #include +#include #include #include #include diff --git a/include/dlaf/matrix/matrix.h b/include/dlaf/matrix/matrix.h index a6d16b5f82..61d884d960 100644 --- a/include/dlaf/matrix/matrix.h +++ b/include/dlaf/matrix/matrix.h @@ -12,6 +12,7 @@ /// @file +#include #include #include #include diff --git a/include/dlaf/matrix/tile.h b/include/dlaf/matrix/tile.h index 917febaef0..95bba545d9 100644 --- a/include/dlaf/matrix/tile.h +++ b/include/dlaf/matrix/tile.h @@ -18,6 +18,7 @@ #include #include #include +#include #include #include diff --git a/include/dlaf/memory/memory_chunk.h b/include/dlaf/memory/memory_chunk.h index 6ff2e6f68f..9127d56be6 100644 --- a/include/dlaf/memory/memory_chunk.h +++ b/include/dlaf/memory/memory_chunk.h @@ -12,6 +12,7 @@ /// @file +#include #include #include diff --git a/include/dlaf/multiplication/general/impl.h b/include/dlaf/multiplication/general/impl.h index c27eae942c..8542fc7d03 100644 --- a/include/dlaf/multiplication/general/impl.h +++ b/include/dlaf/multiplication/general/impl.h @@ -10,6 +10,8 @@ #pragma once +#include + #include #include #include diff --git a/include/dlaf/multiplication/hermitian/impl.h b/include/dlaf/multiplication/hermitian/impl.h index 992ba55862..4fab8a6493 100644 --- a/include/dlaf/multiplication/hermitian/impl.h +++ b/include/dlaf/multiplication/hermitian/impl.h @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #pragma once diff --git a/include/dlaf/multiplication/triangular/impl.h b/include/dlaf/multiplication/triangular/impl.h index 8d41c66e99..4ed22837ec 100644 --- a/include/dlaf/multiplication/triangular/impl.h +++ b/include/dlaf/multiplication/triangular/impl.h @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #pragma once diff --git a/include/dlaf/permutations/general/impl.h b/include/dlaf/permutations/general/impl.h index 45b0de297d..3ab1ccf4d5 100644 --- a/include/dlaf/permutations/general/impl.h +++ b/include/dlaf/permutations/general/impl.h @@ -10,8 +10,10 @@ #pragma once +#include #include #include +#include #include diff --git a/include/dlaf/solver/triangular/impl.h b/include/dlaf/solver/triangular/impl.h index 87e455b659..95843d7433 100644 --- a/include/dlaf/solver/triangular/impl.h +++ b/include/dlaf/solver/triangular/impl.h @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #pragma once diff --git a/include/dlaf/tune.h b/include/dlaf/tune.h index 7de7f2aa2c..a0c59eb901 100644 --- a/include/dlaf/tune.h +++ b/include/dlaf/tune.h @@ -11,6 +11,7 @@ /// @file +#include #include #include diff --git a/include/dlaf/util_matrix.h b/include/dlaf/util_matrix.h index 40b67967f0..c7f231cab8 100644 --- a/include/dlaf/util_matrix.h +++ b/include/dlaf/util_matrix.h @@ -10,6 +10,7 @@ #pragma once #include +#include #include #include #include diff --git a/inshpect.output b/inshpect.output index e15a198480..e34e901af9 100644 --- a/inshpect.output +++ b/inshpect.output @@ -2,132 +2,42 @@ Include for \bstd::nullopt\b: ./include/dlaf/common/pipeline.h:49: : pipeline(std::exchange(other.pipeline, std::nullopt)), -./include/dlaf/util_matrix.h:342: std::optional band_size = std::nullopt) { +./include/dlaf/util_matrix.h:343: std::optional band_size = std::nullopt) { Include for \bstd::is_floating_point\b: ./include/dlaf/types.h:145:struct IsFloatingPointOrComplex : std::is_floating_point {}; Include for \bstd::terminate\b: -./include/dlaf/memory/memory_chunk.h:72: std::terminate(); +./include/dlaf/memory/memory_chunk.h:73: std::terminate(); ./src/c_api/utils.cpp:63: std::terminate(); -Include for \bstd::size_t\b: -./include/dlaf/common/data_descriptor.h:142:template -./include/dlaf/common/round_robin.h:27: RoundRobin(std::size_t n, Args... args) { -./include/dlaf/communication/communicator_grid.h:41: std::size_t npipelines = getTuneParameters().communicator_grid_num_pipelines); -./include/dlaf/eigensolver/band_to_tridiag/mc.h:1155: constexpr std::size_t n_workspaces = 4; -./include/dlaf/eigensolver/bt_band_to_tridiag/impl.h:509: HHManager(const SizeType b, const std::size_t, matrix::Distribution, matrix::Distribution) : b(b) {} -./include/dlaf/eigensolver/bt_reduction_to_band/impl.h:155: constexpr std::size_t n_workspaces = 2; -./include/dlaf/eigensolver/gen_to_std/impl.h:295: constexpr std::size_t n_workspaces = 2; -./include/dlaf/eigensolver/internal/get_red2band_panel_nworkers.h:23: const std::size_t available_workers = pika::resource::get_thread_pool("default").get_os_thread_count(); -./include/dlaf/eigensolver/internal/get_tridiag_rank1_nworkers.h:21:inline std::size_t getTridiagRank1NWorkers() noexcept { -./include/dlaf/eigensolver/tridiag_solver/merge.h:269:inline std::size_t ev_sort_order(const ColType coltype) { -./include/dlaf/eigensolver/tridiag_solver/rot.h:290: const std::size_t linear_tile_col = to_sizet(dist_sub.localTileLinearIndex(tile_col)); -./include/dlaf/factorization/cholesky/impl.h:198: constexpr std::size_t n_workspaces = 2; -./include/dlaf/init.h:37: std::size_t num_np_gpu_streams_per_thread = 3; -./include/dlaf/matrix/copy_tile.h:83: const std::size_t m = to_sizet(source.size().rows()); -./include/dlaf/matrix/hdf5.h:42: static constexpr std::size_t dims = 1; -./include/dlaf/matrix/matrix.h:386: for (std::size_t i = 0; i < n; ++i) { -./include/dlaf/memory/memory_chunk.h:27:void initializeUmpireHostAllocator(std::size_t initial_bytes); -./include/dlaf/multiplication/general/impl.h:89: constexpr std::size_t n_workspaces = 2; -./include/dlaf/multiplication/hermitian/impl.h:115: constexpr std::size_t n_workspaces = 2; -./include/dlaf/multiplication/triangular/impl.h:417: constexpr std::size_t n_workspaces = 2; -./include/dlaf/permutations/general/impl.h:104: for (std::size_t i_split = 0; i_split < splits.size() - 1; ++i_split) { -./include/dlaf/solver/triangular/impl.h:495: constexpr std::size_t n_workspaces = 2; -./include/dlaf/tune.h:81: red2band_panel_nworkers = std::max(1, default_pool_thread_count / 2); -./include/dlaf/util_matrix.h:155: getter_random(SizeType seed) : random_engine_(static_cast(seed)) { -./miniapp/include/dlaf/miniapp/options.h:164: for (std::size_t i = 0; i < valid_values.size(); ++i) { -./src/communication/communicator_grid.cpp:19: common::Ordering ordering, std::size_t npipelines) { -./src/init.cpp:69:void initializeGpuPool(int device, std::size_t num_np_streams, std::size_t num_hp_streams) { -./src/memory/memory_chunk.cpp:37:void initializeUmpireHostAllocator(std::size_t initial_bytes) { -./test/include/dlaf_test/comm_grids/grids_6_ranks.h:80: const std::size_t ncommunicator_pipelines = 3; -./test/include/dlaf_test/matrix/matrix_local.h:123: std::size_t tileLinearIndex(const GlobalTileIndex& index) const noexcept { -./test/include/dlaf_test/matrix/util_matrix_local.h:54: const auto linear_size = static_cast(source.size().rows() * source.size().cols()); -./test/include/dlaf_test/matrix/util_matrix_senders.h:39: result.reserve(static_cast(dist.localNrTiles().linear_size())); -./test/src/gtest_mpi_listener.cpp:89: return last_test_part_results_[static_cast(index)]; -./test/unit/common/test_data_descriptor.cpp:46: return {std::make_unique(static_cast(blocksize)), num_blocks, blocksize, stride}; -./test/unit/communication/test_comm_sender.cpp:37: std::vector send_buf(static_cast(size), rank); -./test/unit/communication/test_communicator_grid.cpp:215: const std::vector test_npipelines{1, 3, 10}; -./test/unit/init/test_init.cpp:93: const std::size_t default_val = default_cfg.num_hp_gpu_streams_per_thread; -./test/unit/matrix/test_tile.cpp:389: const std::vector& specs, std::size_t last_dep, -./test/unit/permutations/test_permutations_distributed.cpp:75: const std::size_t nperms = to_sizet(i_end - i_begin); Include for \bstd::(forward_as_|make_|)tuple\b: -./include/dlaf/eigensolver/tridiag_solver/impl.h:47: std::vector>& indices) { -./include/dlaf/permutations/general/impl.h:159: return std::tuple(std::move(splits), std::move(index_tile_futs), std::move(mat_in_tiles), +./include/dlaf/eigensolver/tridiag_solver/impl.h:48: std::vector>& indices) { +./include/dlaf/permutations/general/impl.h:161: return std::tuple(std::move(splits), std::move(index_tile_futs), std::move(mat_in_tiles), ./src/c_api/utils.cpp:32:std::tuple distribution_and_layout( ./src/c_api/utils.h:15:std::tuple distribution_and_layout( -./test/unit/eigensolver/test_tridiag_solver_distributed.cpp:50:const std::vector> tested_problems = { -./test/unit/eigensolver/test_tridiag_solver_local.cpp:42: std::vector> expected_indices{{0, 1, 2}, {0, 2, 3}, -./test/unit/lapack/gpu/test_lacpy.cpp:32:std::vector> configs{ -./test/unit/matrix/test_distribution.cpp:192:std::tuple test_tile_size(const ParametersConstructor& test) { -./test/unit/matrix/test_layout_info.cpp:20:const std::vector> +./test/unit/eigensolver/test_tridiag_solver_distributed.cpp:51:const std::vector> tested_problems = { +./test/unit/eigensolver/test_tridiag_solver_local.cpp:43: std::vector> expected_indices{{0, 1, 2}, {0, 2, 3}, +./test/unit/lapack/gpu/test_lacpy.cpp:34:std::vector> configs{ +./test/unit/matrix/test_distribution.cpp:193:std::tuple test_tile_size(const ParametersConstructor& test) { +./test/unit/matrix/test_layout_info.cpp:22:const std::vector> ./test/unit/matrix/test_matrix.cpp:744: return std::tuple(std::move(rosenders2a), std::move(rosenders2b), std::move(senders3)); ./test/unit/matrix/test_matrix_hdf5.cpp:77: return std::make_tuple(std::move(matrix), std::move(original_values)); ./test/unit/matrix/test_retiled_matrix.cpp:49:const std::vector> local_sizes_tests({ -./test/unit/matrix/test_tile.cpp:45:using TileSizes = std::tuple; -./test/unit/multiplication/test_multiplication_general.cpp:292:const std::vector> sizes = { -./test/unit/permutations/test_permutations_distributed.cpp:49:using testcase_t = std::tuple>; -./test/unit/permutations/test_permutations_local.cpp:88:const std::vector> sizes = { -./test/unit/test_blas_tile.cpp:47:std::vector> gemm_sizes = { -./test/unit/test_blas_tile_extensions.cpp:37:std::vector> scal_sizes = { -./test/unit/test_lapack_tile.cpp:55:std::vector> hegst_sizes = { +./test/unit/matrix/test_tile.cpp:47:using TileSizes = std::tuple; +./test/unit/multiplication/test_multiplication_general.cpp:294:const std::vector> sizes = { +./test/unit/permutations/test_permutations_distributed.cpp:51:using testcase_t = std::tuple>; +./test/unit/permutations/test_permutations_local.cpp:90:const std::vector> sizes = { +./test/unit/test_blas_tile.cpp:49:std::vector> gemm_sizes = { +./test/unit/test_blas_tile_extensions.cpp:39:std::vector> scal_sizes = { +./test/unit/test_lapack_tile.cpp:56:std::vector> hegst_sizes = { Include for \bstd::(cin|cout|cerr|clog)\b: ./include/dlaf/matrix/print_csv.h:36:void print(format::csv, const Tile& tile, std::ostream& os = std::cout) { ./include/dlaf/matrix/print_numpy.h:69:void print(format::numpy, const Tile& tile, std::ostream& os = std::cout) { -./include/dlaf/memory/memory_chunk.h:70: std::cout +./include/dlaf/memory/memory_chunk.h:71: std::cout ./miniapp/kernel/miniapp_laset.cpp:108: std::cout << "[" << run_index << "]" ./src/c_api/grid.cpp:63: std::cerr << "Grid layout must be row major or column major." << std::endl; -./test/include/dlaf_test/matrix/util_matrix_local.h:140: std::ostream& os = std::cout) { -./test/unit/common/test_data_descriptor.cpp:79: std::cout << "Unknown memory type" << std::endl; +./test/include/dlaf_test/matrix/util_matrix_local.h:141: std::ostream& os = std::cout) { +./test/unit/common/test_data_descriptor.cpp:81: std::cout << "Unknown memory type" << std::endl; Include for \bstd::atomic\b: ./test/include/dlaf_test/matrix/util_tile.h:49: : ready(std::make_shared>(false)), -Include for \bstd::vector\b: -./include/dlaf/auxiliary/norm/mc.h:80: auto max_element = [](std::vector&& values) { -./include/dlaf/eigensolver/band_to_tridiag/mc.h:696: using TileVector = std::vector>; -./include/dlaf/eigensolver/bt_band_to_tridiag/impl.h:108: std::vector taus; -./include/dlaf/eigensolver/tridiag_solver/impl.h:47: std::vector>& indices) { -./include/dlaf/eigensolver/tridiag_solver/merge.h:224: std::vector> tiles_max; -./include/dlaf/eigensolver/tridiag_solver/rot.h:266: mb](std::vector> rots, std::vector> tiles, -./include/dlaf/matrix/tile.h:540:std::vector> splitTile(ReadOnlyTileSender tile, -./include/dlaf/permutations/general/impl.h:98: const SizeType i_perm, const std::vector& splits, const GlobalElementIndex out_begin, -./miniapp/include/dlaf/miniapp/options.h:155: const std::vector& valid_values) { -./src/permutations/general/perms.cu:40: const std::vector>& tiles) { -./test/include/dlaf_test/comm_grids/grids_6_ranks.h:21:std::vector comm_grids; -./test/include/dlaf_test/matrix/matrix_local.h:134: std::vector> tiles_; -./test/src/gtest_mpi_listener.cpp:185: std::vector message_buffer(static_cast(message_length)); -./test/unit/auxiliary/mc/test_norm.cpp:44:const std::vector lapack_norms({lapack::Norm::Fro, lapack::Norm::Inf, lapack::Norm::Max, -./test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp:58:const std::vector blas_uplos({blas::Uplo::Lower}); -./test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp:56:const std::vector blas_uplos({blas::Uplo::Lower}); -./test/unit/c_api/factorization/test_cholesky_c_api.cpp:52:const std::vector blas_uplos({blas::Uplo::Lower, blas::Uplo::Upper}); -./test/unit/common/test_data_descriptor.cpp:701: std::vector> memory_types; -./test/unit/communication/test_broadcast_panel.cpp:50:std::vector test_params{ -./test/unit/communication/test_communicator_grid.cpp:215: const std::vector test_npipelines{1, 3, 10}; -./test/unit/eigensolver/test_band_to_tridiag.cpp:50:const std::vector> sizes = { -./test/unit/eigensolver/test_bt_band_to_tridiag.cpp:253:std::vector configs{ -./test/unit/eigensolver/test_eigensolver.cpp:61:const std::vector blas_uplos({blas::Uplo::Lower}); -./test/unit/eigensolver/test_gen_eigensolver.cpp:61:const std::vector blas_uplos({blas::Uplo::Lower}); -./test/unit/eigensolver/test_gen_to_std.cpp:51:const std::vector blas_uplos({blas::Uplo::Lower, blas::Uplo::Upper}); -./test/unit/eigensolver/test_reduction_to_band.cpp:82:std::vector configs{ -./test/unit/eigensolver/test_tridiag_solver_distributed.cpp:50:const std::vector> tested_problems = { -./test/unit/eigensolver/test_tridiag_solver_local.cpp:42: std::vector> expected_indices{{0, 1, 2}, {0, 2, 3}, -./test/unit/eigensolver/test_tridiag_solver_merge.cpp:71: std::vector vec_arr{7, 2, 4, 8, 12, 1, 17, 32, 9, 6}; -./test/unit/eigensolver/test_tridiag_solver_rot.cpp:50: std::vector rots; -./test/unit/factorization/test_cholesky.cpp:51:const std::vector blas_uplos({blas::Uplo::Lower, blas::Uplo::Upper}); -./test/unit/factorization/test_compute_t_factor.cpp:207:std::vector> configs{ -./test/unit/lapack/gpu/test_lacpy.cpp:32:std::vector> configs{ -./test/unit/matrix/test_distribution.cpp:38:const std::vector tests_constructor = { -./test/unit/matrix/test_distribution_extensions.cpp:42:const std::vector tests_indices = { -./test/unit/matrix/test_layout_info.cpp:20:const std::vector> -./test/unit/matrix/test_tile.cpp:36:const std::vector sizes({0, 1, 13, 32}); -./test/unit/matrix/test_util_distribution.cpp:40: std::vector tests = { -./test/unit/matrix/test_views.cpp:53:const std::vector configs{ -./test/unit/multiplication/test_multiplication_general.cpp:223:std::vector gemm_configs = { -./test/unit/multiplication/test_multiplication_hermitian.cpp:53:const std::vector blas_sides({blas::Side::Left, blas::Side::Right}); -./test/unit/multiplication/test_multiplication_triangular.cpp:53:const std::vector blas_sides({blas::Side::Left, blas::Side::Right}); -./test/unit/permutations/test_permutations_distributed.cpp:49:using testcase_t = std::tuple>; -./test/unit/permutations/test_permutations_local.cpp:88:const std::vector> sizes = { -./test/unit/solver/test_triangular.cpp:53:const std::vector blas_sides({blas::Side::Left, blas::Side::Right}); -./test/unit/test_blas_tile.cpp:26:const std::vector blas_diags({blas::Diag::Unit, blas::Diag::NonUnit}); -./test/unit/test_blas_tile_extensions.cpp:37:std::vector> scal_sizes = { -./test/unit/test_lapack_tile.cpp:29:const std::vector blas_diags({blas::Diag::Unit, blas::Diag::NonUnit}); -./test/unit/test_util_math.cpp:232: std::vector splits = util::interleaveSplits(l, b, o1, o2); -Found 120 violation(s) \ No newline at end of file +Found 32 violation(s) \ No newline at end of file diff --git a/miniapp/include/dlaf/miniapp/options.h b/miniapp/include/dlaf/miniapp/options.h index 8ebd782891..935d2fbe03 100644 --- a/miniapp/include/dlaf/miniapp/options.h +++ b/miniapp/include/dlaf/miniapp/options.h @@ -12,11 +12,13 @@ #include #include +#include #include #include #include #include #include +#include #include diff --git a/src/communication/communicator_grid.cpp b/src/communication/communicator_grid.cpp index 9cc4c02060..61a1222ded 100644 --- a/src/communication/communicator_grid.cpp +++ b/src/communication/communicator_grid.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include #include diff --git a/src/init.cpp b/src/init.cpp index 0696c8cf1d..84e46ffa21 100644 --- a/src/init.cpp +++ b/src/init.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include diff --git a/src/memory/memory_chunk.cpp b/src/memory/memory_chunk.cpp index 3b20a58e64..a2b0c33885 100644 --- a/src/memory/memory_chunk.cpp +++ b/src/memory/memory_chunk.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include #include diff --git a/src/permutations/general/perms.cu b/src/permutations/general/perms.cu index 37d519e32e..c0d1aca3c1 100644 --- a/src/permutations/general/perms.cu +++ b/src/permutations/general/perms.cu @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include diff --git a/test/include/dlaf_test/comm_grids/grids_6_ranks.h b/test/include/dlaf_test/comm_grids/grids_6_ranks.h index babc194fd1..d2b22beb76 100644 --- a/test/include/dlaf_test/comm_grids/grids_6_ranks.h +++ b/test/include/dlaf_test/comm_grids/grids_6_ranks.h @@ -10,6 +10,9 @@ #pragma once +#include +#include + #include #include diff --git a/test/include/dlaf_test/matrix/matrix_local.h b/test/include/dlaf_test/matrix/matrix_local.h index 8cd565ecf9..009f7a5c8a 100644 --- a/test/include/dlaf_test/matrix/matrix_local.h +++ b/test/include/dlaf_test/matrix/matrix_local.h @@ -10,7 +10,9 @@ #pragma once +#include #include +#include #include #include diff --git a/test/include/dlaf_test/matrix/util_matrix.h b/test/include/dlaf_test/matrix/util_matrix.h index 8c3a65011f..3af1fe0513 100644 --- a/test/include/dlaf_test/matrix/util_matrix.h +++ b/test/include/dlaf_test/matrix/util_matrix.h @@ -12,6 +12,7 @@ /// @file +#include #include #include #include diff --git a/test/include/dlaf_test/matrix/util_matrix_local.h b/test/include/dlaf_test/matrix/util_matrix_local.h index 914a28afc7..ccd5d0092f 100644 --- a/test/include/dlaf_test/matrix/util_matrix_local.h +++ b/test/include/dlaf_test/matrix/util_matrix_local.h @@ -12,6 +12,7 @@ /// @file +#include #include #include #include diff --git a/test/include/dlaf_test/matrix/util_matrix_senders.h b/test/include/dlaf_test/matrix/util_matrix_senders.h index a5122eacc3..f4c9f23ec5 100644 --- a/test/include/dlaf_test/matrix/util_matrix_senders.h +++ b/test/include/dlaf_test/matrix/util_matrix_senders.h @@ -12,6 +12,7 @@ /// @file +#include #include #include #include diff --git a/test/src/gtest_mpi_listener.cpp b/test/src/gtest_mpi_listener.cpp index e0f6d8c5f5..4c8f78366b 100644 --- a/test/src/gtest_mpi_listener.cpp +++ b/test/src/gtest_mpi_listener.cpp @@ -9,10 +9,12 @@ // #include +#include #include #include #include #include +#include #include "gtest_mpi_listener.h" diff --git a/test/unit/auxiliary/mc/test_norm.cpp b/test/unit/auxiliary/mc/test_norm.cpp index 238a950143..e596ca4eed 100644 --- a/test/unit/auxiliary/mc/test_norm.cpp +++ b/test/unit/auxiliary/mc/test_norm.cpp @@ -10,6 +10,7 @@ #include #include +#include #include #include diff --git a/test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp b/test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp index 6460b60af6..21076425e5 100644 --- a/test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp +++ b/test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include diff --git a/test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp b/test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp index 9b0465bf3e..728492d05a 100644 --- a/test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp +++ b/test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include diff --git a/test/unit/c_api/factorization/test_cholesky_c_api.cpp b/test/unit/c_api/factorization/test_cholesky_c_api.cpp index 0df751f765..350f97c83b 100644 --- a/test/unit/c_api/factorization/test_cholesky_c_api.cpp +++ b/test/unit/c_api/factorization/test_cholesky_c_api.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include diff --git a/test/unit/common/test_data_descriptor.cpp b/test/unit/common/test_data_descriptor.cpp index 4f17b16879..b8e4d791d1 100644 --- a/test/unit/common/test_data_descriptor.cpp +++ b/test/unit/common/test_data_descriptor.cpp @@ -8,8 +8,10 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include +#include #include #include diff --git a/test/unit/communication/test_broadcast_panel.cpp b/test/unit/communication/test_broadcast_panel.cpp index eb686dd464..bfcf26e2fe 100644 --- a/test/unit/communication/test_broadcast_panel.cpp +++ b/test/unit/communication/test_broadcast_panel.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include #include diff --git a/test/unit/communication/test_comm_sender.cpp b/test/unit/communication/test_comm_sender.cpp index 818d97eb0c..3083301660 100644 --- a/test/unit/communication/test_comm_sender.cpp +++ b/test/unit/communication/test_comm_sender.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include diff --git a/test/unit/communication/test_communicator_grid.cpp b/test/unit/communication/test_communicator_grid.cpp index ae622c215b..81585720b1 100644 --- a/test/unit/communication/test_communicator_grid.cpp +++ b/test/unit/communication/test_communicator_grid.cpp @@ -9,7 +9,9 @@ // #include +#include #include +#include #include diff --git a/test/unit/eigensolver/test_band_to_tridiag.cpp b/test/unit/eigensolver/test_band_to_tridiag.cpp index 02798f1bea..108bd53789 100644 --- a/test/unit/eigensolver/test_band_to_tridiag.cpp +++ b/test/unit/eigensolver/test_band_to_tridiag.cpp @@ -13,6 +13,7 @@ #include #include #include +#include #include #include diff --git a/test/unit/eigensolver/test_bt_band_to_tridiag.cpp b/test/unit/eigensolver/test_bt_band_to_tridiag.cpp index 39432947ad..d947554cd0 100644 --- a/test/unit/eigensolver/test_bt_band_to_tridiag.cpp +++ b/test/unit/eigensolver/test_bt_band_to_tridiag.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include diff --git a/test/unit/eigensolver/test_eigensolver.cpp b/test/unit/eigensolver/test_eigensolver.cpp index 9887d7601b..81fff7d42b 100644 --- a/test/unit/eigensolver/test_eigensolver.cpp +++ b/test/unit/eigensolver/test_eigensolver.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include #include diff --git a/test/unit/eigensolver/test_gen_eigensolver.cpp b/test/unit/eigensolver/test_gen_eigensolver.cpp index 1e88a2f2d4..e7df53fcb0 100644 --- a/test/unit/eigensolver/test_gen_eigensolver.cpp +++ b/test/unit/eigensolver/test_gen_eigensolver.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include diff --git a/test/unit/eigensolver/test_gen_to_std.cpp b/test/unit/eigensolver/test_gen_to_std.cpp index 4fa7ea4292..becbc779c0 100644 --- a/test/unit/eigensolver/test_gen_to_std.cpp +++ b/test/unit/eigensolver/test_gen_to_std.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include diff --git a/test/unit/eigensolver/test_reduction_to_band.cpp b/test/unit/eigensolver/test_reduction_to_band.cpp index 6700b793e2..c4bee9db09 100644 --- a/test/unit/eigensolver/test_reduction_to_band.cpp +++ b/test/unit/eigensolver/test_reduction_to_band.cpp @@ -9,6 +9,7 @@ // #include +#include #include #include diff --git a/test/unit/eigensolver/test_tridiag_solver_distributed.cpp b/test/unit/eigensolver/test_tridiag_solver_distributed.cpp index 3ef820b0e0..7d8f54f2d9 100644 --- a/test/unit/eigensolver/test_tridiag_solver_distributed.cpp +++ b/test/unit/eigensolver/test_tridiag_solver_distributed.cpp @@ -9,6 +9,7 @@ // #include +#include #include diff --git a/test/unit/eigensolver/test_tridiag_solver_local.cpp b/test/unit/eigensolver/test_tridiag_solver_local.cpp index f95abe9be1..882aedf4d8 100644 --- a/test/unit/eigensolver/test_tridiag_solver_local.cpp +++ b/test/unit/eigensolver/test_tridiag_solver_local.cpp @@ -9,6 +9,7 @@ // #include +#include #include #include diff --git a/test/unit/eigensolver/test_tridiag_solver_merge.cpp b/test/unit/eigensolver/test_tridiag_solver_merge.cpp index 1f86738534..d4813d45f7 100644 --- a/test/unit/eigensolver/test_tridiag_solver_merge.cpp +++ b/test/unit/eigensolver/test_tridiag_solver_merge.cpp @@ -12,6 +12,7 @@ #include #include #include +#include #include #include diff --git a/test/unit/eigensolver/test_tridiag_solver_rot.cpp b/test/unit/eigensolver/test_tridiag_solver_rot.cpp index 1f9fd4f754..a1bb0d9375 100644 --- a/test/unit/eigensolver/test_tridiag_solver_rot.cpp +++ b/test/unit/eigensolver/test_tridiag_solver_rot.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include #include diff --git a/test/unit/factorization/test_cholesky.cpp b/test/unit/factorization/test_cholesky.cpp index 1bafc8149d..301678e947 100644 --- a/test/unit/factorization/test_cholesky.cpp +++ b/test/unit/factorization/test_cholesky.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include diff --git a/test/unit/factorization/test_compute_t_factor.cpp b/test/unit/factorization/test_compute_t_factor.cpp index f23b0c68fc..7cafc2fedd 100644 --- a/test/unit/factorization/test_compute_t_factor.cpp +++ b/test/unit/factorization/test_compute_t_factor.cpp @@ -10,6 +10,7 @@ #include #include +#include #include diff --git a/test/unit/init/test_init.cpp b/test/unit/init/test_init.cpp index 9dab21a991..491c5251da 100644 --- a/test/unit/init/test_init.cpp +++ b/test/unit/init/test_init.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include #include diff --git a/test/unit/lapack/gpu/test_lacpy.cpp b/test/unit/lapack/gpu/test_lacpy.cpp index 16a73a5827..2636050a10 100644 --- a/test/unit/lapack/gpu/test_lacpy.cpp +++ b/test/unit/lapack/gpu/test_lacpy.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include diff --git a/test/unit/matrix/test_distribution.cpp b/test/unit/matrix/test_distribution.cpp index 99194c2bb9..abf731edbd 100644 --- a/test/unit/matrix/test_distribution.cpp +++ b/test/unit/matrix/test_distribution.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include diff --git a/test/unit/matrix/test_distribution_extensions.cpp b/test/unit/matrix/test_distribution_extensions.cpp index e201196563..3253f5b73c 100644 --- a/test/unit/matrix/test_distribution_extensions.cpp +++ b/test/unit/matrix/test_distribution_extensions.cpp @@ -10,6 +10,7 @@ #include #include +#include #include diff --git a/test/unit/matrix/test_layout_info.cpp b/test/unit/matrix/test_layout_info.cpp index e00836c342..e153e16f1a 100644 --- a/test/unit/matrix/test_layout_info.cpp +++ b/test/unit/matrix/test_layout_info.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include #include diff --git a/test/unit/matrix/test_tile.cpp b/test/unit/matrix/test_tile.cpp index cab77fb64b..71437d7487 100644 --- a/test/unit/matrix/test_tile.cpp +++ b/test/unit/matrix/test_tile.cpp @@ -8,8 +8,10 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include +#include #include diff --git a/test/unit/matrix/test_util_distribution.cpp b/test/unit/matrix/test_util_distribution.cpp index 52a3d71663..9ae71f3502 100644 --- a/test/unit/matrix/test_util_distribution.cpp +++ b/test/unit/matrix/test_util_distribution.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include diff --git a/test/unit/matrix/test_views.cpp b/test/unit/matrix/test_views.cpp index e723d054b8..c1fc5ceb45 100644 --- a/test/unit/matrix/test_views.cpp +++ b/test/unit/matrix/test_views.cpp @@ -10,6 +10,7 @@ #include #include +#include #include #include diff --git a/test/unit/multiplication/test_multiplication_general.cpp b/test/unit/multiplication/test_multiplication_general.cpp index 5a84c6bb2a..5509b1d52e 100644 --- a/test/unit/multiplication/test_multiplication_general.cpp +++ b/test/unit/multiplication/test_multiplication_general.cpp @@ -1,3 +1,4 @@ + // // Distributed Linear Algebra with Future (DLAF) // @@ -9,6 +10,7 @@ // #include +#include #include diff --git a/test/unit/multiplication/test_multiplication_hermitian.cpp b/test/unit/multiplication/test_multiplication_hermitian.cpp index effb7ae679..0f21eab622 100644 --- a/test/unit/multiplication/test_multiplication_hermitian.cpp +++ b/test/unit/multiplication/test_multiplication_hermitian.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include diff --git a/test/unit/multiplication/test_multiplication_triangular.cpp b/test/unit/multiplication/test_multiplication_triangular.cpp index 175ccb4a54..8910987834 100644 --- a/test/unit/multiplication/test_multiplication_triangular.cpp +++ b/test/unit/multiplication/test_multiplication_triangular.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include diff --git a/test/unit/permutations/test_permutations_distributed.cpp b/test/unit/permutations/test_permutations_distributed.cpp index 239a9ea5f6..47b85b165e 100644 --- a/test/unit/permutations/test_permutations_distributed.cpp +++ b/test/unit/permutations/test_permutations_distributed.cpp @@ -9,7 +9,9 @@ // #include +#include #include +#include #include diff --git a/test/unit/permutations/test_permutations_local.cpp b/test/unit/permutations/test_permutations_local.cpp index ffb79e4bac..f592b8cfc1 100644 --- a/test/unit/permutations/test_permutations_local.cpp +++ b/test/unit/permutations/test_permutations_local.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include #include diff --git a/test/unit/solver/test_triangular.cpp b/test/unit/solver/test_triangular.cpp index 49d19be501..409e162403 100644 --- a/test/unit/solver/test_triangular.cpp +++ b/test/unit/solver/test_triangular.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include diff --git a/test/unit/test_blas_tile.cpp b/test/unit/test_blas_tile.cpp index 65d8d6c072..b00355750b 100644 --- a/test/unit/test_blas_tile.cpp +++ b/test/unit/test_blas_tile.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include "test_blas_tile/test_gemm.h" diff --git a/test/unit/test_blas_tile_extensions.cpp b/test/unit/test_blas_tile_extensions.cpp index 67fe11023d..e20cd06a9d 100644 --- a/test/unit/test_blas_tile_extensions.cpp +++ b/test/unit/test_blas_tile_extensions.cpp @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include "test_blas_tile/test_add.h" diff --git a/test/unit/test_lapack_tile.cpp b/test/unit/test_lapack_tile.cpp index 25fc746060..43991d0619 100644 --- a/test/unit/test_lapack_tile.cpp +++ b/test/unit/test_lapack_tile.cpp @@ -9,6 +9,7 @@ // #include #include +#include #include diff --git a/test/unit/test_util_math.cpp b/test/unit/test_util_math.cpp index 55db81c70a..ab10a21557 100644 --- a/test/unit/test_util_math.cpp +++ b/test/unit/test_util_math.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include From bef420b4a024e8dae0ebb0173be41b36fe76840d Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Thu, 18 Apr 2024 13:39:49 +0200 Subject: [PATCH 16/62] last add, vector, utily, ecc. --- include/dlaf/common/pipeline.h | 1 + .../dlaf/eigensolver/tridiag_solver/impl.h | 1 + include/dlaf/matrix/print_csv.h | 1 + include/dlaf/matrix/print_numpy.h | 1 + include/dlaf/memory/memory_chunk.h | 2 + include/dlaf/permutations/general/impl.h | 1 + include/dlaf/types.h | 1 + include/dlaf/util_matrix.h | 1 + inshpect.output | 41 ------------------- miniapp/kernel/miniapp_laset.cpp | 1 + src/c_api/grid.cpp | 1 + src/c_api/utils.cpp | 3 ++ src/c_api/utils.h | 2 + .../dlaf_test/matrix/util_matrix_local.h | 1 + test/include/dlaf_test/matrix/util_tile.h | 1 + test/unit/common/test_data_descriptor.cpp | 1 + .../test_tridiag_solver_distributed.cpp | 1 + .../eigensolver/test_tridiag_solver_local.cpp | 1 + test/unit/lapack/gpu/test_lacpy.cpp | 1 + test/unit/matrix/test_distribution.cpp | 1 + test/unit/matrix/test_layout_info.cpp | 1 + test/unit/matrix/test_matrix.cpp | 1 + test/unit/matrix/test_matrix_hdf5.cpp | 1 + test/unit/matrix/test_retiled_matrix.cpp | 1 + test/unit/matrix/test_tile.cpp | 1 + .../test_multiplication_general.cpp | 1 + .../test_permutations_distributed.cpp | 1 + .../permutations/test_permutations_local.cpp | 1 + test/unit/test_blas_tile.cpp | 1 + test/unit/test_blas_tile_extensions.cpp | 1 + test/unit/test_lapack_tile.cpp | 1 + 31 files changed, 34 insertions(+), 41 deletions(-) diff --git a/include/dlaf/common/pipeline.h b/include/dlaf/common/pipeline.h index b325982462..57a99dbcb5 100644 --- a/include/dlaf/common/pipeline.h +++ b/include/dlaf/common/pipeline.h @@ -12,6 +12,7 @@ /// @file +#include #include #include diff --git a/include/dlaf/eigensolver/tridiag_solver/impl.h b/include/dlaf/eigensolver/tridiag_solver/impl.h index 7bf1092621..d75da4d010 100644 --- a/include/dlaf/eigensolver/tridiag_solver/impl.h +++ b/include/dlaf/eigensolver/tridiag_solver/impl.h @@ -10,6 +10,7 @@ #pragma once #include +#include #include #include diff --git a/include/dlaf/matrix/print_csv.h b/include/dlaf/matrix/print_csv.h index 03df775b2e..33fe47460f 100644 --- a/include/dlaf/matrix/print_csv.h +++ b/include/dlaf/matrix/print_csv.h @@ -9,6 +9,7 @@ // #include +#include #pragma once diff --git a/include/dlaf/matrix/print_numpy.h b/include/dlaf/matrix/print_numpy.h index 27c8761249..c7a3a98db1 100644 --- a/include/dlaf/matrix/print_numpy.h +++ b/include/dlaf/matrix/print_numpy.h @@ -12,6 +12,7 @@ /// @file +#include #include #include diff --git a/include/dlaf/memory/memory_chunk.h b/include/dlaf/memory/memory_chunk.h index 9127d56be6..c837d54f49 100644 --- a/include/dlaf/memory/memory_chunk.h +++ b/include/dlaf/memory/memory_chunk.h @@ -14,6 +14,8 @@ #include #include +#include +#include #include #include diff --git a/include/dlaf/permutations/general/impl.h b/include/dlaf/permutations/general/impl.h index 3ab1ccf4d5..4991ccf90d 100644 --- a/include/dlaf/permutations/general/impl.h +++ b/include/dlaf/permutations/general/impl.h @@ -12,6 +12,7 @@ #include #include +#include #include #include diff --git a/include/dlaf/types.h b/include/dlaf/types.h index 3e8400120b..9d50a7c57f 100644 --- a/include/dlaf/types.h +++ b/include/dlaf/types.h @@ -16,6 +16,7 @@ #include #include #include +#include #include diff --git a/include/dlaf/util_matrix.h b/include/dlaf/util_matrix.h index c7f231cab8..e01285b900 100644 --- a/include/dlaf/util_matrix.h +++ b/include/dlaf/util_matrix.h @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include diff --git a/inshpect.output b/inshpect.output index e34e901af9..e8ce7f1b06 100644 --- a/inshpect.output +++ b/inshpect.output @@ -1,43 +1,2 @@ # Includes -Include for \bstd::nullopt\b: -./include/dlaf/common/pipeline.h:49: : pipeline(std::exchange(other.pipeline, std::nullopt)), -./include/dlaf/util_matrix.h:343: std::optional band_size = std::nullopt) { -Include for \bstd::is_floating_point\b: -./include/dlaf/types.h:145:struct IsFloatingPointOrComplex : std::is_floating_point {}; -Include for \bstd::terminate\b: -./include/dlaf/memory/memory_chunk.h:73: std::terminate(); -./src/c_api/utils.cpp:63: std::terminate(); -Include for \bstd::(forward_as_|make_|)tuple\b: -./include/dlaf/eigensolver/tridiag_solver/impl.h:48: std::vector>& indices) { -./include/dlaf/permutations/general/impl.h:161: return std::tuple(std::move(splits), std::move(index_tile_futs), std::move(mat_in_tiles), -./src/c_api/utils.cpp:32:std::tuple distribution_and_layout( -./src/c_api/utils.h:15:std::tuple distribution_and_layout( -./test/unit/eigensolver/test_tridiag_solver_distributed.cpp:51:const std::vector> tested_problems = { -./test/unit/eigensolver/test_tridiag_solver_local.cpp:43: std::vector> expected_indices{{0, 1, 2}, {0, 2, 3}, -./test/unit/lapack/gpu/test_lacpy.cpp:34:std::vector> configs{ -./test/unit/matrix/test_distribution.cpp:193:std::tuple test_tile_size(const ParametersConstructor& test) { -./test/unit/matrix/test_layout_info.cpp:22:const std::vector> -./test/unit/matrix/test_matrix.cpp:744: return std::tuple(std::move(rosenders2a), std::move(rosenders2b), std::move(senders3)); -./test/unit/matrix/test_matrix_hdf5.cpp:77: return std::make_tuple(std::move(matrix), std::move(original_values)); -./test/unit/matrix/test_retiled_matrix.cpp:49:const std::vector> local_sizes_tests({ -./test/unit/matrix/test_tile.cpp:47:using TileSizes = std::tuple; -./test/unit/multiplication/test_multiplication_general.cpp:294:const std::vector> sizes = { -./test/unit/permutations/test_permutations_distributed.cpp:51:using testcase_t = std::tuple>; -./test/unit/permutations/test_permutations_local.cpp:90:const std::vector> sizes = { -./test/unit/test_blas_tile.cpp:49:std::vector> gemm_sizes = { -./test/unit/test_blas_tile_extensions.cpp:39:std::vector> scal_sizes = { -./test/unit/test_lapack_tile.cpp:56:std::vector> hegst_sizes = { -Include for \bstd::(cin|cout|cerr|clog)\b: -./include/dlaf/matrix/print_csv.h:36:void print(format::csv, const Tile& tile, std::ostream& os = std::cout) { -./include/dlaf/matrix/print_numpy.h:69:void print(format::numpy, const Tile& tile, std::ostream& os = std::cout) { -./include/dlaf/memory/memory_chunk.h:71: std::cout -./miniapp/kernel/miniapp_laset.cpp:108: std::cout << "[" << run_index << "]" -./src/c_api/grid.cpp:63: std::cerr << "Grid layout must be row major or column major." << std::endl; -./test/include/dlaf_test/matrix/util_matrix_local.h:141: std::ostream& os = std::cout) { -./test/unit/common/test_data_descriptor.cpp:81: std::cout << "Unknown memory type" << std::endl; -Include for \bstd::atomic\b: -./test/include/dlaf_test/matrix/util_tile.h:49: : ready(std::make_shared>(false)), - - -Found 32 violation(s) \ No newline at end of file diff --git a/miniapp/kernel/miniapp_laset.cpp b/miniapp/kernel/miniapp_laset.cpp index 3549757315..e640d1e5e5 100644 --- a/miniapp/kernel/miniapp_laset.cpp +++ b/miniapp/kernel/miniapp_laset.cpp @@ -9,6 +9,7 @@ // #include +#include #include #include diff --git a/src/c_api/grid.cpp b/src/c_api/grid.cpp index 618348d7cb..3e041f4021 100644 --- a/src/c_api/grid.cpp +++ b/src/c_api/grid.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include diff --git a/src/c_api/utils.cpp b/src/c_api/utils.cpp index 0456082658..cf8b5f2723 100644 --- a/src/c_api/utils.cpp +++ b/src/c_api/utils.cpp @@ -8,9 +8,12 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include +#include #include #include +#include #include #include diff --git a/src/c_api/utils.h b/src/c_api/utils.h index d16afcd7ef..466a7f2f98 100644 --- a/src/c_api/utils.h +++ b/src/c_api/utils.h @@ -8,6 +8,8 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #include #include #include diff --git a/test/include/dlaf_test/matrix/util_matrix_local.h b/test/include/dlaf_test/matrix/util_matrix_local.h index ccd5d0092f..53b3c58f34 100644 --- a/test/include/dlaf_test/matrix/util_matrix_local.h +++ b/test/include/dlaf_test/matrix/util_matrix_local.h @@ -14,6 +14,7 @@ #include #include +#include #include #include #include diff --git a/test/include/dlaf_test/matrix/util_tile.h b/test/include/dlaf_test/matrix/util_tile.h index ea51af40d7..02f22a6912 100644 --- a/test/include/dlaf_test/matrix/util_tile.h +++ b/test/include/dlaf_test/matrix/util_tile.h @@ -12,6 +12,7 @@ /// @file +#include #include #include #include diff --git a/test/unit/common/test_data_descriptor.cpp b/test/unit/common/test_data_descriptor.cpp index b8e4d791d1..c0418ec4c6 100644 --- a/test/unit/common/test_data_descriptor.cpp +++ b/test/unit/common/test_data_descriptor.cpp @@ -9,6 +9,7 @@ // #include +#include #include #include #include diff --git a/test/unit/eigensolver/test_tridiag_solver_distributed.cpp b/test/unit/eigensolver/test_tridiag_solver_distributed.cpp index 7d8f54f2d9..7871aa9938 100644 --- a/test/unit/eigensolver/test_tridiag_solver_distributed.cpp +++ b/test/unit/eigensolver/test_tridiag_solver_distributed.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include diff --git a/test/unit/eigensolver/test_tridiag_solver_local.cpp b/test/unit/eigensolver/test_tridiag_solver_local.cpp index 882aedf4d8..aca9ee77ac 100644 --- a/test/unit/eigensolver/test_tridiag_solver_local.cpp +++ b/test/unit/eigensolver/test_tridiag_solver_local.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include diff --git a/test/unit/lapack/gpu/test_lacpy.cpp b/test/unit/lapack/gpu/test_lacpy.cpp index 2636050a10..6f34a774a8 100644 --- a/test/unit/lapack/gpu/test_lacpy.cpp +++ b/test/unit/lapack/gpu/test_lacpy.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include diff --git a/test/unit/matrix/test_distribution.cpp b/test/unit/matrix/test_distribution.cpp index abf731edbd..8f7201ac07 100644 --- a/test/unit/matrix/test_distribution.cpp +++ b/test/unit/matrix/test_distribution.cpp @@ -10,6 +10,7 @@ #include #include +#include #include #include diff --git a/test/unit/matrix/test_layout_info.cpp b/test/unit/matrix/test_layout_info.cpp index e153e16f1a..935507853b 100644 --- a/test/unit/matrix/test_layout_info.cpp +++ b/test/unit/matrix/test_layout_info.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include diff --git a/test/unit/matrix/test_matrix.cpp b/test/unit/matrix/test_matrix.cpp index b2d6e759d7..ecaa53a8e5 100644 --- a/test/unit/matrix/test_matrix.cpp +++ b/test/unit/matrix/test_matrix.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include #include diff --git a/test/unit/matrix/test_matrix_hdf5.cpp b/test/unit/matrix/test_matrix_hdf5.cpp index 7d3cfedf50..7b7f056a40 100644 --- a/test/unit/matrix/test_matrix_hdf5.cpp +++ b/test/unit/matrix/test_matrix_hdf5.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include #include diff --git a/test/unit/matrix/test_retiled_matrix.cpp b/test/unit/matrix/test_retiled_matrix.cpp index b4a0cfde69..bdddbeeeec 100644 --- a/test/unit/matrix/test_retiled_matrix.cpp +++ b/test/unit/matrix/test_retiled_matrix.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include diff --git a/test/unit/matrix/test_tile.cpp b/test/unit/matrix/test_tile.cpp index 71437d7487..0fd80723ce 100644 --- a/test/unit/matrix/test_tile.cpp +++ b/test/unit/matrix/test_tile.cpp @@ -10,6 +10,7 @@ #include #include +#include #include #include diff --git a/test/unit/multiplication/test_multiplication_general.cpp b/test/unit/multiplication/test_multiplication_general.cpp index 5509b1d52e..dae02f7714 100644 --- a/test/unit/multiplication/test_multiplication_general.cpp +++ b/test/unit/multiplication/test_multiplication_general.cpp @@ -9,6 +9,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include diff --git a/test/unit/permutations/test_permutations_distributed.cpp b/test/unit/permutations/test_permutations_distributed.cpp index 47b85b165e..e0ff529a62 100644 --- a/test/unit/permutations/test_permutations_distributed.cpp +++ b/test/unit/permutations/test_permutations_distributed.cpp @@ -10,6 +10,7 @@ #include #include +#include #include #include diff --git a/test/unit/permutations/test_permutations_local.cpp b/test/unit/permutations/test_permutations_local.cpp index f592b8cfc1..9ebae3ae00 100644 --- a/test/unit/permutations/test_permutations_local.cpp +++ b/test/unit/permutations/test_permutations_local.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include diff --git a/test/unit/test_blas_tile.cpp b/test/unit/test_blas_tile.cpp index b00355750b..8b43f8711e 100644 --- a/test/unit/test_blas_tile.cpp +++ b/test/unit/test_blas_tile.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include diff --git a/test/unit/test_blas_tile_extensions.cpp b/test/unit/test_blas_tile_extensions.cpp index e20cd06a9d..faf29d6ab4 100644 --- a/test/unit/test_blas_tile_extensions.cpp +++ b/test/unit/test_blas_tile_extensions.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include #include #include diff --git a/test/unit/test_lapack_tile.cpp b/test/unit/test_lapack_tile.cpp index 43991d0619..fb1ef2e4b7 100644 --- a/test/unit/test_lapack_tile.cpp +++ b/test/unit/test_lapack_tile.cpp @@ -8,6 +8,7 @@ // SPDX-License-Identifier: BSD-3-Clause // #include +#include #include #include From d1999a97d0fa0bda63fa12e2f8a43bc60a1f803d Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Tue, 30 Apr 2024 11:46:18 +0200 Subject: [PATCH 17/62] refactor code for solve check error --- src/c_api/utils.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/c_api/utils.h b/src/c_api/utils.h index 466a7f2f98..5bb0142c7e 100644 --- a/src/c_api/utils.h +++ b/src/c_api/utils.h @@ -7,7 +7,6 @@ // Please, refer to the LICENSE file in the root directory. // SPDX-License-Identifier: BSD-3-Clause // - #include #include From 3dac06d635a12c70c6e8dfa11db0d7e6616247b0 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Tue, 30 Apr 2024 14:16:52 +0200 Subject: [PATCH 18/62] Refactor of the code --- include/dlaf/matrix/panel.h | 1 - test/unit/multiplication/test_multiplication_general.cpp | 1 - 2 files changed, 2 deletions(-) diff --git a/include/dlaf/matrix/panel.h b/include/dlaf/matrix/panel.h index 15e8449633..498ed60697 100644 --- a/include/dlaf/matrix/panel.h +++ b/include/dlaf/matrix/panel.h @@ -1,4 +1,3 @@ - // // Distributed Linear Algebra with Future (DLAF) // diff --git a/test/unit/multiplication/test_multiplication_general.cpp b/test/unit/multiplication/test_multiplication_general.cpp index dae02f7714..644f67a7ec 100644 --- a/test/unit/multiplication/test_multiplication_general.cpp +++ b/test/unit/multiplication/test_multiplication_general.cpp @@ -1,4 +1,3 @@ - // // Distributed Linear Algebra with Future (DLAF) // From f9001132c1ad4b2a39a03e767149242135154d05 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Tue, 30 Apr 2024 17:22:11 +0200 Subject: [PATCH 19/62] add inshpect.yml --- .github/workflows/inshpect.yml | 44 ++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 .github/workflows/inshpect.yml diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml new file mode 100644 index 0000000000..b81421524d --- /dev/null +++ b/.github/workflows/inshpect.yml @@ -0,0 +1,44 @@ +name: Docs + +on: + push: + tags: + - 'v[0-9]+.[0-9]+.[0-9]+' + branches: + - master + pull_request: + branches: + - master + +jobs: + doc: + runs-on: ubuntu-22.04 + + steps: + - name: Install tools + run: | + sudo apt-get update + sudo apt-get install --no-install-recommends doxygen + - name: Checkout + uses: actions/checkout@v4 + - name: Make Docs + run: | + cd doc && make doc && cd .. + - name: Push Docs master + if: "github.repository == 'eth-cscs/DLA-Future' && github.ref == 'refs/heads/master'" + run: | + mv doc/html master + COMMIT_MSG=`git log -n 1 --pretty=format:%s` + git config user.name "Doc CI Action" && git config user.email "rasolca@users.noreply.github.com" + git fetch --no-tags --depth=1 origin +refs/heads/docs:refs/heads/docs + git symbolic-ref HEAD refs/heads/docs && git reset + git add master && git commit --allow-empty -m "Doc: $COMMIT_MSG" && git push --set-upstream origin docs + - name: Push Docs release + if: "github.repository == 'eth-cscs/DLA-Future' && startsWith(github.ref, 'refs/tags/v')" + run: | + TAG=${{ github.ref_name }} + mv doc/html $TAG + git config user.name "Doc CI Action" && git config user.email "rasolca@users.noreply.github.com" + git fetch --no-tags --depth=1 origin +refs/heads/docs:refs/heads/docs + git symbolic-ref HEAD refs/heads/docs && git reset + git add $TAG && git commit --allow-empty -m "Doc: add $TAG documentation" && git push --set-upstream origin docs From e03c713a9aea5a2ec20bc632c0405d65bfc4fc82 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Fri, 3 May 2024 15:05:58 +0200 Subject: [PATCH 20/62] add inshpect.yml file --- .github/workflows/inshpect.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index b81421524d..5e8612dc69 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -1,4 +1,4 @@ -name: Docs +name: Inshepct on: push: From 8b1387af32fc8664d64b50936d92ebdda18207c5 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Mon, 6 May 2024 10:24:57 +0200 Subject: [PATCH 21/62] add install tools --- .github/workflows/inshpect.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index 5e8612dc69..8d836b300c 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -18,7 +18,10 @@ jobs: - name: Install tools run: | sudo apt-get update - sudo apt-get install --no-install-recommends doxygen + sudo apt-get install -y fd-find ripgrep + wget -q https://github.com/tomwright/dasel/releases/download/v2.0.0/dasel-linux-amd64 -O /tmp/dasel + sudo mv /tmp/dasel /usr/local/bin/dasel + sudo chmod +x /usr/local/bin/dasel - name: Checkout uses: actions/checkout@v4 - name: Make Docs From f0b014a37258299c2bebf5becbcd66178c5c9090 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Mon, 6 May 2024 11:36:04 +0200 Subject: [PATCH 22/62] add other two steps: Checkout, Inshpect --- .github/workflows/check_format.yml | 7 ------- .github/workflows/inshpect.yml | 25 +++++-------------------- 2 files changed, 5 insertions(+), 27 deletions(-) diff --git a/.github/workflows/check_format.yml b/.github/workflows/check_format.yml index f61743c81d..fdfddf2bcf 100644 --- a/.github/workflows/check_format.yml +++ b/.github/workflows/check_format.yml @@ -83,10 +83,3 @@ jobs: done test ! -s pragma-once.check - - - name: Inshpect - if: always() - run: | - export INSHPECT_NUMTHREADS=4 - export INSHPECT_FD=fdfind - inshpect . .inshpect.toml diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index 8d836b300c..853d900d0d 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -24,24 +24,9 @@ jobs: sudo chmod +x /usr/local/bin/dasel - name: Checkout uses: actions/checkout@v4 - - name: Make Docs + - name: Inshpect + if: always() run: | - cd doc && make doc && cd .. - - name: Push Docs master - if: "github.repository == 'eth-cscs/DLA-Future' && github.ref == 'refs/heads/master'" - run: | - mv doc/html master - COMMIT_MSG=`git log -n 1 --pretty=format:%s` - git config user.name "Doc CI Action" && git config user.email "rasolca@users.noreply.github.com" - git fetch --no-tags --depth=1 origin +refs/heads/docs:refs/heads/docs - git symbolic-ref HEAD refs/heads/docs && git reset - git add master && git commit --allow-empty -m "Doc: $COMMIT_MSG" && git push --set-upstream origin docs - - name: Push Docs release - if: "github.repository == 'eth-cscs/DLA-Future' && startsWith(github.ref, 'refs/tags/v')" - run: | - TAG=${{ github.ref_name }} - mv doc/html $TAG - git config user.name "Doc CI Action" && git config user.email "rasolca@users.noreply.github.com" - git fetch --no-tags --depth=1 origin +refs/heads/docs:refs/heads/docs - git symbolic-ref HEAD refs/heads/docs && git reset - git add $TAG && git commit --allow-empty -m "Doc: add $TAG documentation" && git push --set-upstream origin docs + export INSHPECT_NUMTHREADS=4 + export INSHPECT_FD=fdfind + inshpect . .inshpect.toml From 7151621d488c529ecfe6defb455621f23c7b3d39 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Mon, 6 May 2024 11:55:15 +0200 Subject: [PATCH 23/62] add install insphect --- .github/workflows/check_format.yml | 9 --------- .github/workflows/inshpect.yml | 8 ++++++++ 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/.github/workflows/check_format.yml b/.github/workflows/check_format.yml index b0578cfa75..a970d1af7f 100644 --- a/.github/workflows/check_format.yml +++ b/.github/workflows/check_format.yml @@ -37,15 +37,6 @@ jobs: mv dasel /usr/local/bin popd - pushd /tmp - curl --output inshpect \ - --location https://raw.githubusercontent.com/msimberg/inshpect/f7b6045cdf832da30be1b0fb88a35827cc443ffa/inshpect - sha256sum inshpect - echo "04b6160cc0b1a45a38db319617697a0bb6a0c1413313d945a4ba73811dd5288a inshpect" | sha256sum --check - chmod +x inshpect - mv inshpect /usr/local/bin - popd - pushd /tmp curl --output ripgrep.tar.gz \ --location https://github.com/BurntSushi/ripgrep/releases/download/13.0.0/ripgrep-13.0.0-x86_64-unknown-linux-musl.tar.gz diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index 853d900d0d..330c6e8c21 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -22,6 +22,14 @@ jobs: wget -q https://github.com/tomwright/dasel/releases/download/v2.0.0/dasel-linux-amd64 -O /tmp/dasel sudo mv /tmp/dasel /usr/local/bin/dasel sudo chmod +x /usr/local/bin/dasel + pushd /tmp + curl --output inshpect \ + --location https://raw.githubusercontent.com/msimberg/inshpect/f7b6045cdf832da30be1b0fb88a35827cc443ffa/inshpect + sha256sum inshpect + echo "04b6160cc0b1a45a38db319617697a0bb6a0c1413313d945a4ba73811dd5288a inshpect" | sha256sum --check + chmod +x inshpect + mv inshpect /usr/local/bin + popd - name: Checkout uses: actions/checkout@v4 - name: Inshpect From 86f20f09662a64adb5feafde500ff9c66ce4c2d5 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Mon, 6 May 2024 11:56:47 +0200 Subject: [PATCH 24/62] add set -x --- .github/workflows/inshpect.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index 330c6e8c21..a8d3f89a1b 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -17,6 +17,7 @@ jobs: steps: - name: Install tools run: | + set -x sudo apt-get update sudo apt-get install -y fd-find ripgrep wget -q https://github.com/tomwright/dasel/releases/download/v2.0.0/dasel-linux-amd64 -O /tmp/dasel From f053415963930a94e9399d5584afa8ba08e9143d Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Mon, 6 May 2024 12:06:28 +0200 Subject: [PATCH 25/62] change the url for dasel with the latest version --- .github/workflows/inshpect.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index a8d3f89a1b..d212078dc8 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -20,7 +20,7 @@ jobs: set -x sudo apt-get update sudo apt-get install -y fd-find ripgrep - wget -q https://github.com/tomwright/dasel/releases/download/v2.0.0/dasel-linux-amd64 -O /tmp/dasel + wget -q https://github.com/TomWright/dasel/releases/download/v2.7.0/dasel_linux_amd64 -O /tmp/dasel sudo mv /tmp/dasel /usr/local/bin/dasel sudo chmod +x /usr/local/bin/dasel pushd /tmp From cd817d0f0c43dea373ca301c992560c419d8afac Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Mon, 6 May 2024 12:14:15 +0200 Subject: [PATCH 26/62] change url for insphect --- .github/workflows/inshpect.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index d212078dc8..5be1c18c7c 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -25,7 +25,7 @@ jobs: sudo chmod +x /usr/local/bin/dasel pushd /tmp curl --output inshpect \ - --location https://raw.githubusercontent.com/msimberg/inshpect/f7b6045cdf832da30be1b0fb88a35827cc443ffa/inshpect + --location https://github.com/msimberg/inshpect.git sha256sum inshpect echo "04b6160cc0b1a45a38db319617697a0bb6a0c1413313d945a4ba73811dd5288a inshpect" | sha256sum --check chmod +x inshpect From d6d367d7c1635ee158fa1c27454baf4cc5fabf01 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Mon, 6 May 2024 15:47:53 +0200 Subject: [PATCH 27/62] change url for inshpect download --- .github/workflows/inshpect.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index 5be1c18c7c..fc4b6d0343 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -25,9 +25,9 @@ jobs: sudo chmod +x /usr/local/bin/dasel pushd /tmp curl --output inshpect \ - --location https://github.com/msimberg/inshpect.git + --location https://raw.githubusercontent.com/msimberg/inshpect/d31ba8ed7e636c57cb9085ed3a8450d998e6b8a5/inshpect sha256sum inshpect - echo "04b6160cc0b1a45a38db319617697a0bb6a0c1413313d945a4ba73811dd5288a inshpect" | sha256sum --check + echo "4b891a178fa99ac800b9b92acc0596d72f640ca1ae6de7f35ac4b3785dcd7af9 inshpect" | sha256sum --check chmod +x inshpect mv inshpect /usr/local/bin popd From 3d7b48362e45f38e6702720781c2df3793581897 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Mon, 6 May 2024 15:51:21 +0200 Subject: [PATCH 28/62] add ripgrep download directly --- .github/workflows/check_format.yml | 8 -------- .github/workflows/inshpect.yml | 9 ++++++++- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/.github/workflows/check_format.yml b/.github/workflows/check_format.yml index a970d1af7f..6ae8ed05a7 100644 --- a/.github/workflows/check_format.yml +++ b/.github/workflows/check_format.yml @@ -37,14 +37,6 @@ jobs: mv dasel /usr/local/bin popd - pushd /tmp - curl --output ripgrep.tar.gz \ - --location https://github.com/BurntSushi/ripgrep/releases/download/13.0.0/ripgrep-13.0.0-x86_64-unknown-linux-musl.tar.gz - echo "ee4e0751ab108b6da4f47c52da187d5177dc371f0f512a7caaec5434e711c091 ripgrep.tar.gz" | sha256sum --check - tar --extract --strip-components 1 --file ripgrep.tar.gz - mv rg /usr/local/bin - popd - - name: Fetch master run: git fetch --no-tags --depth=1 origin +refs/heads/master:refs/heads/master diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index fc4b6d0343..4c60f6e59c 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -19,7 +19,7 @@ jobs: run: | set -x sudo apt-get update - sudo apt-get install -y fd-find ripgrep + sudo apt-get install -y fd-find wget -q https://github.com/TomWright/dasel/releases/download/v2.7.0/dasel_linux_amd64 -O /tmp/dasel sudo mv /tmp/dasel /usr/local/bin/dasel sudo chmod +x /usr/local/bin/dasel @@ -31,6 +31,13 @@ jobs: chmod +x inshpect mv inshpect /usr/local/bin popd + pushd /tmp + curl --output ripgrep.tar.gz \ + --location https://github.com/BurntSushi/ripgrep/releases/download/13.0.0/ripgrep-13.0.0-x86_64-unknown-linux-musl.tar.gz + echo "ee4e0751ab108b6da4f47c52da187d5177dc371f0f512a7caaec5434e711c091 ripgrep.tar.gz" | sha256sum --check + tar --extract --strip-components 1 --file ripgrep.tar.gz + mv rg /usr/local/bin + popd - name: Checkout uses: actions/checkout@v4 - name: Inshpect From 5146bcef4e33cad9dce0a63f8b9ada42e5506aff Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Mon, 6 May 2024 15:53:23 +0200 Subject: [PATCH 29/62] debug --- src/c_api/utils.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/c_api/utils.h b/src/c_api/utils.h index f32678cd82..9526b27d06 100644 --- a/src/c_api/utils.h +++ b/src/c_api/utils.h @@ -7,7 +7,6 @@ // Please, refer to the LICENSE file in the root directory. // SPDX-License-Identifier: BSD-3-Clause // -#include #pragma once From 336e9d6a7a7d61d14123597acbaabdee4d8073ec Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Mon, 6 May 2024 15:55:22 +0200 Subject: [PATCH 30/62] FINISH --- .github/workflows/check_format.yml | 8 ++++++++ src/c_api/utils.h | 1 + 2 files changed, 9 insertions(+) diff --git a/.github/workflows/check_format.yml b/.github/workflows/check_format.yml index 6ae8ed05a7..a970d1af7f 100644 --- a/.github/workflows/check_format.yml +++ b/.github/workflows/check_format.yml @@ -37,6 +37,14 @@ jobs: mv dasel /usr/local/bin popd + pushd /tmp + curl --output ripgrep.tar.gz \ + --location https://github.com/BurntSushi/ripgrep/releases/download/13.0.0/ripgrep-13.0.0-x86_64-unknown-linux-musl.tar.gz + echo "ee4e0751ab108b6da4f47c52da187d5177dc371f0f512a7caaec5434e711c091 ripgrep.tar.gz" | sha256sum --check + tar --extract --strip-components 1 --file ripgrep.tar.gz + mv rg /usr/local/bin + popd + - name: Fetch master run: git fetch --no-tags --depth=1 origin +refs/heads/master:refs/heads/master diff --git a/src/c_api/utils.h b/src/c_api/utils.h index 9526b27d06..f32678cd82 100644 --- a/src/c_api/utils.h +++ b/src/c_api/utils.h @@ -7,6 +7,7 @@ // Please, refer to the LICENSE file in the root directory. // SPDX-License-Identifier: BSD-3-Clause // +#include #pragma once From d5a1f62b234a1e46d6be2f8374423e6b97798baa Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Sun, 12 May 2024 22:00:51 +0200 Subject: [PATCH 31/62] Update .github/workflows/inshpect.yml --- .github/workflows/check_format.yml | 13 ------------- .github/workflows/inshpect.yml | 5 ----- 2 files changed, 18 deletions(-) diff --git a/.github/workflows/check_format.yml b/.github/workflows/check_format.yml index a970d1af7f..5fface7872 100644 --- a/.github/workflows/check_format.yml +++ b/.github/workflows/check_format.yml @@ -48,19 +48,6 @@ jobs: - name: Fetch master run: git fetch --no-tags --depth=1 origin +refs/heads/master:refs/heads/master - # Fails if there are tabs in source files. - # - name: Check formatting - # run: ./.github/format.sh - - # - name: Check scripts formatting - # if: always() - # run: black --line-length 105 scripts/ - - # # Fails if there are differences. - # - name: Formatting issues - # if: always() - # run: git diff --color --exit-code - - name: Check include guards if: always() run: | diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index 4c60f6e59c..981b12579c 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -1,11 +1,6 @@ name: Inshepct on: - push: - tags: - - 'v[0-9]+.[0-9]+.[0-9]+' - branches: - - master pull_request: branches: - master From f1371aa58003c4a75f97957c62054fd02a4419da Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Sun, 12 May 2024 22:05:17 +0200 Subject: [PATCH 32/62] Remove from my stage inshpect.output --- inshpect.output | 2 -- 1 file changed, 2 deletions(-) delete mode 100644 inshpect.output diff --git a/inshpect.output b/inshpect.output deleted file mode 100644 index e8ce7f1b06..0000000000 --- a/inshpect.output +++ /dev/null @@ -1,2 +0,0 @@ -# Includes - From 6cb82b0931fd4174481c3e592e5badb6f2de5a02 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Sun, 12 May 2024 22:08:36 +0200 Subject: [PATCH 33/62] Review changes --- include/dlaf/common/callable_object.h | 5 +++-- include/dlaf/communication/sync/basic.h | 4 ++-- include/dlaf/eigensolver/gen_to_std/impl.h | 4 ++-- include/dlaf/matrix/print_csv.h | 5 ++--- include/dlaf/multiplication/hermitian/impl.h | 4 ++-- src/init.cpp | 1 - 6 files changed, 11 insertions(+), 12 deletions(-) diff --git a/include/dlaf/common/callable_object.h b/include/dlaf/common/callable_object.h index d40ae2e2d3..8038a89f5e 100644 --- a/include/dlaf/common/callable_object.h +++ b/include/dlaf/common/callable_object.h @@ -8,8 +8,6 @@ // SPDX-License-Identifier: BSD-3-Clause // -#include - #pragma once /// @file @@ -25,6 +23,9 @@ /// The function name is wrapped in parentheses to disable ADL. It is assumed /// that all required overloads are found relative to the namespace where the /// macro is used. + +#include + #define DLAF_MAKE_CALLABLE_OBJECT(fname) \ constexpr struct fname##_t { \ template \ diff --git a/include/dlaf/communication/sync/basic.h b/include/dlaf/communication/sync/basic.h index 833a915006..3ae5722502 100644 --- a/include/dlaf/communication/sync/basic.h +++ b/include/dlaf/communication/sync/basic.h @@ -8,12 +8,12 @@ // SPDX-License-Identifier: BSD-3-Clause // -#include - #pragma once /// @file +#include + #include #include #include diff --git a/include/dlaf/eigensolver/gen_to_std/impl.h b/include/dlaf/eigensolver/gen_to_std/impl.h index bc24cc9ea7..83a5e8ee0d 100644 --- a/include/dlaf/eigensolver/gen_to_std/impl.h +++ b/include/dlaf/eigensolver/gen_to_std/impl.h @@ -8,11 +8,11 @@ // SPDX-License-Identifier: BSD-3-Clause // +#pragma once + #include #include -#pragma once - #include #include diff --git a/include/dlaf/matrix/print_csv.h b/include/dlaf/matrix/print_csv.h index 33fe47460f..a5850c2463 100644 --- a/include/dlaf/matrix/print_csv.h +++ b/include/dlaf/matrix/print_csv.h @@ -8,13 +8,12 @@ // SPDX-License-Identifier: BSD-3-Clause // -#include -#include - #pragma once /// @file +#include +#include #include #include diff --git a/include/dlaf/multiplication/hermitian/impl.h b/include/dlaf/multiplication/hermitian/impl.h index 4fab8a6493..4f3b4ae8d8 100644 --- a/include/dlaf/multiplication/hermitian/impl.h +++ b/include/dlaf/multiplication/hermitian/impl.h @@ -8,11 +8,11 @@ // SPDX-License-Identifier: BSD-3-Clause // +#pragma once + #include #include -#pragma once - #include #include diff --git a/src/init.cpp b/src/init.cpp index d7a438a052..c03b2b8b63 100644 --- a/src/init.cpp +++ b/src/init.cpp @@ -190,7 +190,6 @@ void updateConfiguration(const pika::program_options::variables_map& vm, configu updateConfigurationValue(vm, cfg.umpire_device_memory_pool_initial_bytes, "UMPIRE_DEVICE_MEMORY_POOL_INITIAL_BYTES", "umpire-device-memory-pool-initial-bytes"); - // TODO: Warn if disabled cfg.mpi_pool = (pika::resource::pool_exists("mpi")) ? "mpi" : "default"; // Warn if not using MPI pool without --dlaf:no-mpi-pool From b98fb7e4408fca0a2c5f057b3943c274cd55d052 Mon Sep 17 00:00:00 2001 From: guglielmogagliardi <94535690+gulivarese@users.noreply.github.com> Date: Sun, 12 May 2024 22:15:58 +0200 Subject: [PATCH 34/62] Update impl.h --- include/dlaf/multiplication/triangular/impl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/dlaf/multiplication/triangular/impl.h b/include/dlaf/multiplication/triangular/impl.h index 4ed22837ec..8132c377c3 100644 --- a/include/dlaf/multiplication/triangular/impl.h +++ b/include/dlaf/multiplication/triangular/impl.h @@ -8,11 +8,11 @@ // SPDX-License-Identifier: BSD-3-Clause // +#pragma once + #include #include -#pragma once - #include #include From 650dd85829a1d7f84314e240d2d287d7e0009077 Mon Sep 17 00:00:00 2001 From: guglielmogagliardi <94535690+gulivarese@users.noreply.github.com> Date: Sun, 12 May 2024 22:17:20 +0200 Subject: [PATCH 35/62] Update impl.h --- include/dlaf/factorization/cholesky/impl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/dlaf/factorization/cholesky/impl.h b/include/dlaf/factorization/cholesky/impl.h index e8cc57a6d7..4eb9280b5a 100644 --- a/include/dlaf/factorization/cholesky/impl.h +++ b/include/dlaf/factorization/cholesky/impl.h @@ -8,11 +8,11 @@ // SPDX-License-Identifier: BSD-3-Clause // +#pragma once + #include #include -#pragma once - #include #include From 6e1929f01c8c632444c359e872c517b0702e36e7 Mon Sep 17 00:00:00 2001 From: guglielmogagliardi <94535690+gulivarese@users.noreply.github.com> Date: Sun, 12 May 2024 22:18:47 +0200 Subject: [PATCH 36/62] Update impl.h --- include/dlaf/solver/triangular/impl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/dlaf/solver/triangular/impl.h b/include/dlaf/solver/triangular/impl.h index 95843d7433..f1fa273753 100644 --- a/include/dlaf/solver/triangular/impl.h +++ b/include/dlaf/solver/triangular/impl.h @@ -8,11 +8,11 @@ // SPDX-License-Identifier: BSD-3-Clause // +#pragma once + #include #include -#pragma once - #include #include From 17d14da110f981f51e0f54cd2687c2625ab47bb2 Mon Sep 17 00:00:00 2001 From: guglielmogagliardi <94535690+gulivarese@users.noreply.github.com> Date: Sun, 12 May 2024 22:20:00 +0200 Subject: [PATCH 37/62] Update kernel_runner.h --- miniapp/include/dlaf/miniapp/kernel_runner.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/miniapp/include/dlaf/miniapp/kernel_runner.h b/miniapp/include/dlaf/miniapp/kernel_runner.h index d07459496b..1223f344ea 100644 --- a/miniapp/include/dlaf/miniapp/kernel_runner.h +++ b/miniapp/include/dlaf/miniapp/kernel_runner.h @@ -8,10 +8,10 @@ // SPDX-License-Identifier: BSD-3-Clause // -#include - #pragma once +#include + #ifdef DLAF_WITH_GPU #include #endif From a1303666634e427cf43ecd396a11f1787baf1be0 Mon Sep 17 00:00:00 2001 From: guglielmogagliardi <94535690+gulivarese@users.noreply.github.com> Date: Sun, 12 May 2024 22:21:00 +0200 Subject: [PATCH 38/62] Update utils.h --- src/c_api/utils.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/c_api/utils.h b/src/c_api/utils.h index f32678cd82..e2db52ecfb 100644 --- a/src/c_api/utils.h +++ b/src/c_api/utils.h @@ -7,10 +7,11 @@ // Please, refer to the LICENSE file in the root directory. // SPDX-License-Identifier: BSD-3-Clause // -#include #pragma once +#include + #include #include #include From a09b80e19a5c57b89f666c50c44baea643010e55 Mon Sep 17 00:00:00 2001 From: guglielmogagliardi <94535690+gulivarese@users.noreply.github.com> Date: Sun, 12 May 2024 22:22:49 +0200 Subject: [PATCH 39/62] Update invoke.h --- test/include/dlaf_test/blas/invoke.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/include/dlaf_test/blas/invoke.h b/test/include/dlaf_test/blas/invoke.h index 8143eb4370..bb99f7dad1 100644 --- a/test/include/dlaf_test/blas/invoke.h +++ b/test/include/dlaf_test/blas/invoke.h @@ -8,14 +8,14 @@ // SPDX-License-Identifier: BSD-3-Clause // -#include - #pragma once #ifdef DLAF_WITH_GPU #include #endif +#include + #include #ifdef DLAF_WITH_GPU From 9db38741d022279e7e7178cd018f2cbb56b28cbc Mon Sep 17 00:00:00 2001 From: guglielmogagliardi <94535690+gulivarese@users.noreply.github.com> Date: Sun, 12 May 2024 22:24:35 +0200 Subject: [PATCH 40/62] Update invoke.h --- test/include/dlaf_test/lapack/invoke.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/include/dlaf_test/lapack/invoke.h b/test/include/dlaf_test/lapack/invoke.h index 1484e3ce31..1ab1b92823 100644 --- a/test/include/dlaf_test/lapack/invoke.h +++ b/test/include/dlaf_test/lapack/invoke.h @@ -8,14 +8,14 @@ // SPDX-License-Identifier: BSD-3-Clause // -#include - #pragma once #ifdef DLAF_WITH_GPU #include #endif +#include + #include #ifdef DLAF_WITH_GPU From 9ab061e8082cb36d05b9c8f8ee92a371a8ea56e4 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Tue, 14 May 2024 09:06:54 +0200 Subject: [PATCH 41/62] Remove set -x in inshpect.yml --- .github/workflows/inshpect.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index 981b12579c..664175475b 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -12,7 +12,6 @@ jobs: steps: - name: Install tools run: | - set -x sudo apt-get update sudo apt-get install -y fd-find wget -q https://github.com/TomWright/dasel/releases/download/v2.7.0/dasel_linux_amd64 -O /tmp/dasel From 9d7bf607499d7e66e3170f793168bcccddae6272 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Tue, 14 May 2024 09:13:13 +0200 Subject: [PATCH 42/62] Refresh with curl --- .github/workflows/inshpect.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index 664175475b..2122390816 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -12,9 +12,9 @@ jobs: steps: - name: Install tools run: | - sudo apt-get update - sudo apt-get install -y fd-find - wget -q https://github.com/TomWright/dasel/releases/download/v2.7.0/dasel_linux_amd64 -O /tmp/dasel + sudo apt update + sudo apt install -y fd-find + curl -sL https://github.com/TomWright/dasel/releases/download/v2.7.0/dasel_linux_amd64 -o /tmp/dasel sudo mv /tmp/dasel /usr/local/bin/dasel sudo chmod +x /usr/local/bin/dasel pushd /tmp From 5a37d4f3174ce90fd509e3d796b27ab11b9337f6 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Tue, 14 May 2024 13:34:15 +0200 Subject: [PATCH 43/62] add two pattern about #include --- .inshpect.toml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.inshpect.toml b/.inshpect.toml index c04b57bfa0..a29b864060 100644 --- a/.inshpect.toml +++ b/.inshpect.toml @@ -120,6 +120,8 @@ patterns = [ { pattern = '\bstd::underlying_type\b', include = 'type_traits' }, { pattern = '\bstd::result_of\b', include = 'type_traits' }, { pattern = '\bstd::is_invocable([a-z_]*)\b', include = 'type_traits' }, + { pattern = '\btypeid\b', include = 'typeinfo' }, + { pattern = '\bstd::type_info\b', include = 'typeinfo' }, { pattern = '\bstd::(mem((set)|(cpy)|(move)))\b', include = 'cstring' }, { pattern = '\bstd::swap\b', include = 'utility' }, { pattern = '\bstd::move\b', include = 'utility' }, From 7e4a43ffe65e060f169af6abef0dbf327d604405 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Tue, 14 May 2024 13:38:36 +0200 Subject: [PATCH 44/62] modify settings of VScode --- include/dlaf/matrix/print_csv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/dlaf/matrix/print_csv.h b/include/dlaf/matrix/print_csv.h index a5850c2463..95bb3a46e4 100644 --- a/include/dlaf/matrix/print_csv.h +++ b/include/dlaf/matrix/print_csv.h @@ -77,4 +77,4 @@ void print(format::csv, std::string sym, Matrix& mat, } } } -} +} \ No newline at end of file From 0c22ea366f95dccb35650d362f228638e1bebcdb Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Wed, 15 May 2024 00:46:48 +0200 Subject: [PATCH 45/62] Add #include --- test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp | 1 + test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp | 1 + test/unit/c_api/factorization/test_cholesky_c_api.cpp | 1 + 3 files changed, 3 insertions(+) diff --git a/test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp b/test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp index 21076425e5..429a322b22 100644 --- a/test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp +++ b/test/unit/c_api/eigensolver/test_eigensolver_c_api.cpp @@ -10,6 +10,7 @@ #include #include +#include #include #include diff --git a/test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp b/test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp index 728492d05a..806678571f 100644 --- a/test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp +++ b/test/unit/c_api/eigensolver/test_gen_eigensolver_c_api.cpp @@ -10,6 +10,7 @@ #include #include +#include #include #include diff --git a/test/unit/c_api/factorization/test_cholesky_c_api.cpp b/test/unit/c_api/factorization/test_cholesky_c_api.cpp index 350f97c83b..8ff3f3be83 100644 --- a/test/unit/c_api/factorization/test_cholesky_c_api.cpp +++ b/test/unit/c_api/factorization/test_cholesky_c_api.cpp @@ -10,6 +10,7 @@ #include #include +#include #include #include From bdb33a6cf2a2784c72c6e85cd231e4bcc27ed6b7 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Wed, 15 May 2024 11:10:29 +0200 Subject: [PATCH 46/62] Update inshpect.yml, callable_object.h, invoke.h --- .github/workflows/inshpect.yml | 5 ++--- include/dlaf/common/callable_object.h | 4 ++-- test/include/dlaf_test/blas/invoke.h | 4 ++-- test/include/dlaf_test/lapack/invoke.h | 4 ++-- 4 files changed, 8 insertions(+), 9 deletions(-) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index 2122390816..1b8cfb7d49 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -2,8 +2,6 @@ name: Inshepct on: pull_request: - branches: - - master jobs: doc: @@ -14,7 +12,8 @@ jobs: run: | sudo apt update sudo apt install -y fd-find - curl -sL https://github.com/TomWright/dasel/releases/download/v2.7.0/dasel_linux_amd64 -o /tmp/dasel + curl --output /tmp/dasel \ + --location https://github.com/TomWright/dasel/releases/download/v2.7.0/dasel_linux_amd64 sudo mv /tmp/dasel /usr/local/bin/dasel sudo chmod +x /usr/local/bin/dasel pushd /tmp diff --git a/include/dlaf/common/callable_object.h b/include/dlaf/common/callable_object.h index 8038a89f5e..7b253d34ae 100644 --- a/include/dlaf/common/callable_object.h +++ b/include/dlaf/common/callable_object.h @@ -10,6 +10,8 @@ #pragma once +#include + /// @file /// Given a function name @fname generates a constexpr object with name fname_o @@ -24,8 +26,6 @@ /// that all required overloads are found relative to the namespace where the /// macro is used. -#include - #define DLAF_MAKE_CALLABLE_OBJECT(fname) \ constexpr struct fname##_t { \ template \ diff --git a/test/include/dlaf_test/blas/invoke.h b/test/include/dlaf_test/blas/invoke.h index bb99f7dad1..8143eb4370 100644 --- a/test/include/dlaf_test/blas/invoke.h +++ b/test/include/dlaf_test/blas/invoke.h @@ -8,14 +8,14 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #pragma once #ifdef DLAF_WITH_GPU #include #endif -#include - #include #ifdef DLAF_WITH_GPU diff --git a/test/include/dlaf_test/lapack/invoke.h b/test/include/dlaf_test/lapack/invoke.h index 1ab1b92823..1484e3ce31 100644 --- a/test/include/dlaf_test/lapack/invoke.h +++ b/test/include/dlaf_test/lapack/invoke.h @@ -8,14 +8,14 @@ // SPDX-License-Identifier: BSD-3-Clause // +#include + #pragma once #ifdef DLAF_WITH_GPU #include #endif -#include - #include #ifdef DLAF_WITH_GPU From d88ad21cf32c76307228dc0fc813690bb069c2ef Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Wed, 15 May 2024 16:36:38 +0200 Subject: [PATCH 47/62] Update .github/workflows/inshpect.yml --- .github/workflows/inshpect.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index 1b8cfb7d49..ee13109e8d 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -1,4 +1,4 @@ -name: Inshepct +name: Inshpect on: pull_request: @@ -19,7 +19,6 @@ jobs: pushd /tmp curl --output inshpect \ --location https://raw.githubusercontent.com/msimberg/inshpect/d31ba8ed7e636c57cb9085ed3a8450d998e6b8a5/inshpect - sha256sum inshpect echo "4b891a178fa99ac800b9b92acc0596d72f640ca1ae6de7f35ac4b3785dcd7af9 inshpect" | sha256sum --check chmod +x inshpect mv inshpect /usr/local/bin From af4993d19a6a15f73b0a8ab7ed128f033ff2a55a Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Thu, 16 May 2024 15:41:53 +0200 Subject: [PATCH 48/62] Update inshpect.yml file --- .github/workflows/inshpect.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index ee13109e8d..3f0d756e4d 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -4,7 +4,7 @@ on: pull_request: jobs: - doc: + inshpect: runs-on: ubuntu-22.04 steps: From d804bbc72a0ed6e924a928ed4ff929a49876065a Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Thu, 16 May 2024 15:45:10 +0200 Subject: [PATCH 49/62] Refactor code --- .github/workflows/inshpect.yml | 2 ++ test/include/dlaf_test/blas/invoke.h | 3 ++- test/include/dlaf_test/lapack/invoke.h | 4 ++-- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index 3f0d756e4d..b42a5cde70 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -12,6 +12,8 @@ jobs: run: | sudo apt update sudo apt install -y fd-find + + curl --output /tmp/dasel \ --location https://github.com/TomWright/dasel/releases/download/v2.7.0/dasel_linux_amd64 sudo mv /tmp/dasel /usr/local/bin/dasel diff --git a/test/include/dlaf_test/blas/invoke.h b/test/include/dlaf_test/blas/invoke.h index 8143eb4370..f99319e848 100644 --- a/test/include/dlaf_test/blas/invoke.h +++ b/test/include/dlaf_test/blas/invoke.h @@ -8,7 +8,6 @@ // SPDX-License-Identifier: BSD-3-Clause // -#include #pragma once @@ -16,6 +15,8 @@ #include #endif +#include + #include #ifdef DLAF_WITH_GPU diff --git a/test/include/dlaf_test/lapack/invoke.h b/test/include/dlaf_test/lapack/invoke.h index 1484e3ce31..1ab1b92823 100644 --- a/test/include/dlaf_test/lapack/invoke.h +++ b/test/include/dlaf_test/lapack/invoke.h @@ -8,14 +8,14 @@ // SPDX-License-Identifier: BSD-3-Clause // -#include - #pragma once #ifdef DLAF_WITH_GPU #include #endif +#include + #include #ifdef DLAF_WITH_GPU From a3188736d4e5b5479c60d30146af1ae1b1158d84 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Tue, 21 May 2024 15:13:10 +0200 Subject: [PATCH 50/62] Restore from origin/master about check_format.yml --- .github/workflows/check_format.yml | 34 +++++++++++++----------------- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/.github/workflows/check_format.yml b/.github/workflows/check_format.yml index 5fface7872..2b7440d059 100644 --- a/.github/workflows/check_format.yml +++ b/.github/workflows/check_format.yml @@ -11,7 +11,7 @@ name: Check format on: - - push + - pull_request jobs: check: @@ -24,30 +24,26 @@ jobs: - name: Install tools run: | sudo apt-get update - sudo apt-get install --no-install-recommends clang-format-15 fd-find python3 ripgrep + sudo apt-get install --no-install-recommends clang-format-15 python3 pip3 install black==23.03.0 pip3 install cmakelang==0.6.13 - pushd /tmp - curl --output dasel \ - --location https://github.com/TomWright/dasel/releases/download/v1.27.3/dasel_linux_amd64 - sha256sum dasel - echo "1a5adbf8e5b69f48ad5d1665bf7ed056ea3ff8cf3312ce2dc7c3209939873489 dasel" | sha256sum --check - chmod +x dasel - mv dasel /usr/local/bin - popd - - pushd /tmp - curl --output ripgrep.tar.gz \ - --location https://github.com/BurntSushi/ripgrep/releases/download/13.0.0/ripgrep-13.0.0-x86_64-unknown-linux-musl.tar.gz - echo "ee4e0751ab108b6da4f47c52da187d5177dc371f0f512a7caaec5434e711c091 ripgrep.tar.gz" | sha256sum --check - tar --extract --strip-components 1 --file ripgrep.tar.gz - mv rg /usr/local/bin - popd - - name: Fetch master run: git fetch --no-tags --depth=1 origin +refs/heads/master:refs/heads/master + # Fails if there are tabs in source files. + - name: Check formatting + run: ./.github/format.sh + + - name: Check scripts formatting + if: always() + run: black --line-length 105 scripts/ + + # Fails if there are differences. + - name: Formatting issues + if: always() + run: git diff --color --exit-code + - name: Check include guards if: always() run: | From 8eae8027a37f66071531a01fad526d2de9868f33 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Tue, 21 May 2024 15:18:25 +0200 Subject: [PATCH 51/62] Move #include --- test/include/dlaf_test/blas/invoke.h | 5 ++--- test/include/dlaf_test/lapack/invoke.h | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/test/include/dlaf_test/blas/invoke.h b/test/include/dlaf_test/blas/invoke.h index f99319e848..f9ec26bd81 100644 --- a/test/include/dlaf_test/blas/invoke.h +++ b/test/include/dlaf_test/blas/invoke.h @@ -8,15 +8,14 @@ // SPDX-License-Identifier: BSD-3-Clause // - #pragma once +#include + #ifdef DLAF_WITH_GPU #include #endif -#include - #include #ifdef DLAF_WITH_GPU diff --git a/test/include/dlaf_test/lapack/invoke.h b/test/include/dlaf_test/lapack/invoke.h index 1ab1b92823..cea16ea4e0 100644 --- a/test/include/dlaf_test/lapack/invoke.h +++ b/test/include/dlaf_test/lapack/invoke.h @@ -10,12 +10,12 @@ #pragma once +#include + #ifdef DLAF_WITH_GPU #include #endif -#include - #include #ifdef DLAF_WITH_GPU From 633f8eb87697f71278542de57b93845dd4102bec Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Tue, 21 May 2024 15:25:47 +0200 Subject: [PATCH 52/62] Delete two white lines and add one lines before curl command --- .github/workflows/inshpect.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index b42a5cde70..b6e9958ea5 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -13,11 +13,11 @@ jobs: sudo apt update sudo apt install -y fd-find - curl --output /tmp/dasel \ --location https://github.com/TomWright/dasel/releases/download/v2.7.0/dasel_linux_amd64 sudo mv /tmp/dasel /usr/local/bin/dasel sudo chmod +x /usr/local/bin/dasel + pushd /tmp curl --output inshpect \ --location https://raw.githubusercontent.com/msimberg/inshpect/d31ba8ed7e636c57cb9085ed3a8450d998e6b8a5/inshpect @@ -25,6 +25,7 @@ jobs: chmod +x inshpect mv inshpect /usr/local/bin popd + pushd /tmp curl --output ripgrep.tar.gz \ --location https://github.com/BurntSushi/ripgrep/releases/download/13.0.0/ripgrep-13.0.0-x86_64-unknown-linux-musl.tar.gz From bb01f905eca332a2afa06b1f479f548e049e3a54 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Tue, 21 May 2024 15:35:04 +0200 Subject: [PATCH 53/62] add echo and sha256sum --check for dasel --- .github/workflows/inshpect.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index b6e9958ea5..0082a11a6a 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -15,6 +15,7 @@ jobs: curl --output /tmp/dasel \ --location https://github.com/TomWright/dasel/releases/download/v2.7.0/dasel_linux_amd64 + echo "38decc82e0dcf9a5ccd22918b909a78c92ee0d919b4534b0a6d90c802936b1a0 /tmp/dasel" | sha256sum --check sudo mv /tmp/dasel /usr/local/bin/dasel sudo chmod +x /usr/local/bin/dasel From ed6e5a9edc7dc7587ce3458999d660429caf367b Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Tue, 21 May 2024 15:36:44 +0200 Subject: [PATCH 54/62] Add pushd and popd for dasel --- .github/workflows/inshpect.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index 0082a11a6a..b5c7379a72 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -13,11 +13,13 @@ jobs: sudo apt update sudo apt install -y fd-find - curl --output /tmp/dasel \ + pushd /tmp + curl --output dasel \ --location https://github.com/TomWright/dasel/releases/download/v2.7.0/dasel_linux_amd64 - echo "38decc82e0dcf9a5ccd22918b909a78c92ee0d919b4534b0a6d90c802936b1a0 /tmp/dasel" | sha256sum --check - sudo mv /tmp/dasel /usr/local/bin/dasel + echo "38decc82e0dcf9a5ccd22918b909a78c92ee0d919b4534b0a6d90c802936b1a0 asel" | sha256sum --check + sudo mv dasel /usr/local/bin/dasel sudo chmod +x /usr/local/bin/dasel + popd pushd /tmp curl --output inshpect \ From 00e9edf3adbaf2cd84ace765f59360cf09e30fb6 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Tue, 21 May 2024 15:37:23 +0200 Subject: [PATCH 55/62] Remove sudo command for dasel --- .github/workflows/inshpect.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index b5c7379a72..f2ac12e483 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -17,8 +17,8 @@ jobs: curl --output dasel \ --location https://github.com/TomWright/dasel/releases/download/v2.7.0/dasel_linux_amd64 echo "38decc82e0dcf9a5ccd22918b909a78c92ee0d919b4534b0a6d90c802936b1a0 asel" | sha256sum --check - sudo mv dasel /usr/local/bin/dasel - sudo chmod +x /usr/local/bin/dasel + mv dasel /usr/local/bin/dasel + chmod +x /usr/local/bin/dasel popd pushd /tmp From 575f44ba401b8db7cb2e9fcc2791bc4f137e4720 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Tue, 21 May 2024 15:39:35 +0200 Subject: [PATCH 56/62] remove path for dasel --- .github/workflows/inshpect.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index f2ac12e483..0a4fcfe891 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -17,8 +17,8 @@ jobs: curl --output dasel \ --location https://github.com/TomWright/dasel/releases/download/v2.7.0/dasel_linux_amd64 echo "38decc82e0dcf9a5ccd22918b909a78c92ee0d919b4534b0a6d90c802936b1a0 asel" | sha256sum --check - mv dasel /usr/local/bin/dasel - chmod +x /usr/local/bin/dasel + chmod +x dasel + mv dasel /usr/local/bin popd pushd /tmp @@ -26,7 +26,7 @@ jobs: --location https://raw.githubusercontent.com/msimberg/inshpect/d31ba8ed7e636c57cb9085ed3a8450d998e6b8a5/inshpect echo "4b891a178fa99ac800b9b92acc0596d72f640ca1ae6de7f35ac4b3785dcd7af9 inshpect" | sha256sum --check chmod +x inshpect - mv inshpect /usr/local/bin + mv inshpect /usr/local/bin/inshpect popd pushd /tmp From b21b982a3b6ea56bd33e368bddec762f72898476 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Tue, 21 May 2024 15:41:18 +0200 Subject: [PATCH 57/62] Move dependencies for inshpect before this --- .github/workflows/inshpect.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index 0a4fcfe891..e761d8446e 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -21,14 +21,6 @@ jobs: mv dasel /usr/local/bin popd - pushd /tmp - curl --output inshpect \ - --location https://raw.githubusercontent.com/msimberg/inshpect/d31ba8ed7e636c57cb9085ed3a8450d998e6b8a5/inshpect - echo "4b891a178fa99ac800b9b92acc0596d72f640ca1ae6de7f35ac4b3785dcd7af9 inshpect" | sha256sum --check - chmod +x inshpect - mv inshpect /usr/local/bin/inshpect - popd - pushd /tmp curl --output ripgrep.tar.gz \ --location https://github.com/BurntSushi/ripgrep/releases/download/13.0.0/ripgrep-13.0.0-x86_64-unknown-linux-musl.tar.gz @@ -36,6 +28,14 @@ jobs: tar --extract --strip-components 1 --file ripgrep.tar.gz mv rg /usr/local/bin popd + + pushd /tmp + curl --output inshpect \ + --location https://raw.githubusercontent.com/msimberg/inshpect/d31ba8ed7e636c57cb9085ed3a8450d998e6b8a5/inshpect + echo "4b891a178fa99ac800b9b92acc0596d72f640ca1ae6de7f35ac4b3785dcd7af9 inshpect" | sha256sum --check + chmod +x inshpect + mv inshpect /usr/local/bin/inshpect + popd - name: Checkout uses: actions/checkout@v4 - name: Inshpect From cc179939945db0d35bae2e6d41b64cd38629d885 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Tue, 21 May 2024 15:44:19 +0200 Subject: [PATCH 58/62] Debug: add set -x --- .github/workflows/inshpect.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index e761d8446e..9fe6add424 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -10,6 +10,8 @@ jobs: steps: - name: Install tools run: | + set -x + sudo apt update sudo apt install -y fd-find From 990b000a0a1600ac51bea2c7580ba0c67a12063d Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Tue, 21 May 2024 15:46:54 +0200 Subject: [PATCH 59/62] Add d for dasel --- .github/workflows/inshpect.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index 9fe6add424..257029c334 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -18,7 +18,7 @@ jobs: pushd /tmp curl --output dasel \ --location https://github.com/TomWright/dasel/releases/download/v2.7.0/dasel_linux_amd64 - echo "38decc82e0dcf9a5ccd22918b909a78c92ee0d919b4534b0a6d90c802936b1a0 asel" | sha256sum --check + echo "38decc82e0dcf9a5ccd22918b909a78c92ee0d919b4534b0a6d90c802936b1a0 dasel" | sha256sum --check chmod +x dasel mv dasel /usr/local/bin popd From 704d41f4873648a73c701c45afa3dcef7d174109 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Tue, 21 May 2024 15:50:55 +0200 Subject: [PATCH 60/62] Remove set -x for debug --- .github/workflows/inshpect.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index 257029c334..3ce1ea1a85 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -10,8 +10,6 @@ jobs: steps: - name: Install tools run: | - set -x - sudo apt update sudo apt install -y fd-find From 77dce976c706601f35dfc6ad0113bfd152116916 Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Wed, 22 May 2024 15:41:54 +0200 Subject: [PATCH 61/62] Add newline in print_csv.h --- include/dlaf/matrix/print_csv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/dlaf/matrix/print_csv.h b/include/dlaf/matrix/print_csv.h index 95bb3a46e4..a5850c2463 100644 --- a/include/dlaf/matrix/print_csv.h +++ b/include/dlaf/matrix/print_csv.h @@ -77,4 +77,4 @@ void print(format::csv, std::string sym, Matrix& mat, } } } -} \ No newline at end of file +} From e1696fb66a7b61c8c422ecd917458c8ba5b5323b Mon Sep 17 00:00:00 2001 From: Guglielmo Gagliardi Date: Wed, 22 May 2024 17:31:50 +0200 Subject: [PATCH 62/62] Install ripgrep and dasel with apt command, delete the formal installation of this two dependencies --- .github/workflows/inshpect.yml | 20 ++------------------ 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/.github/workflows/inshpect.yml b/.github/workflows/inshpect.yml index 3ce1ea1a85..9d4387f4b8 100644 --- a/.github/workflows/inshpect.yml +++ b/.github/workflows/inshpect.yml @@ -5,29 +5,13 @@ on: jobs: inshpect: - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 steps: - name: Install tools run: | sudo apt update - sudo apt install -y fd-find - - pushd /tmp - curl --output dasel \ - --location https://github.com/TomWright/dasel/releases/download/v2.7.0/dasel_linux_amd64 - echo "38decc82e0dcf9a5ccd22918b909a78c92ee0d919b4534b0a6d90c802936b1a0 dasel" | sha256sum --check - chmod +x dasel - mv dasel /usr/local/bin - popd - - pushd /tmp - curl --output ripgrep.tar.gz \ - --location https://github.com/BurntSushi/ripgrep/releases/download/13.0.0/ripgrep-13.0.0-x86_64-unknown-linux-musl.tar.gz - echo "ee4e0751ab108b6da4f47c52da187d5177dc371f0f512a7caaec5434e711c091 ripgrep.tar.gz" | sha256sum --check - tar --extract --strip-components 1 --file ripgrep.tar.gz - mv rg /usr/local/bin - popd + sudo apt install -y fd-find ripgrep dasel pushd /tmp curl --output inshpect \