From ec79533f3e5b3bcb3ea9d9561e8fbb1465d9a1a6 Mon Sep 17 00:00:00 2001 From: Eirini Koutsaniti Date: Wed, 16 Oct 2024 17:02:58 +0200 Subject: [PATCH 1/2] Run unittests for all PRs, not only the ones to main (#131) --- .github/workflows/testing.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index 4bdc28b..3a2e651 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -4,7 +4,6 @@ on: push: branches: [ main ] pull_request: - branches: [ main ] jobs: unittest: From 6da118ae8001e58fe3401881a47442da1bc7d7c6 Mon Sep 17 00:00:00 2001 From: Eirini Koutsaniti Date: Mon, 21 Oct 2024 10:37:55 +0200 Subject: [PATCH 2/2] Fix typing error --- firecrest/v2/AsyncClient.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/firecrest/v2/AsyncClient.py b/firecrest/v2/AsyncClient.py index 89eed15..a934fab 100644 --- a/firecrest/v2/AsyncClient.py +++ b/firecrest/v2/AsyncClient.py @@ -11,7 +11,7 @@ import logging import ssl -from typing import Any, Optional, overload +from typing import Any, List, Optional from packaging.version import Version, parse import firecrest.FirecrestException as fe