From b6e46dd6acaf0f93f676c8a1ca0e26f3c56b88c9 Mon Sep 17 00:00:00 2001 From: Keno Hassler <40292329+kenohassler@users.noreply.github.com> Date: Wed, 21 Feb 2024 13:28:48 +0100 Subject: [PATCH 1/6] simplify settingsAndSmiProvider --- src/nvidiautil@ethanwharris/settingsAndSmiProvider.js | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/nvidiautil@ethanwharris/settingsAndSmiProvider.js b/src/nvidiautil@ethanwharris/settingsAndSmiProvider.js index 8961f98..3a57873 100644 --- a/src/nvidiautil@ethanwharris/settingsAndSmiProvider.js +++ b/src/nvidiautil@ethanwharris/settingsAndSmiProvider.js @@ -20,18 +20,11 @@ export class SettingsAndSmiProvider { } getProperties(gpuCount) { - this.storedProperties = [ - new SettingsProperties.UtilisationProperty(gpuCount, Processor.NVIDIA_SETTINGS), - new SettingsProperties.TemperatureProperty(gpuCount, Processor.NVIDIA_SETTINGS), - new SettingsProperties.MemoryProperty(gpuCount, Processor.NVIDIA_SETTINGS), - new SettingsProperties.FanProperty(gpuCount, Processor.NVIDIA_SETTINGS), - new SmiProperties.PowerProperty(gpuCount, Processor.NVIDIA_SMI), - ]; - return this.storedProperties; + return this.smi.getProperties(gpuCount); } retrieveProperties() { - return this.storedProperties; + return this.smi.retrieveProperties(); } hasSettings() { From fcb6ce1afa8328c5ceb7894fd9ac55cc41849f2b Mon Sep 17 00:00:00 2001 From: Keno Hassler <40292329+kenohassler@users.noreply.github.com> Date: Wed, 21 Feb 2024 13:38:34 +0100 Subject: [PATCH 2/6] clearer instructions in readme --- README.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 9524ca5..e166498 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,8 @@ The "master" branch supports only Gnome v45+. For older shell versions, please check out the "legacy" branch. # Requirements -nvidia-settings and nvidia-smi +The extension requires `nvidia-smi`, which should be included with the drivers. +Additionally, `nvidia-settings` is supported as a data source. # Installation from git git clone https://github.com/ethanwharris/gnome-nvidia-extension.git @@ -18,8 +19,9 @@ nvidia-settings and nvidia-smi make make install -Use `alt + f2`, `r`, `Enter` to restart the gnome shell (if this is not allowed then log out and log back in) -Enable the extension in the gnome tweak tool. +Restart gnome shell by logging out and back in. +On X11, you can also use `alt + f2`, `r`, `Enter` to reload more quickly. +Afterwards, you can enable the extension in the gnome tweak tool. # Icons For icons we use font-awesome: From 7345deacbbce5bbc744f36153f180a996e1be845 Mon Sep 17 00:00:00 2001 From: Keno Hassler <40292329+kenohassler@users.noreply.github.com> Date: Wed, 21 Feb 2024 13:44:14 +0100 Subject: [PATCH 3/6] clarify property selection --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index e166498..cb135fe 100644 --- a/README.md +++ b/README.md @@ -23,6 +23,10 @@ Restart gnome shell by logging out and back in. On X11, you can also use `alt + f2`, `r`, `Enter` to reload more quickly. Afterwards, you can enable the extension in the gnome tweak tool. +# Selecting Properties +By default, no measurements are displayed in the menu bar. +You can open the dropdown menu and select the properties to be shown. + # Icons For icons we use font-awesome: http://fontawesome.io/ From b7623808239906109ce59db4ee79a0f71c762be4 Mon Sep 17 00:00:00 2001 From: Keno Hassler <40292329+kenohassler@users.noreply.github.com> Date: Wed, 21 Feb 2024 14:01:37 +0100 Subject: [PATCH 4/6] use sub-headings --- README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index cb135fe..96f331d 100644 --- a/README.md +++ b/README.md @@ -5,15 +5,15 @@ A Gnome extension to show Nvidia GPU information (https://extensions.gnome.org/extension/1320/nvidia-gpu-stats-tool/) -# Supported Gnome versions +## Supported Gnome versions The "master" branch supports only Gnome v45+. For older shell versions, please check out the "legacy" branch. -# Requirements +## Requirements The extension requires `nvidia-smi`, which should be included with the drivers. Additionally, `nvidia-settings` is supported as a data source. -# Installation from git +## Installation from git git clone https://github.com/ethanwharris/gnome-nvidia-extension.git cd gnome-nvidia-extension make @@ -23,11 +23,11 @@ Restart gnome shell by logging out and back in. On X11, you can also use `alt + f2`, `r`, `Enter` to reload more quickly. Afterwards, you can enable the extension in the gnome tweak tool. -# Selecting Properties +## Selecting Properties By default, no measurements are displayed in the menu bar. You can open the dropdown menu and select the properties to be shown. -# Icons +## Icons For icons we use font-awesome: http://fontawesome.io/ From 29deec57d9f2c48938153371952f812ce35b878b Mon Sep 17 00:00:00 2001 From: Keno Hassler <40292329+kenohassler@users.noreply.github.com> Date: Tue, 16 Apr 2024 10:15:22 +0200 Subject: [PATCH 5/6] address review issues --- README.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 96f331d..f79a753 100644 --- a/README.md +++ b/README.md @@ -19,9 +19,11 @@ Additionally, `nvidia-settings` is supported as a data source. make make install -Restart gnome shell by logging out and back in. -On X11, you can also use `alt + f2`, `r`, `Enter` to reload more quickly. -Afterwards, you can enable the extension in the gnome tweak tool. +Restart gnome shell to load the extension: +- On Wayland, log out and back in. +- On X11, you can also use `alt + f2`, `r`, `Enter` to reload more quickly. + +Afterwards, you can enable the extension in gnome-extensions. ## Selecting Properties By default, no measurements are displayed in the menu bar. From e1bf5d4df782ddb056f05e522bfa4e2c4a2adbf4 Mon Sep 17 00:00:00 2001 From: Keno Hassler <40292329+kenohassler@users.noreply.github.com> Date: Tue, 16 Apr 2024 13:58:02 +0200 Subject: [PATCH 6/6] add comment about optimus --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index f79a753..889e5a4 100644 --- a/README.md +++ b/README.md @@ -13,6 +13,8 @@ For older shell versions, please check out the "legacy" branch. The extension requires `nvidia-smi`, which should be included with the drivers. Additionally, `nvidia-settings` is supported as a data source. +If you still use [Bumblebee](https://wiki.archlinux.org/title/Bumblebee), the data can also be sourced through `optirun` (this is untested and may be deprecated in future versions). + ## Installation from git git clone https://github.com/ethanwharris/gnome-nvidia-extension.git cd gnome-nvidia-extension