Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Fixed Widths #203

Open
AlexvZyl opened this issue Jul 25, 2022 · 4 comments
Open

[Feature Request] Fixed Widths #203

AlexvZyl opened this issue Jul 25, 2022 · 4 comments
Assignees

Comments

@AlexvZyl
Copy link

Currently the updating numbers cause the entire widget to move around when the amount of numbers change, which is distracting in some cases. It would be nice if there could be a fixed widths options, like with Vitals.

@AlexvZyl
Copy link
Author

AlexvZyl commented Jul 25, 2022

@ethanwharris If you do not have the time for this, let me know and I can give it a shot when I get some spare time.

@derenv derenv added enhancement feature Suggestion Suggested new features labels Jul 28, 2022
@derenv
Copy link
Collaborator

derenv commented Jul 28, 2022

Could you provide screenshots of Vitals @Alex-vZyl ?

I like the idea, varying fixed width options would be good.. at minimum it should scale to the width of 4 characters for each value by default (3 numerals and a symbol '%' or degrees C etc) which should reduce the issue, with other options allowing gaps in between stats for customisation.

@AlexvZyl
Copy link
Author

AlexvZyl commented Jul 28, 2022

Here is a screenshot of vitals and nvidia stats:
image

Vitals implemented their fixed widths in a dynamic manner. The width is taken as the widest the element has been. So if a value goes from 1% to 10% the element widens and everything moves. The same for going from 10% to 100%. It does not shrink when going from a larger element to a smaller one (100% to 10%), obviously. This makes sense, since vitals has a ton of stuff they monitor, all with different values and units.

However, this causes inconsistencies and some elements are wider than others, and sometimes there are large open white spaces. This can be seen in the first element.

I like your idea of having a fixed width of 4 characters. It is simple and very consistent. It is especially viable since this extension just monitors 4 resources.

@derenv
Copy link
Collaborator

derenv commented Aug 4, 2022

@Alex-vZyl I've created a branch (feature-request-fixed-widths) feel free to make pull requests if you want. I plan on having a look at some point, but i'm quite busy atm so if you have the time/energy go for it!

I've got a passthrough VM (i don't use gnome currently) so i can do some validation testing if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Low priority
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants