Not working if the fan is not detected #206
Comments
francescortu
changed the title
francescortu
changed the title
|
I can confirm that after an upgrade to Ubuntu 22.04 I started getting an error notification popping up every 5 seconds related to the gpu fan speed. Here is the exact error from the journal: I can change the stats tool to only show Nvidia SMI to suppres the errors. It returns when set to Nvidia Settings. When I execute that query manually here are the results: Hope that helps. |
|
On some systems nvidia-settings doesn't provide fan speed detection support. On my HP Pavilion laptop it says- I'm using Pop_OS! 22.04 with nvidia-settings version 510.47.03. The GPU is nVidia GeForce 940MX along with Intel HD Graphics (i.e. it's a hybrid GPU system). |
|
@merajmasuk @Francesc0rtu Is there a reason any of you are using nvidia-settings over optimus as the provider? (I don't have a laptop with an Nvidia GPU or i would check to see the differences myself, i haven't used the extension itself in quite some time either) (@jherubin are you also using a laptop?) nvidia-settings won't be able to do fan queries on laptops where the GPU (discreet or iGPU i guess) doesn't have a separate fan/cooling system. EDIT: follow up question, does the error crash the extension? |
|
@derenv Yes, I am using a laptop. It's a Dell XPS 9570 with a GeForce GTX 1050 Ti discrete GPU. For your follow-up question: When I get those errors it does not crash the extension. |
|
@derenv Nope, I'm not using Optimus that's for sure. |
|
@derenv |
- Added "parse()" function to "FanProperty" class, checks if output is equal to "ERROR: The requested operation is not available on target device" and responds accordingly - A bunch of debug logging for testing - Need to check the equivalent error from "nvidia-smi" if there are no fans (will apply to optimus too) - Need to check if "N/A" message is reasonable Signed-off-by: derenv <[email protected]>
|
@jherubin @merajmasuk @Francesc0rtu I've implemented an initial fix, but the branch ("fan_not_detected") needs testing as i don't have equivalent hardware:
I've added a couple log statements in the new function just for testing/debugging (see the modified file) which you can view using 'journalctl' and/or 'journalctl | grep -e 'nvidia gnome extension"' in the command line (The latter won't catch any errors). |
|
@derenv I tried, this is the result:
|
Huh.. If the nvidia-settings subprocess fails the error message should be different (see processor.js:49), and the fix in the new branch should catch a rubbish input from a nvidia-settings property (or at the very least print it out to the log, see settingsProperties.js:82).
Can you post the full |
|
The journal is: In addition I have tried to remove the Fan query from the src. Now the extension seems work, however I don't understand why is shown as in the picture and I cannot see the icons on the top bar. |
|
@Francesc0rtu Ah, it is being caught by processor.js:49
^The call to nvidia-settings will return a failure error status but still return the other values (GPUUtilization, GPUCoreTemp, UsedDedicatedGPUMemory, TotalDedicatedGPUMemory). This means it triggers the catch block in the execCommunicate() function (see subprocess.js:99).. This is because the extension joins the properties into a single call - a possible solution could be to create another provider that acts as a duplicate of settingsProvider.js with only the fan settings property removed. I'll update the 'fan_not_detected' branch at some point today with a first implementation of this. |
|
New fix is now implemented in the 'fan_not_detected' branch! Sorry for the delay, i managed to have a bunch of issues with my VM's right before Christmas. There's now 3 new options for providers, labelled a "Laptop" version that has no fan property. Let me know if this works for you. |
|
A potential way to mitigate things like this in the future is to have each individual thing be toggleable in the settings. If it's done that way you wouldn't have to have another option for "Laptop" (and potentially not need options in general & just go off of what's enabled). |
You can already enable/disable each property by clicking on it - unsure if this was working for the people with the error or if it was breaking things! |
Correct me if I'm wrong but I don't think it works that way. I think by clicking on you can only choose whether a property will be displayed on the panel or not. Before: After: You can also see from the screenshot that the latest fix (the options with Laptop suffix) from fan_not_detected branch is working for me just fine. |
|
@kenohassler would appreciate your thoughts here! branch
either way the branch needs rebased and updated, and should probably come after the changes in #213 and #214. |
|
Hi @derenv, |
agreed, reducing the number of user settings is probably a good idea - it will definitely need a log entry though, so if the detection misbehaves users can report this via an issue.
I'll have a look at this in the near future, thanks for the starting point. |
In my laptop nvidia-settings don't detect the fan speed, so when the extension start raise an error.
There is a way to deleted the fan query from the code?
I tried to deleted some things in the code but when I install the application, although there is no more error, do not shown the icons in the top bar.
Some suggestions?
Thanks
The text was updated successfully, but these errors were encountered: