Skip to content
This repository has been archived by the owner on Apr 24, 2022. It is now read-only.

Feature Request: Prometheus Endpoint for Large Scale Monitoring #124

Open
liskl opened this issue Jul 5, 2017 · 12 comments
Open

Feature Request: Prometheus Endpoint for Large Scale Monitoring #124

liskl opened this issue Jul 5, 2017 · 12 comments

Comments

@liskl
Copy link

liskl commented Jul 5, 2017

I'd love to see a Prometheus Endpoint for Eth Miner hosted on the microhttpd interface maybe

/metrics route

that can give us more time based stats for the service using just a reqular http plain/text based output page.

examples of howto display the text so prometheus can pull it easily
https://prometheus.io/docs/instrumenting/exposition_formats/

would be willing to pitch a few Etherium to whoever just gets the following instrumented on the http://0.0.0.0:3333/metrics route

# TYPE hashes_Per_Second Gauge
hashes_Per_Second 24770000
shares_Accepted_Total_Since_Start 200```
@smurfy
Copy link
Collaborator

smurfy commented Aug 19, 2017

@chfast
Wanted to start working on a remote monitoring but i ran into various things.

  • libjsonrpccpp has no http_server enabled (missing microhttpd)
  • libjsonrpccpp tcp socket server fails to compile on windows
  • microhttpd not yet a hunter module (i saw you are working on that)

Also not sure if we should use prometheus "protocol".
My idea would be, a claymore api compatible. there is already a monitor tool for that.

@chfast
Copy link
Contributor

chfast commented Aug 19, 2017

Yes, I'm working on bringing libmicrohttpd to Hunter, but it is not top priority. Do you need JSON RPC for this?

@smurfy
Copy link
Collaborator

smurfy commented Aug 19, 2017

Not necessarily, but libmicrohttpd would probably help in most cases.
Will maybe do some more tests with the tcp socket server. i'm new to cmake and hunter.

@emily-pesce
Copy link

This would be HUGE! I'd love to be able to use Ethminer in AwesomeMiner with claymore-level monitoring!!!

@smurfy
Copy link
Collaborator

smurfy commented Aug 22, 2017

I will create a PR in the next 24h with basic stats support. (Works with ethmon from claymore)
The PR will be a Work in progress. More information in the PR description once created.

@liskl
Copy link
Author

liskl commented Aug 23, 2017

Still would love the Prometheus http /metrics endpoint. For me that would be way more scalable in large infrastructure and homelabs.

@smurfy
Copy link
Collaborator

smurfy commented Aug 23, 2017

@liskl I hear you, the plan is to extend the api to support different protocols in the future. (like prometheus). I think it depends a bit on libmicrohttpd or similiar library supported by hunter.

@jean-m-cyr
Copy link
Contributor

I think it depends a bit on libmicrohttpd or similiar library supported by hunter.

Why not just boost::network::http ?

@DeadManWalkingTO
Copy link
Contributor

Now it's better.
Try latest version and feedback please.
Thank you!

@AndreaLanfranchi
Copy link
Collaborator

Easy to implement now with new API server.
Need specs about metrics

@8-Lambda-8
Copy link

#2398
I Implemented it into the API Server

@8-Lambda-8
Copy link

Grafana dashboard with data from Prometheus:
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants