Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nobridge flag for incompatible tokens #961

Open
AlexBHarley opened this issue Oct 11, 2024 · 0 comments
Open

nobridge flag for incompatible tokens #961

AlexBHarley opened this issue Oct 11, 2024 · 0 comments

Comments

@AlexBHarley
Copy link
Contributor

In my opinion the main purpose of this repository is to provide an index of StandardBridge compatible tokens. That is, tokens compatible with the IOptimismMintableERC20 or IL2StandardERC20 interfaces.

What we have instead is many 3rd party bridge tokens (Layer Zero OFTs, Wormhole NTTs, etc) that are not compatible with the native StandardBridge contracts but specify a bridge override. In my opinion these should be specify the nobridge: true flag so they don't show up in the generated optimism.tokenlist.json file.

Neither of these cases are desirable nice so I'd prefer if these were just automatically filtered out. I believe the CI checks used to enforce this, but they've been slightly altered and now if a bridge override is present it still allows adding tokens with a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant