From f508330566c0f241deb3f18618f19bde54b45f9a Mon Sep 17 00:00:00 2001 From: protolambda Date: Wed, 15 Jan 2025 10:41:33 -0600 Subject: [PATCH] eth/catalyst: engine API test add back require payloadID equality --- eth/catalyst/api_test.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/eth/catalyst/api_test.go b/eth/catalyst/api_test.go index 796d4999e4..7044b61e80 100644 --- a/eth/catalyst/api_test.go +++ b/eth/catalyst/api_test.go @@ -1106,6 +1106,7 @@ func TestWithdrawals(t *testing.T) { BeaconRoot: blockParams.BeaconRoot, Version: engine.PayloadV2, }).Id() + require.Equal(t, payloadID, *resp.PayloadID) require.NoError(t, waitForApiPayloadToBuild(api, payloadID)) execData, err := api.GetPayloadV2(payloadID) if err != nil { @@ -1141,7 +1142,8 @@ func TestWithdrawals(t *testing.T) { }, } fcState.HeadBlockHash = execData.ExecutionPayload.BlockHash - _, err = api.ForkchoiceUpdatedV2(fcState, &blockParams) + // note: diff, need latest response to get payload ID comparison right. + resp, err = api.ForkchoiceUpdatedV2(fcState, &blockParams) if err != nil { t.Fatalf("error preparing payload, err=%v", err) } @@ -1156,6 +1158,7 @@ func TestWithdrawals(t *testing.T) { BeaconRoot: blockParams.BeaconRoot, Version: engine.PayloadV2, }).Id() + require.Equal(t, payloadID, *resp.PayloadID) require.NoError(t, waitForApiPayloadToBuild(api, payloadID)) execData, err = api.GetPayloadV2(payloadID) if err != nil { @@ -1676,6 +1679,7 @@ func TestParentBeaconBlockRoot(t *testing.T) { BeaconRoot: blockParams.BeaconRoot, Version: engine.PayloadV3, }).Id() + require.Equal(t, payloadID, *resp.PayloadID) require.NoError(t, waitForApiPayloadToBuild(api, *resp.PayloadID)) execData, err := api.GetPayloadV3(payloadID) if err != nil {