Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New release() getter to represent the release (Upgrade 12) #13076

Closed
Tracked by #13069
maurelian opened this issue Nov 25, 2024 · 2 comments
Closed
Tracked by #13069

New release() getter to represent the release (Upgrade 12) #13076

maurelian opened this issue Nov 25, 2024 · 2 comments
Assignees
@AmadiMichael

Comments

@maurelian
Copy link
Contributor

maurelian commented Nov 25, 2024 •
edited
Loading

Just like the version() getters, but this will only be incremented once per release, and will be in sync with the op-contracts version number.
@maurelian maurelian mentioned this issue Nov 25, 2024
Open
34 tasks
@maurelian maurelian changed the title New version() getter to represent the release New release() getter to represent the release Nov 25, 2024
@maurelian
Copy link
Contributor Author

A more thorough spec for this can now be found here.

@AmadiMichael AmadiMichael self-assigned this Jan 10, 2025
@BlocksOnAChain BlocksOnAChain moved this from Todo to Done in OP Stack Upgrades Jan 10, 2025
@BlocksOnAChain BlocksOnAChain closed this as completed by moving to Done in OP Stack Upgrades Jan 10, 2025
@BlocksOnAChain BlocksOnAChain changed the title New release() getter to represent the release New release() getter to represent the release (Upgrade 12) Jan 10, 2025
@maurelian maurelian reopened this Jan 10, 2025
@maurelian maurelian moved this from Done to In Progress in OP Stack Upgrades Jan 10, 2025
@maurelian maurelian moved this from In Progress to Todo in OP Stack Upgrades Jan 10, 2025
@AmadiMichael AmadiMichael mentioned this issue Jan 13, 2025
Closed
@maurelian maurelian moved this from Todo to In-review in OP Stack Upgrades Jan 13, 2025
@maurelian
Copy link
Contributor Author

We've elected not to do this, as it would have modified the bytecode of all contracts unnecessarily.

@maurelian maurelian closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2025
@github-project-automation github-project-automation bot moved this from In-review to Done in OP Stack Upgrades Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmadiMichael AmadiMichael

Labels
None yet
Projects
OP Stack Upgrades
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add release abstract contract ethereum-optimism/optimism
3 participants
@maurelian @BlocksOnAChain @AmadiMichael