Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas Limit defined in two places? #139

Open
fubuloubu opened this issue Nov 13, 2018 · 1 comment
Open

Gas Limit defined in two places? #139

fubuloubu opened this issue Nov 13, 2018 · 1 comment

Comments

@fubuloubu
Copy link
Contributor

What was wrong?

I went looking for where the gas limit is set and noticed the default number is set in two places? This didn't seem right.

GENESIS_GAS_LIMIT = 3141592

"gas_limit": 3141592,

How can it be fixed?

Probably use the constant in make_genesis_block() as a default.

@carver
Copy link
Contributor

carver commented Nov 14, 2018

These are two different backends (mock and py-evm), they shouldn't import from each other. It's possible that it could make sense to have it import from a third place, which would probably be something like eth-constants -- although that doesn't actually have any constants in it, just a TODO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants