Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes, a single, simple test will fail under multi-threaded test running #556

Closed
msooseth opened this issue Sep 16, 2024 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@msooseth
Copy link
Collaborator

Sometimes, a single, simple test will fail under multi-threaded test running. Specifically:

cabal run -f devel test -- -p '/access-out-of-bounds-array/'

if ran 10x or so on an x64, it will fail. Both solc and the SMT solver (z3?) are being communicated via channels, so it makes no sense to me, it shouldn't be a file write race/hazard, as the case was with #555 . Something is odd.

@msooseth msooseth added the bug Something isn't working label Sep 16, 2024
@blishko
Copy link
Collaborator

blishko commented Sep 16, 2024

Hmm, on my arm Mac, there was no failure (ran it 50 times).

@msooseth
Copy link
Collaborator Author

OK, so this has been nailed down to

-        (a, b) <- liftIO $ concurrently evalLeft evalRight
+        a <- liftIO $ evalLeft
+        b <- liftIO $ evalRight

Will be fixed once #555 is merged. Sad day.

@blishko
Copy link
Collaborator

blishko commented Oct 4, 2024

This was fixed by #555 and #560.

@blishko blishko closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants