Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulators/eth2: Add test for block value boost flags across clients #1062

Open
marioevz opened this issue Mar 20, 2024 · 0 comments
Open

simulators/eth2: Add test for block value boost flags across clients #1062

marioevz opened this issue Mar 20, 2024 · 0 comments
Assignees

Comments

@marioevz
Copy link
Member

Create a test using the mock builder that verifies the behavior of these flags.

  • We should create a hive flag that translates generic value into a client specific value that can be properly parsed by the flag inside the client's docker bash script
  • We should test that:
    • a) Even with the flag set to a very high value, the client still uses the builder's payload if the reward indeed surpasses the minimum expected value
    • b) The client correctly falls back to local block production if the builder does not surpasses this value
  • The test cannot expect the value to be exact (e.g. on a 10% value, the mock builder is not configured to boost to exactly 10%, because the test will fail intermittently)

Nimbus: status-im/nimbus-eth2#6103
Lighthouse: sigp/lighthouse#5441
Lodestar: ChainSafe/lodestar#6568
Teku: Consensys/teku#8108
Prysm: prysmaticlabs/prysm#13772

@fredriksvantes

@marioevz marioevz self-assigned this Mar 20, 2024
@marioevz marioevz changed the title simulators/eth2: Add test for block value boost flags accross clients simulators/eth2: Add test for block value boost flags across clients Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant