Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCIP-read fallback on network errors #4842

Open
eth-limo opened this issue Sep 23, 2024 · 4 comments
Open

CCIP-read fallback on network errors #4842

eth-limo opened this issue Sep 23, 2024 · 4 comments
Labels
bug Verified to be an issue. next-patch Issues scheduled for the next arch release. on-deck This Enhancement or Bug is currently being worked on.

Comments

@eth-limo
Copy link

eth-limo commented Sep 23, 2024

Describe the Feature

Hello,

Per this thread: https://discuss.ens.domains/t/erc-3668-edge-case-for-clientside-http-ssl-errors/19617, it looks like network errors or non-http error responses can prevent CCIP clients from falling back to a secondary gateway URL. I believe this is also impacting the CCIP-read client in ethers.

This would be a great addition to ethers.js as user implemented offchain resolvers continue to grow.

Thanks!

Code Example

No response

@eth-limo eth-limo added the enhancement New feature or improvement. label Sep 23, 2024
@ricmoo
Copy link
Member

ricmoo commented Sep 30, 2024

Working on reproduction steps now, but if anyone has an existing CCIP-read contract set up that can replicate this issue, it'd be appreciated. :)

@ricmoo
Copy link
Member

ricmoo commented Oct 1, 2024

I've recreated the original CCIP-Read Test Contract; the original source was lost, but the new version should be completely compatible. It also now has a test to reproduce the problem in this issue, so a fix should be available soon.

Please see the test contract.

@ricmoo ricmoo added bug Verified to be an issue. on-deck This Enhancement or Bug is currently being worked on. next-patch Issues scheduled for the next arch release. and removed enhancement New feature or improvement. labels Oct 1, 2024
@ricmoo
Copy link
Member

ricmoo commented Oct 1, 2024

This has been fixed in v6.13.3.

Let me know if you still have any issue!

Thanks! :)

@eth-limo
Copy link
Author

eth-limo commented Oct 1, 2024

Thanks @ricmoo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified to be an issue. next-patch Issues scheduled for the next arch release. on-deck This Enhancement or Bug is currently being worked on.
Projects
None yet
Development

No branches or pull requests

2 participants