Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black version in CI #50

Open
Adrok24 opened this issue Feb 15, 2024 · 1 comment
Open

black version in CI #50

Adrok24 opened this issue Feb 15, 2024 · 1 comment

Comments

@Adrok24
Copy link
Collaborator

Adrok24 commented Feb 15, 2024

The black version that is running in the github ci is 24.1 but in the pre-commit is 23.3, so is creating conflict. It would be better to uniform this, maybe installing pre-commit and running pre-commit also in CI instead of installing a black independently, or forcing version too at CI.

soxofaan added a commit that referenced this issue Feb 19, 2024
@soxofaan
Copy link
Contributor

soxofaan commented Feb 19, 2024

as quickfix, I already pinned black in GH workflow to same version as in pre-commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants