Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDP notebook finetuning #69

Open
soxofaan opened this issue Jun 6, 2024 · 0 comments
Open

UDP notebook finetuning #69

soxofaan opened this issue Jun 6, 2024 · 0 comments

Comments

@soxofaan
Copy link
Contributor

soxofaan commented Jun 6, 2024

I recently gave a demo using https://documentation.dataspace.copernicus.eu/notebook-samples/openeo/UDP.html
and wanted to feedback some notes and improvements (I'm bit in hurry and can't do it as PR):

  • import json is unused

  • spatial_extent_param = Parameter(
        name="bbox",
        description="The bounding box to load.",
        schema={"type": "object", "subtype": "geojson"},
    )
    

    this is confusing: the parameter name is bbox, but the subtype is geojson. I think the name should be changed to "geometry" or the subtype should be changed to "bounding-box".

  • connection.datacube_from_process... : also add a description, e.g. description="NDWI: Normalized Difference Water Index"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant