Skip to content
This repository has been archived by the owner on Aug 30, 2024. It is now read-only.

repos validator needs to handle missing urls #88

Open
nephomaniac opened this issue Nov 20, 2015 · 0 comments
Open

repos validator needs to handle missing urls #88

nephomaniac opened this issue Nov 20, 2015 · 0 comments

Comments

@nephomaniac
Copy link

It seems that if any of the following Env attributes are not defined, than the value 'None' is appended to a list of URLs to test.
['default-img-url', 'euca2ools-repo', 'eucalyptus-repo', 'init-script-url', 'post-script-url']

This causes an exception during Request(url) which causes the validation to halt.
Suggesting the following:

  • Mandatory URL such as eucalyptus-repo and euca2ools-repo should fail if not defined. We can ignore all other undef'd urls above.
  • If an URL is defined but fails the request test, than a failure should be displayed regardless of the url.
  • Also not sure if we should raise exceptions for these or just display these as failures? An exception currently halts any other urls from being validated.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant