Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Use frida as a submodule #343

Open
yunwei37 opened this issue Sep 2, 2024 · 8 comments
Open

[FEATURE] Use frida as a submodule #343

yunwei37 opened this issue Sep 2, 2024 · 8 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@yunwei37
Copy link
Member

yunwei37 commented Sep 2, 2024

Is your feature request related to a problem? Please describe.

We have get some bug report and performance issues related to Frida, it would be better to manage it as a submodule instead of download binary from the release.

#191 #137

Describe the solution you'd like

Use Frida as submodule in third_party dir.

@yunwei37 yunwei37 added enhancement New feature or request help wanted Extra attention is needed labels Sep 2, 2024
@Officeyutong
Copy link
Contributor

Do you mean to build frida from source?

@yunwei37
Copy link
Member Author

yunwei37 commented Sep 2, 2024

Yes. Using https://github.com/frida/frida-gum

@Officeyutong
Copy link
Contributor

Officeyutong commented Sep 2, 2024

Yes. Using https://github.com/frida/frida-gum

Building frida is very complex and slow, it requires many dependencies (such as meson) and can't be integrated into CMake, It also takes about 10 minutes on my machine(E5 2697v2 *2) to build. I suggest not doing such thing, since frida releases pre built binaries

@yunwei37
Copy link
Member Author

yunwei37 commented Sep 5, 2024

You can try open a github codespace and type make to compile the frida-gum? It taake about 30s-1min to compile on Github Codespace. The codespace's hardware is very limited.

I think it's not a complex process to compile it. Maybe you have some network issues?

@Officeyutong
Copy link
Contributor

Officeyutong commented Sep 6, 2024

You can try open a github codespace and type make to compile the frida-gum? It taake about 30s-1min to compile on Github Codespace. The codespace's hardware is very limited.

I think it's not a complex process to compile it. Maybe you have some network issues?

I still suggest using prebuilt binaries since frida released them, I suggest using source only when there is not binary release. Since building from source may slow down the compile process.

Also, is there any dependency needs to be installed manually when building frida? From the CI of frida, seems meson should be installed

@yunwei37
Copy link
Member Author

yunwei37 commented Sep 6, 2024

I agree with you. Maybe using frida as a binray would be better.

For the performance problem, I think maybe we can have our own release by building frida ourselves in another repo?

@Officeyutong
Copy link
Contributor

I agree with you. Maybe using frida as a binray would be better.

For the performance problem, I think maybe we can have our own release by building frida ourselves in another repo?

We may create a fork and let CI release them if we made some changes to frida

@yunwei37
Copy link
Member Author

yunwei37 commented Sep 7, 2024

Agree that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants