Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test passes when there are errors in cargo-expand output #114

Open
Pistonight opened this issue Jun 6, 2024 · 1 comment
Open

Test passes when there are errors in cargo-expand output #114

Pistonight opened this issue Jun 6, 2024 · 1 comment

Comments

@Pistonight
Copy link

I am not sure if this is a cargo-expand issue or intentional

If a syn::Type has generics and is used in an expression like #ty::#ident, cargo-expand outputs "(/ERROR/)"

use quote::quote;
let ty = syn::parse_quote! { Box<Foo> };
// put this somewhere in the expand output
quote! { #ty::some_thing }

The output will be:

(/*ERROR*/)

The catch is the syntax should be quote! { <#ty>::some_thing }. However, macrotest will pass.

Ideally, there are some places in other tests/examples that use the macro and will catch the issue, but would be nice if macrotest fails.

@taiki-e
Copy link
Collaborator

taiki-e commented Oct 1, 2024

I guess this is a cargo-expand or rustc issue since the macrotest fails if the cargo-expand exits with a non-zero code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants