Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git tag missing for 1.0.9 #97

Open
ijackson opened this issue Mar 29, 2024 · 0 comments
Open

git tag missing for 1.0.9 #97

ijackson opened this issue Mar 29, 2024 · 0 comments

Comments

@ijackson
Copy link
Contributor

I wanted to investigate an issue, but found that I although was using 1.0.9 from crates.io but there wasn't a corresponding git tag.

Normally, cargo puts a .cargo_vcs_info.json in the generated .crate file, if the release is made from git. Investigating the .crate file I think the release was made roughly from 3751785. The only difference (apart from changes made to Cargo.toml by cargo publish) is a one-line change to .gitignore.

Was 1.0.9 made from a dirty git working tree? I recommend the use of automated tooling for releasing which checks things like "is the git tree clean" and also makes the tags.

To remedy this, I suggest: make a temporary git branch containing this delta

diff --git a/.gitignore b/.gitignore
index ff23b2d..9345978 100644
--- a/.gitignore
+++ b/.gitignore
@@ -4,3 +4,4 @@ Cargo.lock
 *.iml
 *.ipr
 *.iws
+.idea

and tag it 1.0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant