Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC/eip is not updated within a basic block #27

Open
enlighten5 opened this issue Apr 20, 2023 · 0 comments
Open

PC/eip is not updated within a basic block #27

enlighten5 opened this issue Apr 20, 2023 · 0 comments

Comments

@enlighten5
Copy link

QEMU does not update the pc within a basic block at runtime. Specifically,

  1. Instructions in one basic block will have the same pc as the first instruction.

  2. Blocks that are patched together by a jump instruction will have the same pc, i.e., pc will be not updated by the jump.

QEMU might do this for a better performance. but the pc is used by the backend for branch filtering and basic block pruning, an accurate pc can lead to better pruning results.

I have a fix in this commit. Please let me know if it makes sense.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant