Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting a raven.Http request in place of http.Request #30

Closed
flimzy opened this issue Dec 15, 2016 · 0 comments
Closed

Allow setting a raven.Http request in place of http.Request #30

flimzy opened this issue Dec 15, 2016 · 0 comments

Comments

@flimzy
Copy link
Contributor

flimzy commented Dec 15, 2016

In our application, we want to set the Data fields in the raven.Http struct which is logged.

logrus_sentry currently doesn't make this possible.

I see two possible solutions. The easiest one would be to make getHTTPRequest() return a raven.Http struct, either creating it from a http.Request, or returning it directly if it's already a raven.Http struct.

The more general solution would be #29. And even then, if #29 is decided to be a good idea, there might be room for both.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant