Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logrus.TraceLevel should be in v0.6 #73

Open
amckinney opened this issue Jan 4, 2019 · 0 comments
Open

logrus.TraceLevel should be in v0.6 #73

amckinney opened this issue Jan 4, 2019 · 0 comments

Comments

@amckinney
Copy link

The v0.5.1 release adds a reference to logrus.TraceLevel which was released in v1.2.0. Given that your repository doesn't pin its dependencies, this can result in transitive dependency failures.

Instead your #72 should be in a v6.0 release, and you could add an explicit dependency on https://github.com/sirupsen/logrus, i.e. with Go modules and/or dep. Otherwise, this results in an issue when users depend on https://github.com/sirupsen/logrus to ^1.2.0 to mitigate this in the future.

For clarity, a sample error would look something similar to:

./.../vendor/github.com/evalphobia/logrus_sentry/sentry.go:17:3: undefined: logrus.TraceLevel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant