[Bug] if layer has optionalAny, keys should allow optionalAny as well #116
DrakeEvans
started this conversation in
Ideas
Replies: 2 comments
-
Hi @DrakeEvans , thanks for trying the project out. It is a cool idea to pass optionalAny on the layer to manipulators. I've made it the default behaviour, so you do not need to manually add layer(';', 'arrow-mode')
.modifiers('??')
.manipulators({
j: toKey('←'),
i: toKey('↑'),
k: toKey('↓'),
l: toKey('→'),
}), Please update ( |
Beta Was this translation helpful? Give feedback.
0 replies
-
I rebased and it looks like its working!! Thank you |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
karabiner.ts/src/config/layer.ts
Line 154 in 40f160e
This code above enforces layers with modifiers do not allow keymaps to have modifiers but does not handle the case when both need to have optional any modifiers
This code produces valid configuration for example and is required to allow common shortcuts like command + left_arrow etc for the remapped keys
Beta Was this translation helpful? Give feedback.
All reactions