Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this a real path tracer? #4

Open
Overv opened this issue Aug 24, 2017 · 0 comments
Open

Is this a real path tracer? #4

Overv opened this issue Aug 24, 2017 · 0 comments

Comments

@Overv
Copy link

Overv commented Aug 24, 2017

The description mentions

To calculate a pixel color, a ray is shot into the scene and allowed to bounce around five times. At each bounce, the direct light incoming at that point (including shadows) is multiplied by all previous material colors and accumulated. Soft shadows are achieved by randomly jittering the light position per-pixel.

That sounds more like a small extension to ray tracing. With path tracing, rays should bounce around until they hit a light source and soft shadows should occur naturally. The point of path tracing is that tricks like jittering light positions are not necessary. Admittedly, the advantage of your implementation is that the quality improves really quickly, but it does not appear to be a real path tracer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant