15 no ability to use a custom icon #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # source/CustomMessageBoxDemo/MainWindow.xaml.cs # source/WPFCustomMessageBox/CustomMessageBoxWindow.xaml
…e while to messagebox is open
|
This PR should address the issues 6, 12, 13, 15 and 17 (maybe partly 5 too since you now can increase the maximum button width) |
|
The next two topics that I would like to tackle (separately) are the localization issue and I would also like to update the project files in order to have nuget packages being autogenerated during build (and maybe more supported frameworks). |
This was
linked to
issues
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @evanwon
I took some time to make a much larger pull request this time. In general I tried to have the project compliant with the MVVM style. In general I have created viewmodel and model classes and linked them together.
Users that might want to have more flexibility, can use the MessageBoxModel class directly. This one allows users to configure the messagebox much more freely. Also it allows users to use the known Show() and ShowDialog() methods. If Show() is being used it is even possible to update all texts in the MessageBox while it is still open. This way you could for example add a countdown to the message box.