Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JS SDK #4

Closed
6 of 9 tasks
nprail opened this issue Oct 26, 2019 · 10 comments · Fixed by #39
Closed
6 of 9 tasks

Implement JS SDK #4

nprail opened this issue Oct 26, 2019 · 10 comments · Fixed by #39
Labels
Milestone

Comments

@nprail
Copy link
Member

nprail commented Oct 26, 2019

Stripe Terminal has a JavaScript SDK for its Verifone countertop card readers. Since Capacitor focuses on both native and PWA platforms, should capacitor-stripe-terminal wrap the JS SDK as well?

At eventOne, we don't need the JS SDK since we only use the BBPOS readers. However, supporting the JS SDK would be a great feature for users who use both types of readers. Having a single JS API between platforms and devices would be awesome (and is something that you can't even do with Stripe's existing SDKs).

I will definitely accept any PRs for adding this feature.

To-Do

  • Implement Terminal JS SDK

    • Fetch connection tokens
    • Discover readers
    • Connect/disconnect a reader
    • Check for & install reader firmware updates
    • Create payment intents (see Create payment intents client side #44)
    • Retrieve payment intents
    • Collect payment methods
    • Process payments
@nprail nprail added enhancement New feature or request question Further information is requested labels Oct 26, 2019
@kyleabens
Copy link

kyleabens commented Jan 13, 2020

Im starting to dive into Stripe terminal now and 100% agree that supporting both SDKs with this one plugin would be a game changer.

@nprail
Copy link
Member Author

nprail commented Jan 16, 2020

@kyleabens Agreed. I'll probably implement it at some point. It probably won't even take to long (being a simple wrapper). It's just a matter of when I have time.

Out of curiosity, what's your use-case for Stripe Terminal?

@nprail nprail added the good first issue Good for newcomers label Jan 23, 2020
@nprail nprail mentioned this issue Jan 23, 2020
34 tasks
@nprail nprail changed the title Implement JS SDK? Implement JS SDK Jun 28, 2020
@nprail nprail added this to the 1.0.0 milestone Jun 28, 2020
@nprail nprail removed the question Further information is requested label Jun 28, 2020
@nprail nprail linked a pull request Sep 5, 2020 that will close this issue
@nprail nprail removed a link to a pull request Sep 7, 2020
nprail added a commit that referenced this issue Sep 7, 2020
@e1-bot
Copy link

e1-bot commented Sep 7, 2020

🎉 This PR is included in version 1.0.0-beta.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nprail
Copy link
Member Author

nprail commented Sep 7, 2020

@kyleabens Basic support for the JS SDK has been added. See the known limitations for what it doesn't support yet.

@kyleabens

This comment has been minimized.

@kyleabens

This comment has been minimized.

@nprail

This comment has been minimized.

@kyleabens

This comment has been minimized.

@nprail

This comment has been minimized.

@nprail nprail mentioned this issue Jan 22, 2021
@nprail nprail linked a pull request Jan 22, 2021 that will close this issue
@e1-bot
Copy link

e1-bot commented Jan 22, 2021

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants